Take advantage of GAP 4.11 features

Author: wilfwilson

gap/attr.gi

@@ -1814,8 +1814,8 @@ function(D, maxLength)
     # Extends a given chordless path if possible
     CCExtension := function(digraph, path, C, key, blocked)
         local v, extendedPath, data;
-        blocked := BlockNeighbours(digraph, path[Length(path)], blocked);
-        for v in OutNeighboursOfVertex(digraph, path[Length(path)]) do
+        blocked := BlockNeighbours(digraph, Last(path), blocked);
+        for v in OutNeighboursOfVertex(digraph, Last(path)) do
             if DigraphVertexLabel(digraph, v) > key and blocked[v] = 1
               and Length(path) < maxLength then
                 extendedPath := Concatenation(path, [v]);
@@ -1828,7 +1828,7 @@ function(D, maxLength)
                 fi;
             fi;
         od;
-        blocked := UnblockNeighbours(digraph, path[Length(path)], blocked);
+        blocked := UnblockNeighbours(digraph, Last(path), blocked);
         return [C, blocked];
     end;
 

gap/io.gi

@@ -275,10 +275,10 @@ function(filename)
   fi;
 
   splitname := SplitString(filename, ".");
-  extension := splitname[Length(splitname)];
+  extension := Remove(splitname);
 
   if extension in ["gz", "bz2", "xz"] then
-    extension := splitname[Length(splitname) - 1];
+    extension := Remove(splitname);
   fi;
 
   if extension = "txt" then
@@ -313,10 +313,10 @@ function(filename)
   fi;
 
   splitname := SplitString(filename, ".");
-  extension := splitname[Length(splitname)];
+  extension := Remove(splitname);
 
   if extension in ["gz", "bz2", "xz"] then
-    extension := splitname[Length(splitname) - 1];
+    extension := Remove(splitname);
   fi;
 
   if extension = "txt" then
@@ -549,9 +549,8 @@ function(arg...)
       # the file encoder was not specified and cannot be deduced from the
       # filename, so we try to make a guess based on the digraphs themselves
       splitname := SplitString(name, ".");
-      if splitname[Length(splitname)] in ["xz", "gz", "bz2"] then
-        compext := splitname[Length(splitname)];
-        splitname := splitname{[1 .. Length(splitname) - 1]};
+      if Last(splitname) in ["xz", "gz", "bz2"] then
+        compext := Remove(splitname);
       fi;
 
       # Do we know all the graphs to be symmetric?
@@ -647,7 +646,7 @@ function(arg...)
           " is a whole file encoder, and so only one digraph should be ",
           "specified. Only the last digraph will be encoded.");
     fi;
-    IO_Write(file, encoder(digraphs[Length(digraphs)]));
+    IO_Write(file, encoder(Last(digraphs)));
   else
     for i in [1 .. Length(digraphs)] do
       encoder(file, digraphs[i]);
@@ -715,7 +714,7 @@ function(filt, s)
   maxedges := n * (n - 1) / 2;
   if list <> [0] and list <> [1] and
       not (Int((maxedges - 1) / 6) + start = Length(list) and
-           list[Length(list)] mod 2 ^ ((0 - maxedges) mod 6) = 0) then
+           Last(list) mod 2 ^ ((0 - maxedges) mod 6) = 0) then
     ErrorNoReturn("the 2nd argument <s> is not a valid graph6 string,");
   fi;
 
@@ -732,8 +731,8 @@ function(filt, s)
         i := i / 2;
       else
         edge := FindCoord(pos + 6 - bpos, 0);
-        out[edge[1]][Length(out[edge[1]]) + 1] := edge[2];
-        out[edge[2]][Length(out[edge[2]]) + 1] := edge[1];
+        Add(out[edge[1]], edge[2]);
+        Add(out[edge[2]], edge[1]);
         nredges := nredges + 1;
         i := (i - 1) / 2;
       fi;
@@ -2165,7 +2164,7 @@ function(args...)
       positions := PositionsProperty(partition, x -> x = i);
       joinedPositions := JoinStringsWithSeparator(positions, " ");
       partitionString := Concatenation(partitionString, joinedPositions);
-      if i <> dflabels[Length(dflabels)] then
+      if i <> Last(dflabels) then
         partitionString := Concatenation(partitionString, " | ");
       fi;
     od;

makedoc.g

@@ -52,14 +52,9 @@ for Pkg in Concatenation(PkgInfo.Dependencies.NeededOtherPackages,
   XMLEntities.(entity_name) := RemovePrefixVersion(Pkg[2]);
 od;
 
-# Can change the following line to use Last() once we drop GAP 4.10 support
-ARCHIVE_BASENAME := SplitString(PkgInfo.ArchiveURL, "/");
-ARCHIVE_BASENAME := ARCHIVE_BASENAME[Length(ARCHIVE_BASENAME)];
-XMLEntities.ARCHIVE_BASENAME := ARCHIVE_BASENAME;
-
-ARCHIVENAME := Concatenation(ARCHIVE_BASENAME, PkgInfo.ArchiveFormats);
-XMLEntities.ARCHIVENAME := ARCHIVENAME;
-
+XMLEntities.ARCHIVE_BASENAME := Last(SplitString(PkgInfo.ArchiveURL, "/"));
+XMLEntities.ARCHIVENAME := Concatenation(XMLEntities.ARCHIVE_BASENAME,
+                                         PkgInfo.ArchiveFormats);
 XMLEntities.DIGRAPHS := PackageEntity("Digraphs");
 
 for Pkg in Concatenation(PkgInfo.Dependencies.NeededOtherPackages,
@@ -155,7 +150,6 @@ Unbind(MathOrCode);
 Unbind(XMLEntities);
 Unbind(PkgInfo);
 Unbind(Pkg);
-Unbind(ARCHIVENAME);
 Unbind(DocDir);
 Unbind(Files);
 Unbind(Includes);