Remove support for GAP 4.10

Author: wilfwilson

.github/workflows/ubuntu.yml

@@ -45,9 +45,6 @@ jobs:
             mode: default  # There wouldn't be much point testing GAP v4.11 with only needed packages. The only difference is whether Grape is loaded.
             pkgs-to-clone: https://github.com/digraphs/graphviz.git
             pkgs-to-build: io* orb* datastructures* profiling* grape*
-          - gap-version: v4.10  # Note: NautyTracesInterface requires GAP 4.12
-            mode: default  # There wouldn't be much point testing GAP v4.10 with only needed packages. The only difference is whether Grape is loaded.
-            pkgs-to-build: io* orb* datastructures profiling* grape*
 
     steps:
       - uses: actions/checkout@v5
@@ -60,16 +57,11 @@ jobs:
       - name: "Build Digraphs . . ."
         uses: gap-actions/build-pkg@v2
       - name: "Clone additional GAP packages . . ."
-        if: ${{ matrix.gap-version != 'v4.10' }}
         run: |
           for PKG in ${{ matrix.pkgs-to-clone }}; do
             cd ${GAPROOT}/pkg
             git clone $PKG
           done
-      # Special case for GAP v4.10 as it requires checking out a non-default ref
-      - name: "Clone datastructures v0.2.5 (GAP 4.10 only) . . ."
-        if: ${{ matrix.gap-version == 'v4.10' }}
-        run: git clone -b v0.2.5 https://github.com/gap-packages/datastructures ${GAPROOT}/pkg/datastructures
       - name: "Build relevant GAP packages . . ."
         run: |
           cd ${GAPROOT}/pkg

Makefile.gappkg

@@ -51,7 +51,7 @@ KEXT_BINARCHDIR = bin/$(GAParch)
 KEXT_SO = $(KEXT_BINARCHDIR)/$(KEXT_NAME).so
 
 # the following settings are provided by sysinfo.gap in GAP >= 4.12;
-# for compatibility with older GAP version (at least 4.9, 4.10, 4.11)
+# for compatibility with GAP 4.11
 # we try to "guess" suitable values here
 GAP ?= $(GAPPATH)/gap
 GAC ?= $(GAPPATH)/gac

PackageInfo.g

@@ -539,7 +539,7 @@ PackageDoc := rec(
 ),
 
 Dependencies := rec(
-  GAP := ">=4.10.0",
+  GAP := ">=4.11.0",
   NeededOtherPackages := [["IO", ">=4.5.1"],
                           ["orb", ">=4.8.2"],
                           ["datastructures", ">=0.2.5"]],

README.md

@@ -27,7 +27,7 @@ For questions, remarks, suggestions, and issues please use the
 ## Installation
 
 It is assumed that you have a working copy of [GAP][] with version number
-4.10.0 or higher.  The most up-to-date version of GAP, and instructions on how
+4.11.0 or higher.  The most up-to-date version of GAP, and instructions on how
 to install it, can be obtained from the 
 [main GAP webpage](https://www.gap-system.org).
 

init.g

@@ -45,13 +45,6 @@ fi;
 if not IsBound(Adjacency) then
   Adjacency := IdFunc;
 fi;
-# Avoid warnings with GAP 4.10 for use of FlipBlist
-# Can be removed once Digraphs requires GAP>=4.11
-if not IsBound(FlipBlist) then
-  FlipBlist := function(BList)
-    Apply(BList, x -> not x);
-  end;
-fi;
 
 ReadPackage("digraphs", "gap/digraph.gd");
 ReadPackage("digraphs", "gap/digraphs.g");

m4/find_gap.m4

@@ -83,9 +83,6 @@ AC_DEFUN([FIND_GAP],
     AC_MSG_ERROR([No GAP_CPPFLAGS is given])
   fi
 
-  # compatibility with GAP 4.9 (not needed in GAP >= 4.10)
-  GAP_CPPFLAGS="$GAP_CPPFLAGS -I${GAP_LIB_DIR}/src"
-
   AC_SUBST(GAPARCH)
   AC_SUBST(GAPROOT)
   AC_SUBST(GAP_CPPFLAGS)

read.g

@@ -30,12 +30,6 @@ BindGlobal("DIGRAPHS_NautyAvailable",
 
 Unbind(_NautyTracesInterfaceVersion);
 
-# Delete this when we no longer support GAP 4.10
-if not CompareVersionNumbers(ReplacedString(GAPInfo.Version, "dev", ""), "4.11")
-    and not IsBound(INTOBJ_MAX) then
-  BindGlobal("INTOBJ_MAX", 1152921504606846975);
-fi;
-
 ReadPackage("digraphs", "gap/utils.gi");
 ReadPackage("digraphs", "gap/digraph.gi");
 ReadPackage("digraphs", "gap/constructors.gi");

src/gap-includes.h

@@ -27,8 +27,4 @@
 // GAP headers
 #include "gap_all.h"  // for Obj, Int
                       //
-#ifdef GAP410_OR_OLDER
-#include "compiled.h"  // FIXME Remove include when we don't support GAP 4.10
-#endif
-
-#endif  // DIGRAPHS_SRC_GAP_INCLUDES_H_
+#endif                // DIGRAPHS_SRC_GAP_INCLUDES_H_

src/gap_all.h

@@ -52,16 +52,14 @@ Error, the 7th argument <injective> must 0, 1, or 2, not -1,
 gap> HomomorphismDigraphsFinder(gr1, gr2, fail, "a", infinity, 2, 1, 0, 0,
 > 0, 0);
 Error, the 8th argument <image> must be a list or fail, not integer,
-
-# Commented out due to difference in the rmessage for GAP 4.10 vs GAP 4.11
-#gap> HomomorphismDigraphsFinder(gr1, gr2, fail, [], 1, 1, 1, [1, []], 0,
-#> 0, 0);
-#Error, the 8th argument <image> must only contain positive integers, but found\
-# list (plain,empty) in position 2,
-#gap> HomomorphismDigraphsFinder(gr1, gr2, fail, [], 1, 1, 1, [[], []], 0,
-#> 0, 0);
-#Error, the 8th argument <image> must only contain positive integers, but found\
-# list (plain,empty) in position 1,
+gap> HomomorphismDigraphsFinder(gr1, gr2, fail, [], 1, 1, 1, [1, []], 0,
+> 0, 0);
+Error, the 8th argument <image> must only contain positive integers, but found\
+ empty plain list in position 2,
+gap> HomomorphismDigraphsFinder(gr1, gr2, fail, [], 1, 1, 1, [[], []], 0,
+> 0, 0);
+Error, the 8th argument <image> must only contain positive integers, but found\
+ empty plain list in position 1,
 gap> HomomorphismDigraphsFinder(gr1, gr2, fail, [], 1, 1, 1, [0, 1], 0, 0,
 > 0);
 Error, the 8th argument <image> must only contain positive integers, but found\