Remove callback version of every test.

Author: davidlehn

CHANGELOG.md

@@ -4,6 +4,12 @@
 - Initial support for benchmarking.
 - Basic callback interface tests.
 
+### Removed
+- Callback version of every test.
+  - Callback interface tests added to catch callback API errors.
+  - Avoids duplication of running every test for promises and callbacks.
+  - Simplifies testing code and makes async/await conversion easier.
+
 ## 1.1.0 - 2018-09-05
 
 ### Added

tests/test-common.js

@@ -270,24 +270,12 @@ function addTest(manifest, test, tests) {
   test.manifest = manifest;
   const description = test_id + ' ' + (test.purpose || test.name);
 
-  if(options.benchmark) {
-    // only promises
-    tests.push({
-      title: description,
-      f: makeFn({useCallbacks: false})
-    });
-  } else {
-    tests.push({
-      title: description + ' (promise)',
-      f: makeFn({useCallbacks: false})
-    });
-    tests.push({
-      title: description + ' (callback)',
-      f: makeFn({useCallbacks: true})
-    });
-  }
+  tests.push({
+    title: description,
+    f: makeFn()
+  });
 
-  function makeFn({useCallbacks}) {
+  function makeFn() {
     return function(done) {
       const self = this;
       self.timeout(5000);
@@ -418,19 +406,10 @@ function addTest(manifest, test, tests) {
         });
       };
 
-      // add nodejs style callback
-      if(useCallbacks) {
-        params.push(callback);
-      }
-
       // resolve test data run
       Promise.all(params).then(values => {
         const promise = jsonld[fn].apply(null, values);
-
-        // promise style
-        if(!useCallbacks) {
-          return promise.then(callback.bind(null, null), callback);
-        }
+        return promise.then(callback.bind(null, null), callback);
       }).catch(err => {
         console.error(err);
         throw err;