Make ReplaceRegexStep a bit more idiomatically a linter.

Author: nedtwigg

lib/src/main/java/com/diffplug/spotless/generic/ReplaceRegexStep.java

@@ -15,8 +15,6 @@
  */
 package com.diffplug.spotless.generic;
 
-import static com.diffplug.spotless.Lint.atLine;
-
 import java.io.File;
 import java.io.Serializable;
 import java.util.ArrayList;
@@ -41,13 +39,13 @@ public static FormatterStep create(String name, String regex, String replacement
 				State::toFormatter);
 	}
 
-	public static FormatterStep lint(String name, String regex, String error) {
+	public static FormatterStep lint(String name, String regex, String lintDetail) {
 		Objects.requireNonNull(name, "name");
 		Objects.requireNonNull(regex, "regex");
-		Objects.requireNonNull(error, "error");
+		Objects.requireNonNull(lintDetail, "lintDetail");
 		return FormatterStep.createLazy(name,
-				() -> new State(Pattern.compile(regex, Pattern.UNIX_LINES | Pattern.MULTILINE), error),
-				State::toLinter);
+				() -> new LintState(Pattern.compile(regex, Pattern.UNIX_LINES | Pattern.MULTILINE), name, lintDetail),
+				LintState::toLinter);
 	}
 
 	private static final class State implements Serializable {
@@ -64,6 +62,20 @@ private static final class State implements Serializable {
 		FormatterFunc toFormatter() {
 			return raw -> regex.matcher(raw).replaceAll(replacement);
 		}
+	}
+
+	private static final class LintState implements Serializable {
+		private static final long serialVersionUID = 1L;
+
+		private final Pattern regex;
+		private final String ruleId;
+		private final String lintDetail;
+
+		LintState(Pattern regex, String ruleId, String lintDetail) {
+			this.regex = regex;
+			this.ruleId = ruleId;
+			this.lintDetail = lintDetail;
+		}
 
 		FormatterFunc toLinter() {
 			return new FormatterFunc() {
@@ -78,7 +90,7 @@ public List<Lint> lint(String raw, File file) {
 					var matcher = regex.matcher(raw);
 					while (matcher.find()) {
 						int line = 1 + (int) raw.codePoints().limit(matcher.start()).filter(c -> c == '\n').count();
-						lints.add(atLine(line, matcher.group(0), replacement));
+						lints.add(Lint.atLine(line, ruleId, lintDetail));
 					}
 					return lints;
 				}