Bring maven in-line with gradle.

Author: nedtwigg

plugin-maven/src/main/java/com/diffplug/spotless/maven/SpotlessApplyMojo.java

@@ -80,19 +80,24 @@ protected void process(String name, Iterable<File> files, Formatter formatter, U
 					counter.checkedButAlreadyClean();
 				}
 
-				// In apply mode, lints are usually warnings, but fatal errors should still fail the build
+				// In apply mode, any lints should fail the build (matching Gradle behavior)
 				if (hasUnsuppressedLints) {
-					// Check if any lint represents a fatal error (like parsing failures)
-					boolean hasFatalError = lintState.getLintsByStep(formatter).values().stream()
-							.flatMap(List::stream)
-							.anyMatch(lint -> lint.getShortCode().contains("Exception"));
-
-					if (hasFatalError) {
-						String stepName = lintState.getLintsByStep(formatter).keySet().iterator().next();
-						throw new MojoExecutionException(String.format("Unable to format file %s%nStep '%s' found problem in '%s':%n%s", file, stepName, file.getName(), lintState.asStringDetailed(file, formatter)));
-					} else {
-						getLog().warn(String.format("File %s has lint issues that cannot be auto-fixed:%n%s", file, lintState.asStringDetailed(file, formatter)));
+					int lintCount = lintState.getLintsByStep(formatter).values().stream()
+						.mapToInt(List::size)
+						.sum();
+					StringBuilder message = new StringBuilder();
+					message.append("There were ").append(lintCount).append(" lint error(s), they must be fixed or suppressed.");
+
+					// Build lint messages in Gradle format (using relative path, not just filename)
+					for (Map.Entry<String, List<com.diffplug.spotless.Lint>> stepEntry : lintState.getLintsByStep(formatter).entrySet()) {
+						String stepName = stepEntry.getKey();
+						for (com.diffplug.spotless.Lint lint : stepEntry.getValue()) {
+							message.append("\n  ").append(relativePath).append(":");
+							lint.addWarningMessageTo(message, stepName, true);
+						}
 					}
+					message.append("\n  Resolve these lints or suppress with `suppressLintsFor`");
+					throw new MojoExecutionException(message.toString());
 				}
 			} catch (IOException | RuntimeException e) {
 				throw new MojoExecutionException("Unable to format file " + file, e);

plugin-maven/src/main/java/com/diffplug/spotless/maven/SpotlessCheckMojo.java

@@ -117,20 +117,21 @@ protected void process(String name, Iterable<File> files, Formatter formatter, U
 			getLog().debug(String.format("Spotless.%s has no target files. Examine your `<includes>`: https://github.com/diffplug/spotless/tree/main/plugin-maven#quickstart", name));
 		}
 
-		if (!lintProblems.isEmpty()) {
-			// If we have lint problems, prioritize showing them with detailed messages
-			Map.Entry<File, LintState> firstLintProblem = lintProblems.get(0);
-			File file = firstLintProblem.getKey();
-			LintState lintState = firstLintProblem.getValue();
-			String stepName = lintState.getLintsByStep(formatter).keySet().iterator().next();
-			throw new MojoExecutionException(String.format("Unable to format file %s%nStep '%s' found problem in '%s':%n%s",
-					file, stepName, file.getName(), lintState.asStringDetailed(file, formatter)));
-		} else if (!problemFiles.isEmpty()) {
+		if (!problemFiles.isEmpty()) {
+			// Prioritize formatting violations first (matching Gradle behavior)
 			throw new MojoExecutionException(DiffMessageFormatter.builder()
 					.runToFix("Run 'mvn spotless:apply' to fix these violations.")
 					.formatter(baseDir.toPath(), formatter)
 					.problemFiles(problemFiles)
 					.getMessage());
+		} else if (!lintProblems.isEmpty()) {
+			// Show lints only if there are no formatting violations
+			Map.Entry<File, LintState> firstLintProblem = lintProblems.get(0);
+			File file = firstLintProblem.getKey();
+			LintState lintState = firstLintProblem.getValue();
+			String stepName = lintState.getLintsByStep(formatter).keySet().iterator().next();
+			throw new MojoExecutionException(String.format("Unable to format file %s%nStep '%s' found problem in '%s':%n%s",
+					file, stepName, file.getName(), lintState.asStringOneLine(file, formatter)));
 		}
 	}
 }