Skip to content

Commit 7e38e1d

Browse files
authored
Fix instancing new Character Nodes on Simple Highlight Portrait. (#2486)
This portrait is simple and allows for only one image, there is no underlying node hierarchy that may need to change. Therefore, we need to ensure to not recreate a new character node.
1 parent b9a9a20 commit 7e38e1d

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

addons/dialogic/Modules/HighlightPortrait/simple_highlight_portrait.gd

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@ func _ready() -> void:
1919
self.modulate = unhighlighted_color
2020

2121

22+
func _should_do_portrait_update(_character: DialogicCharacter, _portrait: String) -> bool:
23+
return true
24+
25+
2226
func _highlight() -> void:
2327
create_tween().tween_property(self, 'modulate', Color.WHITE, 0.15)
2428
_prev_z_index = DialogicUtil.autoload().Portraits.get_character_info(character).get('z_index', 0)

0 commit comments

Comments
 (0)