Fix setting undefined so it returns aan error and add tests.

Author: mrister

index.js

@@ -71,7 +71,12 @@ function redisStore(args) {
       }
 
       if (opts.parse) {
-        result = JSON.parse(result);
+
+        try {
+          result = JSON.parse(result);
+        } catch (e) {
+          return cb && cb(e);
+        }
       }
 
       if (cb) {
@@ -113,10 +118,16 @@ function redisStore(args) {
    * @param {Function} [cb] - A callback that returns a potential error, otherwise null
    */
   self.set = function(key, value, options, cb) {
+
     if (typeof options === 'function') {
       cb = options;
       options = {};
     }
+
+    if (value === undefined) {
+      return cb && cb(new Error('value cannot be undefined'));
+    }
+
     options = options || {};
 
     var ttl = (options.ttl || options.ttl === 0) ? options.ttl : redisOptions.ttl;
@@ -126,7 +137,6 @@ function redisStore(args) {
         return cb && cb(err);
       }
       var val = JSON.stringify(value);
-
       if (ttl) {
         conn.setex(key, ttl, val, handleResponse(conn, cb));
       } else {

spec/lib/redis-store-spec.js

@@ -50,13 +50,30 @@ describe('set', function() {
   });
 
   it('should not store an invalid value', function(done) {
-    redisCache.set('foo1', undefined, function(){
-      redisCache.get('foo1', function(err, value) {
+    redisCache.set('foo1', undefined, function(err){
+      try {
+        expect(err).notToBe(null);
+        expect(err.message).toEqual('value cannot be undefined');
+        done();
+      } catch (e) {
+        done(e);
+      }
+    });
+  });
+});
+
+it('should  store a null value without error', function(done) {
+  redisCache.set('foo2', null, function(err){
+    try {
+      expect(err).toBe(null);
+      redisCache.get('foo2', function(err, value) {
         expect(err).toBe(null);
         expect(value).toBe(null);
         done();
       });
-    });
+    } catch (e) {
+      done(e);
+    }
   });
 });