Only remove parens if we are sure it's an exception

Don't do it if the module scope is tainted - it may not be the builtin.

Only do it if the builtin is an exception in all supported python versions.
When we support targeting python versions this may be expanded.

Author: dflook

docs/source/transforms/remove_builtin_exception_brackets.rst

@@ -6,6 +6,8 @@ This transform removes parentheses when raising builtin exceptions with no argum
 The raise statement automatically instantiates exceptions with no arguments, so the parentheses are unnecessary.
 This transform does nothing on Python 2.
 
+If the exception is not a builtin exception, or has arguments, the parentheses are not removed.
+
 This transform is enabled by default. Disable by passing the ``remove_builtin_exception_brackets=False`` argument to the :func:`python_minifier.minify` function,
 or passing ``--no-remove-builtin-exception-brackets`` to the pyminify command.
 

src/python_minifier/__init__.py

@@ -153,7 +153,7 @@ def minify(
     bind_names(module)
     resolve_names(module)
 
-    if remove_builtin_exception_brackets:
+    if remove_builtin_exception_brackets and not module.tainted:
         remove_no_arg_exception_call(module)
 
     if module.tainted:

src/python_minifier/transforms/remove_exception_brackets.py

@@ -13,34 +13,26 @@
 
 from python_minifier.rename.binding import BuiltinBinding
 
-# This list may vary between python versions
+# These are always exceptions, in every version of python
 builtin_exceptions = [
-    'BaseException',
-    'BaseExceptionGroup',
-    'GeneratorExit',
-    'KeyboardInterrupt',
-    'SystemExit',
-    'Exception',
-    'ArithmeticError',
-    'FloatingPointError',
-    'OverflowError',
-    'ZeroDivisionError',
-    'AssertionError',
-    'AttributeError',
-    'BufferError',
-    'EOFError',
-    'ExceptionGroup',
-    'BaseExceptionGroup',
-    'ImportError',
-    'ModuleNotFoundError',
-    'LookupError',
-    'IndexError',
-    'KeyError',
-    'MemoryError',
-    'NameError',
-    'UnboundLocalError',
-    'OSError',
-    'BlockingIOError',
+    'SyntaxError', 'Exception', 'ValueError', 'BaseException', 'MemoryError', 'RuntimeError', 'DeprecationWarning', 'UnicodeEncodeError', 'KeyError', 'LookupError', 'TypeError', 'BufferError',
+    'ImportError', 'OSError', 'StopIteration', 'ArithmeticError', 'UserWarning', 'PendingDeprecationWarning', 'RuntimeWarning', 'IndentationError', 'UnicodeTranslateError', 'UnboundLocalError',
+    'AttributeError', 'EOFError', 'UnicodeWarning', 'BytesWarning', 'NameError', 'IndexError', 'TabError', 'SystemError', 'OverflowError', 'FutureWarning', 'SystemExit', 'Warning',
+    'FloatingPointError', 'ReferenceError', 'UnicodeError', 'AssertionError', 'SyntaxWarning', 'UnicodeDecodeError', 'GeneratorExit', 'ImportWarning', 'KeyboardInterrupt', 'ZeroDivisionError',
+    'NotImplementedError'
+]
+
+# These are exceptions only in python 2.7
+builtin_exceptions_2_7 = [
+    'IOError',
+    'StandardError',
+    'EnvironmentError',
+    'VMSError',
+    'WindowsError'
+]
+
+# These are exceptions in 3.3+
+builtin_exceptions_3_3 = [
     'ChildProcessError',
     'ConnectionError',
     'BrokenPipeError',
@@ -55,34 +47,30 @@
     'PermissionError',
     'ProcessLookupError',
     'TimeoutError',
-    'ReferenceError',
-    'RuntimeError',
-    'NotImplementedError',
-    'RecursionError',
-    'StopAsyncIteration',
-    'StopIteration',
-    'SyntaxError',
-    'IndentationError',
-    'TabError',
-    'SystemError',
-    'TypeError',
-    'ValueError',
-    'UnicodeError',
-    'UnicodeDecodeError',
-    'UnicodeEncodeError',
-    'UnicodeTranslateError',
-    'Warning',
-    'BytesWarning',
-    'DeprecationWarning',
-    'EncodingWarning',
-    'FutureWarning',
-    'ImportWarning',
-    'PendingDeprecationWarning',
     'ResourceWarning',
-    'RuntimeWarning',
-    'SyntaxWarning',
-    'UnicodeWarning',
-    'UserWarning'
+]
+
+# These are exceptions in 3.5+
+builtin_exceptions_3_5 = [
+    'StopAsyncIteration',
+    'RecursionError',
+]
+
+# These are exceptions in 3.6+
+builtin_exceptions_3_6 = [
+    'ModuleNotFoundError'
+]
+
+# These are exceptions in 3.10+
+builtin_exceptions_3_10 = [
+    'EncodingWarning'
+]
+
+# These are exceptions in 3.11+
+builtin_exceptions_3_11 = [
+    'BaseExceptionGroup',
+    'ExceptionGroup',
+    'BaseExceptionGroup',
 ]
 
 def _remove_empty_call(binding):
@@ -114,6 +102,7 @@ def _remove_empty_call(binding):
             raise_node.cause = name_node
         name_node.parent = raise_node
 
+
 def remove_no_arg_exception_call(module):
     assert isinstance(module, ast.Module)
 
@@ -125,4 +114,4 @@ def remove_no_arg_exception_call(module):
             # We can remove any calls to builtin exceptions
             _remove_empty_call(binding)
 
-    return module
+    return module