Properly defer continuations if the cont_req is inactive

devreal · devreal · commit 40ed2a0d87cd · 2024-05-03T18:58:19.000-04:00
Runnable continuations should be added to cont_complete_defer_list if
the continuation request is inactive, so that it can be enqueued
for execution once the request is enabled.

Signed-off-by: Joseph Schuchart &lt;schuchart@icl.utk.edu&gt;
diff --git a/ompi/mpiext/continue/c/continuation.c b/ompi/mpiext/continue/c/continuation.c
@@ -567,6 +567,8 @@ ompi_continue_enqueue_runnable(ompi_continuation_t *cont)
         }
         if (NULL != cont_req->cont_complete_list) {
             opal_list_append(cont_req->cont_complete_list, &cont->super.super);
+        } else if (cont_req->super.req_state == OMPI_REQUEST_INACTIVE) {
+            opal_list_append(&cont_req->cont_complete_defer_list, &cont->super.super);
         } else {
             /* someone started the request before we took the lock, go back and check again
              * this should be rare so we don't care about taking the lock again */

Original file line number	Diff line number	Diff line change
`@@ -567,6 +567,8 @@ ompi_continue_enqueue_runnable(ompi_continuation_t *cont)`
`567`	`567`	`}`
`568`	`568`	`if (NULL != cont_req->cont_complete_list) {`
`569`	`569`	`opal_list_append(cont_req->cont_complete_list, &cont->super.super);`
	`570`	`+ } else if (cont_req->super.req_state == OMPI_REQUEST_INACTIVE) {`
	`571`	`+ opal_list_append(&cont_req->cont_complete_defer_list, &cont->super.super);`
`570`	`572`	`} else {`
`571`	`573`	`/* someone started the request before we took the lock, go back and check again`
`572`	`574`	`* this should be rare so we don't care about taking the lock again */`