Remove an atomic op from wait_sync_update

devreal · devreal · commit 0d8ca5581f49 · 2022-07-13T09:33:50.000-04:00
Signed-off-by: Joseph Schuchart &lt;schuchart@icl.utk.edu&gt;
diff --git a/opal/mca/threads/wait_sync.h b/opal/mca/threads/wait_sync.h
@@ -144,9 +144,10 @@ OPAL_DECLSPEC void wait_sync_global_wakeup_mt(int status);
 static inline void wait_sync_update(ompi_wait_sync_t *sync, int updates, int status)
 {
     if (OPAL_LIKELY(OPAL_SUCCESS == status)) {
-        if (0 != (OPAL_THREAD_ADD_FETCH32(&sync->count, -updates))) {
+        if (1 != sync->count && 0 != (OPAL_THREAD_ADD_FETCH32(&sync->count, -updates))) {
             return;
         }
+        sync->count = 0;
     } else {
         /* this is an error path so just use the atomic */
         sync->status = status;

Original file line number	Diff line number	Diff line change
`@@ -144,9 +144,10 @@ OPAL_DECLSPEC void wait_sync_global_wakeup_mt(int status);`
`144`	`144`	`static inline void wait_sync_update(ompi_wait_sync_t *sync, int updates, int status)`
`145`	`145`	`{`
`146`	`146`	`if (OPAL_LIKELY(OPAL_SUCCESS == status)) {`
`147`		`- if (0 != (OPAL_THREAD_ADD_FETCH32(&sync->count, -updates))) {`
	`147`	`+ if (1 != sync->count && 0 != (OPAL_THREAD_ADD_FETCH32(&sync->count, -updates))) {`
`148`	`148`	`return;`
`149`	`149`	`}`
	`150`	`+ sync->count = 0;`
`150`	`151`	`} else {`
`151`	`152`	`/* this is an error path so just use the atomic */`
`152`	`153`	`sync->status = status;`