Skip to content

Commit 0d2a0d0

Browse files
committed
Always return 1 from request_completion_cb
No need to change the req_complete pointer as there are no sync objects on requests that have a continuation attached. Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>
1 parent ba28c17 commit 0d2a0d0

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

ompi/mpiext/continue/c/continuation.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -700,15 +700,14 @@ static void handle_failed_cont(ompi_continuation_t *cont, int status, bool have_
700700
static int request_completion_cb(ompi_request_t *request)
701701
{
702702
assert(NULL != request->req_complete_cb_data);
703-
int rc = 0;
704703
ompi_request_cont_data_t *req_cont_data;
705704

706705
/* atomically swap the pointer here to avoid race with ompi_continue_global_wakeup */
707706
req_cont_data = (ompi_request_cont_data_t *)OPAL_THREAD_SWAP_PTR(&request->req_complete_cb_data, 0x0);
708707

709708
if (NULL == req_cont_data) {
710709
/* the wakeup call took away our callback data */
711-
return rc;
710+
return 1;
712711
}
713712

714713
ompi_continuation_t *cont = req_cont_data->cont_obj;
@@ -754,7 +753,7 @@ static int request_completion_cb(ompi_request_t *request)
754753

755754
opal_free_list_return(&ompi_request_cont_data_freelist, &req_cont_data->super);
756755

757-
return rc;
756+
return 1;
758757
}
759758

760759
/* release all continuations, either by checking the requests for failure or just marking

0 commit comments

Comments
 (0)