Ajustes PR

Author: ccezar

solutions/devsprint-caio-santos-7/FinanceApp/Screens/ActivityDetails/ActivityListView.swift

@@ -8,15 +8,11 @@
 import UIKit
 
 class ActivityListView: UIView {
-    
-    private var activities: [Activity] = []
-    
     private lazy var tableView: UITableView = {
         let tableView = UITableView(frame: .zero)
         tableView.translatesAutoresizingMaskIntoConstraints = false
         tableView.register(ActivityCellView.self, forCellReuseIdentifier: ActivityCellView.reuseIdentifier)
-        tableView.register(UITableViewCell.self, forCellReuseIdentifier: UITableViewCell.reuseIdentifier)
-
+        tableView.separatorStyle = .none
         return tableView
     }()
 
@@ -31,16 +27,15 @@ class ActivityListView: UIView {
         fatalError("init(coder:) has not been implemented")
     }
 
-    func updateTableView(with configuration: HomeViewConfiguration) {
-        activities = configuration.homeData.activity
+    func reloadData() {
         tableView.reloadData()
     }
 
-    public func configTableViewProtocol(delegate: UITableViewDelegate, dataSource: UITableViewDataSource){
+    public func configTableViewProtocol(delegate: UITableViewDelegate,
+                                        dataSource: UITableViewDataSource) {
         self.tableView.delegate = delegate
         self.tableView.dataSource = dataSource
     }
-    
 }
 
 extension ActivityListView: ViewCodable {
@@ -60,5 +55,4 @@ extension ActivityListView: ViewCodable {
             tableView.bottomAnchor.constraint(equalTo: self.bottomAnchor)
         ])
     }
-    
 }

solutions/devsprint-caio-santos-7/FinanceApp/Screens/Home/HomeView.swift

@@ -42,12 +42,12 @@ final class HomeView: UIView {
     }
 
     func updateView(with configuration: HomeViewConfiguration) {
+        activities = configuration.homeData.activity
         accountSummaryView.updateValues(balance: configuration.homeData.balance,
                                         savings: configuration.homeData.savings,
                                         spending: configuration.homeData.spending)
-        activityListView.updateTableView(with: configuration)
+        activityListView.reloadData()
     }
-
 }
 
 private extension HomeView {
@@ -79,8 +79,8 @@ private extension HomeView {
 
 extension HomeView: UITableViewDataSource, UITableViewDelegate {
 
-public func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
-        return activities.count
+    public func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
+        activities.count
     }
 
     public func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
@@ -95,5 +95,8 @@ public func tableView(_ tableView: UITableView, numberOfRowsInSection section: I
     func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {
         delegate?.didSelectActivity()
     }
+    
+    func tableView(_ tableView: UITableView, titleForHeaderInSection section: Int) -> String? {
+        "Activity"
+    }
 }
-

solutions/devsprint-caio-santos-7/FinanceAppTests/Screens/ActivityDetails/ActivityListViewTests.swift

@@ -0,0 +1,56 @@
+//
+//  ActivityListViewTests.swift
+//  FinanceAppTests
+//
+//  Created by Caio Santos on 18/10/22.
+//
+
+import UIKit
+import SnapshotTesting
+import XCTest
+
+@testable import FinanceApp
+
+final class ActivityListViewTests: XCTestCase {
+    
+    private var sut: ActivityListView?
+    private var activities: [Activity] = [
+        .init(name: "Test", price: 99, time: "Test"),
+        .init(name: "Test", price: 99, time: "Test"),
+        .init(name: "Test", price: 99, time: "Test"),
+        .init(name: "Test", price: 99, time: "Test"),
+    ]
+
+    override func setUp() {
+//        SnapshotTesting.isRecording = true
+        sut = ActivityListView()
+    }
+    
+    func testRenderView() throws {
+        let unwrappedSut = try XCTUnwrap(sut)
+        unwrappedSut.configTableViewProtocol(delegate: self, dataSource: self)
+        assertSnapshot(matching: unwrappedSut, as: .image(size: .init(width: UIScreen.main.bounds.width,
+                                                                      height: 527)))
+    }
+}
+
+extension ActivityListViewTests: UITableViewDataSource, UITableViewDelegate {
+    
+    public func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
+        return activities.count
+    }
+
+    public func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
+        guard let cell: ActivityCellView = .createCell(for: tableView, at: indexPath),
+              indexPath.row < activities.count else {
+            return .init()
+        }
+        cell.updateValues(activity: activities[indexPath.row])
+        return cell
+    }
+    
+    func tableView(_ tableView: UITableView, titleForHeaderInSection section: Int) -> String? {
+        "Activity"
+    }
+}
+