Working on adding IDs that get truncated before appending attributes

Author: snemetz

main.tf

@@ -20,26 +20,36 @@ module "namespace-org" {
 }
 
 locals {
-  attr      = "${lower(format("%s", join(var.delimiter, compact(var.attributes))))}"
-  env       = "${lower(format("%s", var.environment))}"
-  name_low  = "${lower(format("%s", var.name))}"
-  org       = "${lower(format("%s", var.organization))}"
-  id_env    = "${module.namespace-env.value ? join(var.delimiter, list(local.env, local.name_low)) : local.name_low}"
-  id_org    = "${module.namespace-org.value ? join(var.delimiter, list(local.org, local.id_env)) : local.id_env}"
-  id        = "${length(local.attr) > 0 ? join(var.delimiter, list(local.id_org, local.attr)) : local.id_org}"
-  id_20     = "${substr(replace(local.id,"_","-"),0,19 <= length(local.id) ? 19 : length(local.id))}"
-  id_32     = "${substr(replace(local.id,"_","-"),0,31 <= length(local.id) ? 31 : length(local.id))}"
-  /*
-  id_attr_20= "${19 <= length(local.id) ?
-    join(var.delimiter, substr(local.id_org,0,
-    (19 <= length(local.id_org) ? 19 : length(local.id_org))
-     - length(local.attr)
-    ), local.attr)
+  attr        = "${lower(format("%s", join(var.delimiter, compact(var.attributes))))}"
+  env         = "${lower(format("%s", var.environment))}"
+  name_low    = "${lower(format("%s", var.name))}"
+  org         = "${lower(format("%s", var.organization))}"
+  id_env      = "${module.namespace-env.value ? join(var.delimiter, list(local.env, local.name_low)) : local.name_low}"
+  id_org      = "${module.namespace-org.value ? join(var.delimiter, list(local.org, local.id_env)) : local.id_env}"
+  id          = "${length(local.attr) > 0 ? join(var.delimiter, list(local.id_org, local.attr)) : local.id_org}"
+  id_20       = "${substr(replace(local.id,"_","-"),0,19 <= length(local.id) ? 19 : length(local.id))}"
+  id_32       = "${substr(replace(local.id,"_","-"),0,31 <= length(local.id) ? 31 : length(local.id))}"
+  # Fix calc
+  org_attr_20 = "${(19 <= length(local.id_org) ? 19 - length(local.attr) : length(local.id_org) - length(local.attr))}"
+  id_attr_20  = "${19 <= length(local.id) ?
+    join(var.delimiter,
+      list(
+        substr(local.id_org,0,
+          local.org_attr_20 >= 0 ? local.org_attr_20 : 0)
+      ),
+      list(local.attr)
+    )
+    : local.id}"
+  org_attr_32 = "${(31 <= length(local.id_org) ? 31 - length(local.attr) : length(local.id_org) - length(local.attr))}"
+  id_attr_32  = "${31 <= length(local.id) ?
+    join(var.delimiter,
+      list(
+        substr(local.id_org,0,
+          local.org_attr_32 >= 0 ? local.org_attr_32 : 0)
+      ),
+      list(local.attr)
+    )
     : local.id}"
-  #id_attr_32= "${19 <= length(local.id) ? local.id : }"
-  #id_attr_20 trunc name-org then join attr - total max still 20
-  #id_attr_32 if id >32 trunc name-org to 31 - attr, then join attr
-  */
 
   #tags_asg list of maps
   #map("key", "interpolation1", "value", "value3", "propagate_at_launch", true),

outputs.tf

@@ -19,6 +19,14 @@ output "id_32" {
   description = "ID truncated to 32 characters"
   value       = "${local.id_32}"
 }
+output "id_attr_20" {
+  description = "ID truncated to 20 characters"
+  value       = "${local.id_attr_20}"
+}
+output "id_attr_32" {
+  description = "ID truncated to 32 characters"
+  value       = "${local.id_attr_32}"
+}
 output "id_env" {
   description = "If env namespace enabled <env>-<name> else <name>"
   value       = "${local.id_env}"
@@ -39,3 +47,10 @@ output "tags" {
   description = "Tags map merged with standard tags"
   value       = "${local.tags}"
 }
+//debugging
+output "org_attr_20" {
+  value = "${local.org_attr_20}"
+}
+output "org_attr_32" {
+  value = "${local.org_attr_32}"
+}

test/main.tf

@@ -6,6 +6,7 @@ module "labels" {
   organization  = "CorpXyZ"
   namespace-org = true
   #attributes    = ["role", "policy", "use", ""]
+  attributes    = ["8080"]
   tags          = "${map("Key", "Value")}"
 }
 module "labels-tags" {

test/outputs.tf

@@ -22,6 +22,14 @@ output "id_32" {
   description = "Name truncated to 32 characters"
   value       = "${module.labels.id_32}"
 }
+output "id_attr_20" {
+  description = "Name truncated to 20 characters"
+  value       = "${module.labels.id_attr_20}"
+}
+output "id_attr_32" {
+  description = "Name truncated to 32 characters"
+  value       = "${module.labels.id_attr_32}"
+}
 output "id_env" {
   description = "If env namespace enabled <env>-<name> else <name>"
   value       = "${module.labels.id_env}"
@@ -38,3 +46,9 @@ output "tags" {
   description = "Tags"
   value       = "${module.labels.tags}"
 }
+output "org_attr_20" {
+  value = "${module.labels.org_attr_20}"
+}
+output "org_attr_32" {
+  value = "${module.labels.org_attr_32}"
+}