cleanup and add notes fr work to do

Author: snemetz

main.tf

@@ -1,8 +1,13 @@
 #
 # Terraform module to provide consistent naming
 #
+# TODO:
+#   Add attributes to name if not empty
+#   return name as lowercase
+#   return id and id_20, id_32 for combined name
 
 resource "null_resource" "pre1" {
+  count     = "${var.enabled ? 1 : 0}"
   triggers  = {
     attributes    = "${lower(format("%s", join(var.delimiter, compact(var.attributes))))}"
     environment   = "${lower(format("%s", var.environment))}"
@@ -11,11 +16,13 @@ resource "null_resource" "pre1" {
   }
 }
 resource "null_resource" "pre2" {
+  count     = "${var.enabled ? 1 : 0}"
   triggers  = {
     name_env      = "${var.namespace-env ? join(var.delimiter, list(null_resource.pre1.triggers.environment, null_resource.pre1.triggers.name)) : null_resource.pre1.triggers.name}"
   }
 }
 resource "null_resource" "pre3" {
+  count     = "${var.enabled ? 1 : 0}"
   triggers  = {
     name_org      = "${var.namespace-org ? join(var.delimiter, list(null_resource.pre1.triggers.organization, null_resource.pre2.triggers.name_env)) : null_resource.pre2.triggers.name_env}"
   }
@@ -37,20 +44,3 @@ resource "null_resource" "this" {
       map("Terraform", "true") )}"*/
   }
 }
-/*
-resource "null_resource" "default" {
-  count = "${var.enabled == "true" ? 1 : 0}"
-
-  triggers = {
-    id         = "${lower(join(var.delimiter, compact(concat(list(var.namespace, var.stage, var.name), var.attributes))))}"
-    name       = "${lower(format("%v", var.name))}"
-    namespace  = "${lower(format("%v", var.namespace))}"
-    stage      = "${lower(format("%v", var.stage))}"
-    attributes = "${lower(format("%v", join(var.delimiter, compact(var.attributes))))}"
-  }
-
-  lifecycle {
-    create_before_destroy = true
-  }
-}
-*/