Skip to content

Commit 7bbfb0f

Browse files
Fix up make e2e test for sidecar
1 parent 696ca64 commit 7bbfb0f

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

Makefile

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,6 @@ build-manager: generate fmt vet ## Build manager binary.
124124
run: manifests generate fmt vet ## Run a controller from your host.
125125
go run ./cmd/manager/main.go
126126

127-
128-
129127
docker-build-agent: ## Build docker image with the manager.
130128
docker build -t ${AGENT_IMAGE} . -f ./images/agent/Dockerfile
131129

@@ -144,9 +142,8 @@ docker-load-kind:
144142
kind load docker-image ${AGENT_IMAGE} ${SIDECAR_IMAGE} ${MANAGER_IMAGE}
145143

146144
run-e2e:
147-
AGENT_IMAGE=${AGENT_IMAGE} $(MAKE) update-agent-image
145+
SIDECAR_IMAGE=${SIDECAR_IMAGE} AGENT_IMAGE=${AGENT_IMAGE} $(MAKE) update-agent-and-sidecar-image
148146
MANAGER_IMAGE=${MANAGER_IMAGE} $(MAKE) update-manager-image
149-
SIDECAR_IMAGE=${SIDECAR_IMAGE} $(MAKE) update-sidecar-image
150147
$(KUSTOMIZE) build config/default > release_it.yaml
151148
git checkout ./config/default/manager_auth_proxy_patch.yaml
152149
git checkout ./config/manager/kustomization.yaml
@@ -164,9 +161,9 @@ uninstall: manifests kustomize ## Uninstall CRDs from the K8s cluster specified
164161
$(KUSTOMIZE) build config/crd | kubectl delete -f -
165162

166163

167-
update-agent-image: kustomize
164+
update-agent-and-sidecar-image: kustomize
168165
## TODO: Simplify later
169-
AGENT_IMAGE=$(AGENT_IMAGE) envsubst < ./config/default/manager_auth_proxy_patch.yaml.template > ./config/default/manager_auth_proxy_patch.yaml
166+
SIDECAR_IMAGE=$(SIDECAR_IMAGE) AGENT_IMAGE=$(AGENT_IMAGE) envsubst < ./config/default/manager_auth_proxy_patch.yaml.template > ./config/default/manager_auth_proxy_patch.yaml
170167

171168
update-manager-image: kustomize
172169
$(info MANAGER_IMAGE: "$(MANAGER_IMAGE)")

0 commit comments

Comments
 (0)