Merge pull request #5 from devmakerlab/(feat)tests

meinder-a · web-flow · commit eced07f834ca · 2021-07-25T17:30:07.000+02:00
Add of tests
diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,4 @@
 vendor/
+tests/reports/
 composer.lock
 .php-cs-fixer.cache
diff --git a/phpunit.xml b/phpunit.xml
@@ -17,6 +17,9 @@
         <include>
             <directory suffix=".php">src/</directory>
         </include>
+        <report>
+            <html outputDirectory="tests/reports/report" lowUpperBound="35" highLowerBound="70"/>
+        </report>
     </coverage>
     <testsuites>
         <testsuite name="Unit">
@@ -26,6 +29,9 @@
             <directory suffix="Test.php">./tests/Feature</directory>
         </testsuite>
     </testsuites>
+    <logging>
+        <testdoxText outputFile="tests/reports/testdox.txt"/>
+    </logging>
     <php>
         <env name="DB_CONNECTION" value="testing"/>
         <env name="APP_KEY" value="base64:bWVpbmRlci1hL2ZpbHRlcnMKc3RhciBpdCE="/>
diff --git a/tests/Feature/PeopleRepositoryTest.php b/tests/Feature/PeopleRepositoryTest.php
@@ -5,38 +5,35 @@
 use Tests\TestCase;
 use Tests\Example\Filters\OldPeopleFilter;
 use Tests\Example\Entities\PeopleEntityList;
+use Illuminate\Foundation\Testing\DatabaseTransactions;
 
-class AbstractFilterableRepositoryTest extends TestCase
+class PeopleRepositoryTest extends TestCase
 {
-    use \Illuminate\Foundation\Testing\DatabaseTransactions;
-
-    protected function setUp(): void
-    {
-        parent::setUp();
-    }
+    use DatabaseTransactions;
 
     /** */
     public function testCan_get_old_people(): void
     {
         $peopleRepository = $this->instantiatePeopleRepository();
 
         $this->createPeople([
-                [
-                    'firstname' => 'Snoop',
-                    'lastname' => 'Dogg',
-                    'gender' => 'male',
-                    'age' => 49,
-                ],
-                [
-                    'firstname' => 'Danielle',
-                    'lastname' => 'Studio',
-                    'gender' => 'female',
-                    'age' => 67,
-                ],
-            ]);
+            [
+                'firstname' => 'Snoop',
+                'lastname' => 'Dogg',
+                'gender' => 'male',
+                'age' => 49,
+            ],
+            [
+                'firstname' => 'Danielle',
+                'lastname' => 'Studio',
+                'gender' => 'female',
+                'age' => 67,
+            ],
+        ]);
 
         $people = $peopleRepository
             ->addFilter(OldPeopleFilter::class)
+            ->limit(1)
             ->get(['age' => 60]);
 
         $this->assertInstanceOf(PeopleEntityList::class, $people);
diff --git a/tests/Unit/AbstractFilterTest.php b/tests/Unit/AbstractFilterTest.php
@@ -0,0 +1,33 @@
+<?php
+
+declare(strict_types=1);
+
+use Tests\TestCase;
+use DevMakerLab\LaravelFilters\AbstractFilter;
+use DevMakerLab\LaravelFilters\NoApplyFilterRuleException;
+
+class AbstractFilterTest extends TestCase
+{
+    public function testExceptionThrownWhenNoApplyFunctionOverride(): void
+    {
+        $filter = new class extends AbstractFilter {
+        };
+
+        $this->expectException(NoApplyFilterRuleException::class);
+
+        $filter->apply($this->app['db']->query());
+    }
+
+    public function testCanFeedPropertiesByConstruct(): void
+    {
+        $filter = new class extends AbstractFilter {
+            public string $foo;
+        };
+
+        $filterInstance = new $filter(['foo' => 'hey', 'bar' => 'nope']);
+
+        $this->assertSame('hey', $filterInstance->foo);
+        $this->expectException(Exception::class);
+        $this->assertNull($filterInstance->bar);
+    }
+}
diff --git a/tests/Unit/AbstractFilterableRepositoryTest.php b/tests/Unit/AbstractFilterableRepositoryTest.php
@@ -0,0 +1,102 @@
+<?php
+
+declare(strict_types=1);
+
+use Tests\TestCase;
+use DevMakerLab\LaravelFilters\AbstractFilter;
+use DevMakerLab\LaravelFilters\FilterClassNotFound;
+use DevMakerLab\LaravelFilters\IncorrectFilterException;
+use DevMakerLab\LaravelFilters\AbstractFilterableRepository;
+
+class AbstractFilterableRepositoryTest extends TestCase
+{
+    public function testExceptionThrownWhenAddingNonExistingFilter(): void
+    {
+        $abstractRepository = new class extends AbstractFilterableRepository {
+        };
+
+        $this->expectException(FilterClassNotFound::class);
+        $abstractRepository->addFilter(FooFilter::class);
+    }
+
+    public function testExceptionThrownWhenAddingFilterWhichIsNotExtendingAbstractFilter(): void
+    {
+        $abstractRepository = new class extends AbstractFilterableRepository {
+        };
+        $filter = new class {
+        };
+
+        $this->expectException(IncorrectFilterException::class);
+        $abstractRepository->addFilter(get_class($filter));
+    }
+
+    public function testCanAddFilter(): void
+    {
+        $abstractRepository = new class extends AbstractFilterableRepository {
+            public function getFilters(): array
+            {
+                return $this->filters;
+            }
+        };
+
+        $filter = new class extends AbstractFilter {
+        };
+
+        $abstractRepository->addFilter(get_class($filter));
+
+        $this->assertCount(1, $abstractRepository->getFilters());
+        $this->assertSame(get_class($filter), $abstractRepository->getFilters()[0]);
+    }
+
+    public function testCanResetFilters(): void
+    {
+        $abstractRepository = new class extends AbstractFilterableRepository {
+            public function getFilters(): array
+            {
+                return $this->filters;
+            }
+        };
+
+        $filter = new class extends AbstractFilter {
+        };
+
+        $abstractRepository->addFilter(get_class($filter));
+        $this->assertCount(1, $abstractRepository->getFilters());
+
+        $abstractRepository->resetFilters();
+        $this->assertCount(0, $abstractRepository->getFilters());
+    }
+
+    public function testCanSpecifyLimit(): void
+    {
+        $abstractRepository = new class extends AbstractFilterableRepository {
+            public function getLimit(): ?int
+            {
+                return $this->limit;
+            }
+        };
+
+        $this->assertNull($abstractRepository->getLimit());
+
+        $abstractRepository->limit(10);
+        $this->assertSame(10, $abstractRepository->getLimit());
+    }
+
+    public function testCanResetLimit(): void
+    {
+        $abstractRepository = new class extends AbstractFilterableRepository {
+            public function getLimit(): ?int
+            {
+                return $this->limit;
+            }
+        };
+
+        $this->assertNull($abstractRepository->getLimit());
+
+        $abstractRepository->limit(10);
+        $this->assertSame(10, $abstractRepository->getLimit());
+
+        $abstractRepository->resetLimit();
+        $this->assertNull($abstractRepository->getLimit());
+    }
+}
