From f52a704c1b0f17fcac1f50ec70bc71b3ae485ec0 Mon Sep 17 00:00:00 2001 From: malkoe Date: Thu, 22 Dec 2022 08:59:08 +0800 Subject: [PATCH 1/4] First fixing attempt. --- src/index.html | 16 +++++++--------- src/script.js | 14 +++++++++----- src/styles.css | 5 ++--- 3 files changed, 18 insertions(+), 17 deletions(-) diff --git a/src/index.html b/src/index.html index 04bd19e..fdadd32 100644 --- a/src/index.html +++ b/src/index.html @@ -11,27 +11,25 @@ - diff --git a/src/script.js b/src/script.js index 529f585..d8e25b9 100644 --- a/src/script.js +++ b/src/script.js @@ -25,11 +25,15 @@ addEventListener("submit", (event) => { let email = document.getElementById("email").value; - // TODO: Show Correct Status Messages on Signup Form - // 1. successful signup - // 2. empty email - // 3. taken email - // 4. repeat email + for (let i = 0; i < usersTable.length; i++) { + if (email === "") { + return renderEmailEmptyError() + } else if (email === usersTable[i].username) { + return renderEmailTakenError() + } + } + usersTable.push({username: email}) + return renderSuccess() }); let toggleNav = () => { diff --git a/src/styles.css b/src/styles.css index 2cbb72e..c2a6d46 100644 --- a/src/styles.css +++ b/src/styles.css @@ -669,7 +669,7 @@ form > span { #jumbo-image { max-height: 20rem; - /* TODO: Invert banner colors using CSS */ + filter: invert(1); } @media (max-width: 600px) { @@ -876,8 +876,7 @@ form > span { #challenge-grid { display: grid; - /* TODO: Fix Issue, Tiles Need to be 2x2 Grid. Change only grid-template-columns */ - grid-template-columns: none; + grid-template-columns: 1fr 1fr; grid-auto-rows: 10rem; gap: 1rem; padding-top: 2rem; From c59e914c1f60ac19c1d319121e7fe5ec6fdc8d12 Mon Sep 17 00:00:00 2001 From: malkoe Date: Thu, 22 Dec 2022 10:03:36 +0800 Subject: [PATCH 2/4] Second attempt --- src/index.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/index.html b/src/index.html index fdadd32..1bd2fd4 100644 --- a/src/index.html +++ b/src/index.html @@ -14,14 +14,14 @@ From b8720ec95812f0f47bf35fb6e062e7d1dd44e5d5 Mon Sep 17 00:00:00 2001 From: malkoe Date: Thu, 22 Dec 2022 10:13:46 +0800 Subject: [PATCH 4/4] Fourth attempt --- src/index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/index.html b/src/index.html index b4d7ec1..e375654 100644 --- a/src/index.html +++ b/src/index.html @@ -21,7 +21,7 @@ title="Toggle Navigation Menu" > - + Browse Challenges Sign Up