replace map function with forEach where map

function is not needed

Author: dev-javascript

example/complete-example/src/components/tabs/tabs.js

@@ -117,7 +117,7 @@ export default function (props) {
         ref.current.log('[beforeSelect]');
         return true;
       });
-      _instance.getData().openTabIDs.map((id) => {
+      _instance.getData().openTabIDs.forEach((id) => {
         _instance.setTab(id, {closable: false});
       });
       _instance

src/index.test.js

@@ -41,7 +41,7 @@ beforeEach(() => {
     const _options = Object.assign({}, op, options);
     if (_options.tabs) {
       const _tabs = [];
-      _options.tabs.map((tab) => {
+      _options.tabs.forEach((tab) => {
         _tabs.push({...tab});
       });
       _options.tabs = _tabs;

src/utils/api/api.factory.js

@@ -63,7 +63,7 @@ const _apiProps = {
   },
   _subscribeCallbacksOptions: function () {
     const op = this.optionsManager.options;
-    Object.keys(this._publishers).map((eventName) => {
+    Object.keys(this._publishers).forEach((eventName) => {
       if (eventName[0] !== '_')
         this.on(eventName, function () {
           op[eventName].apply(this, arguments);

src/utils/api/api.test.js

@@ -25,7 +25,7 @@ describe('user api : ', () => {
     ];
     expect(Object.keys(obj.userProxy).length === userApi.length).toBe(true);
     let _isEqual = true;
-    userApi.map((value) => {
+    userApi.forEach((value) => {
       if (!Object.prototype.hasOwnProperty.call(obj.userProxy, value)) {
         _isEqual = false;
       }

src/utils/api/optionManager/optionManager.factory.js

@@ -62,7 +62,7 @@ Object.assign(OptionManager.prototype, {
     // set this.initialTabs and this.initialState
     const {selectedTabID, tabs} = this.options,
       openTabIDs = [];
-    tabs.map((tab) => {
+    tabs.forEach((tab) => {
       const newTab = this.validateTabData(tab);
       this.initialTabs.push(newTab);
       openTabIDs.push(newTab.id);

src/utils/api/pub_sub.js

@@ -49,7 +49,7 @@ helper.setNoneEnumProps(Pub_Sub.prototype, {
     context = context || null;
     const result = [];
     const _subscribers = [...this._publishers[publisherName]];
-    _subscribers.map((subscriber) => {
+    _subscribers.forEach((subscriber) => {
       result.push(subscriber.apply(context, generateParamsCallback()));
     });
     return result;

src/utils/api/tabs.js

@@ -1,7 +1,7 @@
 function Tabs({initialTabs} = {initialTabs: []}) {
   this._data = [];
   if (initialTabs && initialTabs.constructor === Array && initialTabs.length) {
-    initialTabs.map((tab) => {
+    initialTabs.forEach((tab) => {
       this._addTab(tab);
     });
   }

src/utils/helper.js

@@ -12,9 +12,9 @@ const helper = {
   },
   assingAll: function (targetObj, ...sourcObjs) {
     // copy all enumerable and not enumerable properties into the target
-    sourcObjs.map((sourcObj) => {
+    sourcObjs.forEach((sourcObj) => {
       const enum_only = Object.keys(sourcObj);
-      Object.getOwnPropertyNames(sourcObj).map((prop) => {
+      Object.getOwnPropertyNames(sourcObj).forEach((prop) => {
         if (enum_only.indexOf(prop) >= 0) targetObj[prop] = sourcObj[prop];
         else
           Object.defineProperty(targetObj, prop, {
@@ -27,7 +27,7 @@ const helper = {
   },
   setNoneEnumProps: function (obj, props) {
     const noneEnum = {};
-    Object.keys(props).map((prop) => {
+    Object.keys(props).forEach((prop) => {
       noneEnum[prop] = {
         writable: true,
         value: props[prop],
@@ -38,7 +38,7 @@ const helper = {
   getArraysDiff: function (arr1, arr2) {
     const arr1Copy = [...arr1],
       arr2Copy = [...arr2];
-    arr1.map((item) => {
+    arr1.forEach((item) => {
       if (arr2.indexOf(item) >= 0) {
         arr1Copy.splice(arr1Copy.indexOf(item), 1);
         arr2Copy.splice(arr2Copy.indexOf(item), 1);