rename perviousData property to previousData

Author: dev-javascript

README.md

@@ -458,12 +458,12 @@ instance.on('onInit', () => {});
 
 ```js
 const [TabList, PanelList, ready] = useDynTabs({
-  onChange: function ({currentData, perviousData, closedTabIDs, openedTabIDs}) {
+  onChange: function ({currentData, previousData, closedTabIDs, openedTabIDs}) {
     // you can use 'this' here which refers to the instance
   },
 });
 // or
-instance.setOption('onChange', ({currentData, perviousData, closedTabIDs, openedTabIDs}) => {}).refresh();
+instance.setOption('onChange', ({currentData, previousData, closedTabIDs, openedTabIDs}) => {}).refresh();
 ```
 
 ### beforeSelect
@@ -1025,6 +1025,8 @@ const open_tab_3 = function () {
 
 - First parameter of onSelect function is an object and has perviousSelectedTabId property which is deprecated. you should use previousSelectedTabId property instead of perviousSelectedTabId property.
 
+- First parameter of onChange function is an object and has perviousData property which is deprecated. you should use previousData property instead of perviousData property.
+
 ## Test
 
 ```js

example/basic/com/basic/service/index.js

@@ -28,7 +28,7 @@ export default {
       onInit: function () {
         const context = this;
       },
-      onChange: function ({currentData, perviousData}) {
+      onChange: function ({currentData, previousData}) {
         const context = this;
       },
       beforeSelect: function (e, id) {

src/index.test.js

@@ -191,11 +191,6 @@ describe('select method : ', () => {
     expect(op.onInit.mock.calls.length === 2).toBe(true);
     expect(op.onChange.mock.calls.length === 1).toBe(true);
     expect(op.onSelect.mock.calls.length === 1).toBe(true);
-    expect(op.onSelect.mock.calls[0][0]).toEqual({
-      currentSelectedTabId: '2',
-      perviousSelectedTabId: '1',
-      previousSelectedTabId: '1',
-    });
     expect(onSelect.mock.calls[0][0]).toEqual({
       currentSelectedTabId: '2',
       perviousSelectedTabId: '1',
@@ -391,21 +386,45 @@ describe('ready function : ', () => {
     expect(op.onChange.mock.calls.length).toBe(0);
   });
 });
-describe('onLoad, onInit and onChange events : ', () => {
+describe('initial events : ', () => {
   test('onLoad and then onInit are called initially but onChange is not called', () => {
     renderApp();
     expect(op.onLoad.mock.calls.length).toBe(1);
     expect(op.onInit.mock.calls.length).toBe(1);
     expect(op.onChange.mock.calls.length).toBe(0);
     expect(op.onLoad).toHaveBeenCalledBefore(op.onInit);
   });
-  test('onChange is called with {currentData,perviousData} object as a parameter', () => {
+});
+describe('onChange callback : ', () => {
+  test(`onChange is called with {currentData,previousData,perviousData,openedTabIDs,closedTabIDs} 
+    object as a parameter`, () => {
     renderApp();
     act(() => {
       instance.select('2');
     });
     expect(op.onChange.mock.calls.length).toBe(1);
+    expect(op.onChange.mock.calls[0][0]).toEqual({
+      currentData: {selectedTabID: '2', openTabIDs: ['1', '2']},
+      previousData: {selectedTabID: '1', openTabIDs: ['1', '2']},
+      perviousData: {selectedTabID: '1', openTabIDs: ['1', '2']},
+      openedTabIDs: [],
+      closedTabIDs: [],
+    });
     expect(op.onChange.mock.calls[0][0].currentData).toEqual(instance.getCopyData());
-    expect(op.onChange.mock.calls[0][0].perviousData).toEqual(instance.getCopyPerviousData());
+    expect(op.onChange.mock.calls[0][0].previousData).toEqual(instance.getCopyPerviousData());
+  });
+});
+describe('onSelect callback : ', () => {
+  test('onSelect is called with {currentSelectedTabId,previousSelectedTabId,perviousSelectedTabId} object as a parameter', () => {
+    renderApp();
+    act(() => {
+      instance.select('2');
+    });
+    expect(op.onSelect.mock.calls.length).toBe(1);
+    expect(op.onSelect.mock.calls[0][0]).toEqual({
+      currentSelectedTabId: '2',
+      perviousSelectedTabId: '1',
+      previousSelectedTabId: '1',
+    });
   });
 });

src/utils/api/api.factory.js

@@ -51,13 +51,13 @@ const _apiProps = {
     return this;
   },
   _subscribeSelectedTabsHistory: function () {
-    this.on('onChange', ({currentData, perviousData, closedTabIDs}) => {
+    this.on('onChange', ({currentData, previousData, closedTabIDs}) => {
       for (let i = 0, l = closedTabIDs.length; i < l; i++) {
         this.activedTabsHistory.remove(closedTabIDs[i]);
       }
-      const isSwitched = perviousData.selectedTabID !== currentData.selectedTabID;
-      if (isSwitched && this.isOpen(perviousData.selectedTabID) && !this.isSelected(perviousData.selectedTabID))
-        this.activedTabsHistory.add(perviousData.selectedTabID);
+      const isSwitched = previousData.selectedTabID !== currentData.selectedTabID;
+      if (isSwitched && this.isOpen(previousData.selectedTabID) && !this.isSelected(previousData.selectedTabID))
+        this.activedTabsHistory.add(previousData.selectedTabID);
     });
     return this;
   },
@@ -171,6 +171,7 @@ Helper.setNoneEnumProps(_apiProps, {
     if (isSwitched || openedTabIDs.length || closedTabIDs.length) {
       this.trigger('onChange', this.userProxy, {
         currentData: {...newState},
+        previousData: {...oldState},
         perviousData: {...oldState},
         closedTabIDs,
         openedTabIDs,

src/utils/api/api.factory.test.js

@@ -323,7 +323,7 @@ describe('context of callback options should be userProxy object : ', () => {
     };
     const obj = new apiConstructor(getDeps, {options});
     expect(options.onChange.mock.calls.length === 0).toBe(true);
-    obj.trigger('onChange', obj.userProxy, {currentData: {}, perviousData: {}, closedTabIDs: [], openTabIDs: []});
+    obj.trigger('onChange', obj.userProxy, {currentData: {}, previousData: {}, closedTabIDs: [], openTabIDs: []});
     expect(options.onChange.mock.calls.length === 1).toBe(true);
   });
 });
@@ -474,9 +474,9 @@ describe('Api.prototype._subscribeSelectedTabsHistory : ', () => {
   test('subscribed function should call activedTabsHistory.remove per each closed tabID when onChange event is triggered', () => {
     obj.activedTabsHistory.remove = jest.fn(() => {});
     const currentData = {selectedTabID: '2', openTabIDs: ['2']};
-    const perviousData = {selectedTabID: '2', openTabIDs: ['2']};
+    const previousData = {selectedTabID: '2', openTabIDs: ['2']};
     const closedTabIDs = ['1', '3'];
-    obj.trigger('onChange', obj.userProxy, {currentData, perviousData, closedTabIDs, openTabIDs: []});
+    obj.trigger('onChange', obj.userProxy, {currentData, previousData, closedTabIDs, openTabIDs: []});
     expect(obj.activedTabsHistory.remove.mock.calls.length).toBe(2);
     expect(obj.activedTabsHistory.remove.mock.calls[0][0]).toBe('1');
     expect(obj.activedTabsHistory.remove.mock.calls[1][0]).toBe('3');
@@ -493,8 +493,8 @@ describe('Api.prototype._subscribeSelectedTabsHistory : ', () => {
       return false;
     });
     const currentData = {selectedTabID: '2', openTabIDs: ['1', '2']};
-    const perviousData = {selectedTabID: '1', openTabIDs: ['1', '2']};
-    obj.trigger('onChange', obj.userProxy, {currentData, perviousData, closedTabIDs: [], openTabIDs: []});
+    const previousData = {selectedTabID: '1', openTabIDs: ['1', '2']};
+    obj.trigger('onChange', obj.userProxy, {currentData, previousData, closedTabIDs: [], openTabIDs: []});
     expect(obj.activedTabsHistory.add.mock.calls.length).toBe(1);
     expect(obj.activedTabsHistory.add.mock.calls[0][0]).toBe('1');
   });