Skip to content

Commit c89523d

Browse files
committed
Added unit tests to PR #105
and upated `changes.xml`
1 parent bd33a13 commit c89523d

File tree

3 files changed

+17
-4
lines changed

3 files changed

+17
-4
lines changed

src/changes/changes.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,17 @@
1616
<action dev="derjust" type="add" date="2017-12-17" >
1717
Update Mockito and resolve dependency clashes
1818
</action>
19+
<action dev="Gaurav Rawat" type="fix" issue="91">>
20+
Fixed false assertion introduced implementing #91
21+
</action>
1922
</release>
2023
<release version="5.0.0" date="2017-11-27" description="Spring 5 release" >
2124
<action dev="derjust" type="add">
2225
Added Spring 5 / Spring-Data Kay support
2326
</action>
2427
</release>
2528
<release version="4.5.1" date="2017-12-19">
26-
<action dev="Michael Wyraz" type="fix" issue="92">
29+
<action dev="Michael Wyraz" type="fix" issue="91">
2730
Add constructor to DynamoDBTemplate that takes a preconfigured DynamoDBMapper
2831
</action>
2932
</release>

src/main/java/org/socialsignin/spring/data/dynamodb/core/DynamoDBTemplate.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public DynamoDBTemplate(AmazonDynamoDB amazonDynamoDB)
5353

5454
DynamoDBTemplate(AmazonDynamoDB amazonDynamoDB, DynamoDBMapperConfig dynamoDBMapperConfig, DynamoDBMapper dynamoDBMapper) {
5555
this.amazonDynamoDB = amazonDynamoDB;
56-
if (dynamoDBMapper == null && dynamoDBMapperConfig == null)
56+
if (dynamoDBMapper == null && dynamoDBMapperConfig == null) {
5757
this.dynamoDBMapperConfig = DynamoDBMapperConfig.DEFAULT;
5858
this.dynamoDBMapper = new DynamoDBMapper(amazonDynamoDB);
5959
// Mapper must be null as it could not have been constructed without a Config

src/test/java/org/socialsignin/spring/data/dynamodb/core/DynamoDBTemplateUnitTest.java

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
import java.util.ArrayList;
1818
import java.util.List;
1919

20+
import static org.junit.Assert.assertTrue;
21+
2022
@RunWith(MockitoJUnitRunner.class)
2123
public class DynamoDBTemplateUnitTest {
2224

@@ -28,12 +30,20 @@ public class DynamoDBTemplateUnitTest {
2830
private DynamoDBMapperConfig dynamoDBMapperConfig;
2931

3032
private DynamoDBTemplate dynamoDBTemplate;
31-
33+
3234
@Before
3335
public void setUp() {
3436
this.dynamoDBTemplate = new DynamoDBTemplate(dynamoDB, dynamoDBMapperConfig, dynamoDBMapper);
3537
}
36-
38+
39+
@Test
40+
public void testPreconfiguredDynamoDBMapper() {
41+
// Introduced constructor via #91 should not fail its assert
42+
DynamoDBTemplate usePreconfiguredDynamoDBMapper = new DynamoDBTemplate(dynamoDB, dynamoDBMapper);
43+
44+
assertTrue("The constructor should not fail with an assert error", true);
45+
}
46+
3747
@SuppressWarnings("unchecked")
3848
@Test
3949
public void testBatchDelete_CallsCorrectDynamoDBMapperMethod()

0 commit comments

Comments
 (0)