Skip to content

Commit 70c0417

Browse files
authored
Merge pull request #38 from CiliaFred/master
Update AWS SDK version
2 parents 24801ef + 2199f29 commit 70c0417

File tree

4 files changed

+43
-36
lines changed

4 files changed

+43
-36
lines changed

pom.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@
1616
</licenses>
1717

1818
<properties>
19-
<spring.version>4.2.0.RELEASE</spring.version>
19+
<spring.version>4.3.1.RELEASE</spring.version>
2020
<spring-data.version>Gosling-SR1</spring-data.version>
21-
<hibernate-validator.version>5.2.2.Final</hibernate-validator.version>
22-
<aws-java-sdk.version>1.10.39</aws-java-sdk.version>
21+
<hibernate-validator.version>5.2.4.Final</hibernate-validator.version>
22+
<aws-java-sdk.version>1.11.15</aws-java-sdk.version>
2323
<mockito.version>1.10.19</mockito.version>
2424

2525
<cdi.version>1.2</cdi.version>
26-
<logback.version>1.1.3</logback.version>
26+
<logback.version>1.1.7</logback.version>
2727

2828
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
2929
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>

src/main/java/org/socialsignin/spring/data/dynamodb/core/DynamoDBOperations.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,11 @@ public interface DynamoDBOperations {
2727

2828
public void save(Object entity);
2929
public void batchSave(List<?> entities);
30+
public void batchSave(Iterable<?> entities);
3031

3132
public void delete(Object entity);
3233
public void batchDelete(List<?> entities);
34+
public void batchDelete(Iterable<?> entities);
3335

3436
public <T> String getOverriddenTableName(Class<T> domainClass, String tableName);
3537

src/main/java/org/socialsignin/spring/data/dynamodb/core/DynamoDBTemplate.java

Lines changed: 33 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package org.socialsignin.spring.data.dynamodb.core;
22

3+
import java.util.Iterator;
34
import java.util.List;
45
import java.util.Map;
56

@@ -135,17 +136,24 @@ public void save(Object entity) {
135136
}
136137

137138
@Override
139+
@Deprecated
138140
public void batchSave(List<?> entities) {
139-
for (Object entity : entities)
140-
{
141-
maybeEmitEvent(new BeforeSaveEvent<Object>(entity));
142-
}
143-
dynamoDBMapper.batchSave(entities);
144-
for (Object entity : entities)
145-
{
146-
maybeEmitEvent(new AfterSaveEvent<Object>(entity));
147-
}
141+
Iterable<?> iterableEntities = entities;
142+
batchSave(iterableEntities);
148143
}
144+
145+
@Override
146+
public void batchSave(Iterable<?> entities) {
147+
Iterator<?> iteratorBefore = entities.iterator();
148+
while( iteratorBefore.hasNext() ){
149+
maybeEmitEvent(new BeforeSaveEvent<Object>(iteratorBefore.next()));
150+
}
151+
dynamoDBMapper.batchSave(entities);
152+
Iterator<?> iteratorAfter = entities.iterator();
153+
while( iteratorAfter.hasNext() ){
154+
maybeEmitEvent(new BeforeSaveEvent<Object>(iteratorAfter.next()));
155+
}
156+
}
149157

150158
@Override
151159
public void delete(Object entity) {
@@ -156,17 +164,23 @@ public void delete(Object entity) {
156164
}
157165

158166
@Override
167+
@Deprecated
159168
public void batchDelete(List<?> entities) {
160-
for (Object entity : entities)
161-
{
162-
maybeEmitEvent(new BeforeDeleteEvent<Object>(entity));
163-
}
164-
dynamoDBMapper.batchDelete(entities);
165-
for (Object entity : entities)
166-
{
167-
maybeEmitEvent(new AfterDeleteEvent<Object>(entity));
168-
}
169-
169+
Iterable<?> iterableEntities = entities;
170+
batchDelete(iterableEntities);
171+
}
172+
173+
@Override
174+
public void batchDelete(Iterable<?> entities) {
175+
Iterator<?> iteratorBefore = entities.iterator();
176+
while( iteratorBefore.hasNext() ){
177+
maybeEmitEvent(new BeforeDeleteEvent<Object>(iteratorBefore.next()));
178+
}
179+
dynamoDBMapper.batchDelete(entities);
180+
Iterator<?> iteratorAfter = entities.iterator();
181+
while( iteratorAfter.hasNext() ){
182+
maybeEmitEvent(new AfterDeleteEvent<Object>(iteratorAfter.next()));
183+
}
170184
}
171185

172186
@Override

src/main/java/org/socialsignin/spring/data/dynamodb/repository/support/SimpleDynamoDBCrudRepository.java

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -132,13 +132,9 @@ public <S extends T> S save(S entity) {
132132
}
133133

134134
@Override
135-
public <S extends T> List<S> save(Iterable<S> entities) {
136-
final List<S> entityList = new ArrayList<S>();
137-
for (S entity : entities) {
138-
entityList.add(entity);
139-
}
140-
dynamoDBOperations.batchSave(entityList);
141-
return entityList;
135+
public <S extends T> Iterable<S> save(Iterable<S> entities) {
136+
dynamoDBOperations.batchSave(entities);
137+
return entities;
142138
}
143139

144140
@Override
@@ -201,12 +197,7 @@ public void delete(T entity) {
201197
public void delete(Iterable<? extends T> entities) {
202198

203199
Assert.notNull(entities, "The given Iterable of entities not be null!");
204-
205-
List<T> entityList = new ArrayList<T>();
206-
for (T entity : entities) {
207-
entityList.add(entity);
208-
}
209-
dynamoDBOperations.batchDelete(entityList);
200+
dynamoDBOperations.batchDelete(entities);
210201
}
211202

212203
@Override

0 commit comments

Comments
 (0)