debugging

Author: thejoeker12

response/error.go

@@ -54,7 +54,7 @@ func HandleAPIErrorResponse(resp *http.Response, sugar *zap.SugaredLogger) *APIE
 		return apiError
 	}
 
-	mimeType, _ := parseDispositionHeader(resp.Header.Get("Content-Type"))
+	mimeType, _ := parseHeader(resp.Header.Get("Content-Type"))
 	switch mimeType {
 	case "application/json":
 		parseJSONResponse(bodyBytes, apiError)

response/parse.go

@@ -6,7 +6,7 @@ import "strings"
 // parseHeader generalizes the parsing of headers like Content-Type and Content-Disposition.
 // It extracts the main value (e.g., MIME type for Content-Type) and any parameters (like charset).
 // TODO we need to talk about what this does.
-func parseDispositionHeader(header string) (string, map[string]string) {
+func parseHeader(header string) (string, map[string]string) {
 	parts := strings.SplitN(header, ";", 2)
 	mainValue := strings.TrimSpace(parts[0])
 

response/success.go

@@ -52,7 +52,9 @@ func HandleAPISuccessResponse(resp *http.Response, out interface{}, sugar *zap.S
 	sugar.Debug("LOGHERE-HandleApiSuccessResponse")
 	sugar.Debugw("Headers:", "content-type", contentType, "content-disposition", contentDisposition)
 
-	if handler, ok = responseUnmarshallers[contentType]; ok {
+	contentTypeNoParams, _ := parseHeader(contentType)
+
+	if handler, ok = responseUnmarshallers[contentTypeNoParams]; ok {
 		return handler(bodyReader, out, sugar, contentType)
 	}
 
@@ -125,7 +127,7 @@ func handleBinaryData(reader io.Reader, sugar *zap.SugaredLogger, out interface{
 	}
 
 	if contentDisposition != "" {
-		_, params := parseDispositionHeader(contentDisposition)
+		_, params := parseHeader(contentDisposition)
 		if filename, ok := params["filename"]; ok {
 			sugar.Debug("Extracted filename from Content-Disposition", zap.String("filename", filename))
 		}

response/t_parse_test.go

@@ -35,7 +35,7 @@ func TestParseContentTypeHeader(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			gotType, gotParams := parseDispositionHeader(tt.header)
+			gotType, gotParams := parseHeader(tt.header)
 			if gotType != tt.wantType {
 				t.Errorf("ParseContentTypeHeader() gotType = %v, want %v", gotType, tt.wantType)
 			}
@@ -70,7 +70,7 @@ func TestParseContentDisposition(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			gotType, gotParams := parseDispositionHeader(tt.header)
+			gotType, gotParams := parseHeader(tt.header)
 			if gotType != tt.wantType {
 				t.Errorf("ParseContentDisposition() gotType = %v, want %v", gotType, tt.wantType)
 			}