Refactor cookie handling configuration and environment variable handling

ShocOne · ShocOne · commit 20d3720414d6 · 2024-04-25T09:05:18.000+01:00
diff --git a/httpclient/client.go b/httpclient/client.go
@@ -78,7 +78,8 @@ type LoggingConfig struct {
 
 // CookieConfig holds configuration related to cookie handling.
 type CookieConfig struct {
-	EnableCookieJar bool // Enable or disable cookie jar
+	EnableCookieJar bool              // Enable or disable cookie jar
+	SpecificCookies map[string]string `json:"SpecificCookies,omitempty"` // Key-value pairs for specific cookies
 }
 
 // RetryConfig holds configuration related to retry behavior.
diff --git a/httpclient/client_configuration.go b/httpclient/client_configuration.go
@@ -138,7 +138,7 @@ func LoadConfigFromEnv(config *ClientConfig) (*ClientConfig, error) {
 
 	// Cookies
 	config.ClientOptions.Cookie.EnableCookieJar = parseBool(getEnvOrDefault("ENABLE_COOKIE_JAR", strconv.FormatBool(config.ClientOptions.Cookie.EnableCookieJar)))
-	log.Printf("EnableCookies env value found and set to: %t", config.ClientOptions.Cookie.EnableCookieJar)
+	log.Printf("EnableCookieJar env value found and set to: %t", config.ClientOptions.Cookie.EnableCookieJar)
 
 	// Retry
 	config.ClientOptions.Retry.MaxRetryAttempts = parseInt(getEnvOrDefault("MAX_RETRY_ATTEMPTS", strconv.Itoa(config.ClientOptions.Retry.MaxRetryAttempts)), DefaultMaxRetryAttempts)

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,8 @@ type LoggingConfig struct {`
`78`	`78`
`79`	`79`	`// CookieConfig holds configuration related to cookie handling.`
`80`	`80`	`type CookieConfig struct {`
`81`		`- EnableCookieJar bool // Enable or disable cookie jar`
	`81`	`+ EnableCookieJar bool // Enable or disable cookie jar`
	`82`	+ SpecificCookies map[string]string `json:"SpecificCookies,omitempty"` // Key-value pairs for specific cookies
`82`	`83`	`}`
`83`	`84`
`84`	`85`	`// RetryConfig holds configuration related to retry behavior.`