Commit 3fc5dc7
authored
chore: Remove macOS metadata from test data tarballs (#1534)
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://github.com/delta-incubator/delta-kernel-rs/blob/main/CONTRIBUTING.md
2. Run `cargo t --all-features --all-targets` to get started testing,
and run `cargo fmt`.
3. Ensure you have added or run the appropriate tests for your PR.
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]
Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
-->
<!--
PR title formatting:
This project uses conventional commits:
https://www.conventionalcommits.org/
Each PR corresponds to a commit on the `main` branch, with the title of
the PR (typically) being
used for the commit message on main. In order to ensure proper
formatting in the CHANGELOG please
ensure your PR title adheres to the conventional commit specification.
Examples:
- new feature PR: "feat: new API for snapshot.update()"
- bugfix PR: "fix: correctly apply DV in read-table example"
-->
## What changes are proposed in this pull request?
<!--
Please clarify what changes you are proposing and why the changes are
needed.
The purpose of this section is to outline the changes, why they are
needed, and how this PR fixes the issue.
If the reason for the change is already explained clearly in an issue,
then it does not need to be restated here.
1. If you propose a new API or feature, clarify the use case for a new
API or feature.
2. If you fix a bug, you can clarify why it is a bug.
-->
Remove AppleDouble files (`._*`, `.__*`) and macOS extended attributes
from test data tarballs.
The macOS metadata was handled in two ways:
1. AppleDouble files (._*, .__*) - Explicitly deleted:
find "$name" -name '._*' -delete
find "$name" -name '.__*' -delete
2. Extended attributes (LIBARCHIVE.xattr.*) - Automatically stripped:
When extracting on Linux, the macOS extended attributes (stored in PAX
headers) are ignored:
tar: Ignoring unknown extended header keyword
'LIBARCHIVE.xattr.com.apple.provenance'
tar: Ignoring unknown extended header keyword
'LIBARCHIVE.xattr.com.apple.quarantine'
This is what Claude code came up with:
```
1. Identified affected files
for f in *.tar.zst; do
tar --zstd -tvf "$f" 2>&1 | grep -E '/\._|LIBARCHIVE\.xattr'
done
Found 25 tarballs containing macOS AppleDouble files (._*, .__*) and extended attributes.
2. Cleaned each tarball
for tarball in *.tar.zst; do
name="${tarball%.tar.zst}"
# Extract
tar --zstd -xf "$tarball"
# Remove AppleDouble files
find "$name" -name '._*' -delete
find "$name" -name '.__*' -delete
# Recompress
tar --zstd -cf "$tarball" "$name"
# Cleanup
rm -rf "$name"
done
```
<!--
Uncomment this section if there are any changes affecting public APIs:
### This PR affects the following public APIs
If there are breaking changes, please ensure the `breaking-changes`
label gets added by CI, and describe why the changes are needed.
Note that _new_ public APIs are not considered breaking.
-->
## How was this change tested?
<!--
Please make sure to add test cases that check the changes thoroughly
including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please
clarify how you tested, ideally via a reproducible test documented in
the PR description.
-->
Tests pass and opening up a tarball now contains no artifacts1 parent c011911 commit 3fc5dc7
File tree
25 files changed
+0
-0
lines changed- kernel/tests/data
25 files changed
+0
-0
lines changedBinary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
0 commit comments