Merge pull request #241 from delphix/master

Merge branch 'master' into '6.0/stage'

Author: Prakash Surya

sdb/command.py

@@ -328,7 +328,8 @@ def call(self, objs: Iterable[drgn.Object]) -> Iterable[drgn.Object]:
                 yield from self.__invalid_memory_objects_check(
                     result, not issubclass(self.__class__, SingleInputCommand))
         except drgn.FaultError as err:
-            raise CommandError(self.name, f"invalid memory access: {str(err)}")
+            raise CommandError(self.name,
+                               f"invalid memory access: {str(err)}") from err
 
 
 class SingleInputCommand(Command):
@@ -409,15 +410,16 @@ def __init__(self,
         tname = " ".join(self.args.type)
         try:
             self.type = target.get_type(tname)
-        except LookupError:
-            raise CommandError(self.name, f"could not find type '{tname}'")
+        except LookupError as err:
+            raise CommandError(self.name,
+                               f"could not find type '{tname}'") from err
 
     def _call(self, objs: Iterable[drgn.Object]) -> Iterable[drgn.Object]:
         for obj in objs:
             try:
                 yield drgn.cast(self.type, obj)
             except TypeError as err:
-                raise CommandError(self.name, str(err))
+                raise CommandError(self.name, str(err)) from err
 
 
 class Dereference(Command):
@@ -546,8 +548,8 @@ def _call(self, objs: Iterable[drgn.Object]) -> Iterable[drgn.Object]:
         for symbol in self.args.symbols:
             try:
                 yield Address.resolve_for_address(symbol)
-            except KeyError:
-                raise SymbolNotFoundError(self.name, symbol)
+            except KeyError as err:
+                raise SymbolNotFoundError(self.name, symbol) from err
 
 
 class Walk(Command):

sdb/commands/echo.py

@@ -43,6 +43,6 @@ def _call(self, objs: Iterable[drgn.Object]) -> Iterable[drgn.Object]:
         for addr in self.args.addrs:
             try:
                 value_ = int(addr, 0)
-            except ValueError:
-                raise sdb.CommandInvalidInputError(self.name, addr)
+            except ValueError as err:
+                raise sdb.CommandInvalidInputError(self.name, addr) from err
             yield sdb.create_object("void *", value_)

sdb/commands/help.py

@@ -39,8 +39,8 @@ def _call(self, objs: Iterable[drgn.Object]) -> None:
         if self.args.cmd is not None:
             try:
                 all_cmds[self.args.cmd].help(self.args.cmd)
-            except KeyError:
-                raise sdb.error.CommandNotFoundError(self.args.cmd)
+            except KeyError as err:
+                raise sdb.error.CommandNotFoundError(self.args.cmd) from err
         else:
             cmds: Dict[str, Type[sdb.Command]] = {}
             for k, v in all_cmds.items():

sdb/commands/internal/table.py

@@ -27,13 +27,6 @@ class Table:
 
     __slots__ = "fields", "rjustfields", "formatters", "maxfieldlen", "lines"
 
-    #
-    # The "yapf" tool expects 4 spaces for the continuation lines here,
-    # where "pylint" expects 8 spaces. To reconcile the difference in
-    # expectations of both tools, we disable the pylint error, and
-    # adhere to the yapf format.
-    #
-    # pylint: disable=bad-continuation
     def __init__(
             self,
             fields: List[str],

sdb/commands/linux/per_cpu.py

@@ -98,6 +98,7 @@ class LxPerCpuCounterSum(sdb.SingleInputCommand):
     def _call_one(self, obj: drgn.Object) -> Iterable[drgn.Object]:
         try:
             sum_ = drgn_percpu.percpu_counter_sum(obj)
-        except AttributeError:
-            raise sdb.CommandError(self.name, "input is not a percpu_counter")
+        except AttributeError as err:
+            raise sdb.CommandError(self.name,
+                                   "input is not a percpu_counter") from err
         yield drgn.Object(sdb.get_prog(), type="s64", value=sum_)

sdb/commands/stacks.py

@@ -295,9 +295,10 @@ def validate_args(self) -> None:
                 #
                 func = sdb.get_object(self.args.function)
                 sym = sdb.get_symbol(func.address_of_())
-            except KeyError:
+            except KeyError as err:
                 raise sdb.CommandError(
-                    self.name, f"symbol '{self.args.function}' does not exist")
+                    self.name,
+                    f"symbol '{self.args.function}' does not exist") from err
             if func.type_.kind != drgn.TypeKind.FUNCTION:
                 raise sdb.CommandError(
                     self.name, f"'{self.args.function}' is not a function")
@@ -356,10 +357,9 @@ def print_header(self) -> None:
     # task state and program counters. Return a collection sorted by number
     # of tasks per stack.
     #
-    # Note: we disabled pyline C0330 due to https://github.com/PyCQA/pylint/issues/289
     @staticmethod
     def aggregate_stacks(
-        objs: Iterable[drgn.Object]  # pylint: disable=C0330
+        objs: Iterable[drgn.Object]
     ) -> List[Tuple[Tuple[str, Tuple[int, ...]], List[drgn.Object]]]:
         stack_aggr: Dict[Tuple[str, Tuple[int, ...]],
                          List[drgn.Object]] = defaultdict(list)

sdb/pipeline.py

@@ -107,7 +107,7 @@ def invoke(myprog: drgn.Program, first_input: Iterable[drgn.Object],
                 raise CommandNotFoundError(name)
             try:
                 pipeline.append(get_registered_commands()[name](args, name))
-            except SystemExit:
+            except SystemExit as cmd_exit:
                 #
                 # The passed in arguments to each command will be parsed in
                 # the command object's constructor. We use "argparse" to do
@@ -116,7 +116,7 @@ def invoke(myprog: drgn.Program, first_input: Iterable[drgn.Object],
                 # SDB session, we only abort this specific pipeline by raising
                 # a CommandArgumentsError.
                 #
-                raise CommandArgumentsError(name)
+                raise CommandArgumentsError(name) from cmd_exit
         else:
             assert cmd_type == parser.ExpressionType.SHELL_CMD
             shell_cmd = cmd

sdb/target.py

@@ -104,12 +104,13 @@ def type_canonicalize(t: drgn.Type) -> drgn.Type:
 
     Note: function type's arguments and return types are not canonicalized.
     """
+    global prog
     if t.kind == drgn.TypeKind.TYPEDEF:
         return type_canonicalize(t.type)
     if t.kind == drgn.TypeKind.POINTER:
-        return drgn.pointer_type(t.size, type_canonicalize(t.type))
+        return prog.pointer_type(type_canonicalize(t.type), t.size)
     if t.kind == drgn.TypeKind.ARRAY:
-        return drgn.array_type(t.length, type_canonicalize(t.type))
+        return prog.array_type(type_canonicalize(t.type), t.length)
     return t.unqualified()
 
 

tests/integration/test_core_generic.py

@@ -16,7 +16,6 @@
 
 # pylint: disable=missing-module-docstring
 # pylint: disable=missing-function-docstring
-# pylint: disable=not-callable
 
 from typing import Any
 

tests/integration/test_linux_generic.py

@@ -17,7 +17,6 @@
 # pylint: disable=missing-module-docstring
 # pylint: disable=missing-function-docstring
 # pylint: disable=line-too-long
-# pylint: disable=not-callable
 
 from typing import Any