pdb/cdb fixes

Author: Marcin Przepiorowski

CHANGELOG.md

@@ -1,3 +1,14 @@
+## 2.4.19
+
+### Changes:
+- [bug #227](https://github.com/delphix/dxtoolkit/issues/227) - snapshot order fixed
+- [bug #226](https://github.com/delphix/dxtoolkit/issues/226) - link / unlink (attach / detech) works for vPDB and CDB
+- build fixes
+
+### Added
+- [bug #225](https://github.com/delphix/dxtoolkit/issues/225) - support for vPDB/vCDB with TDE
+
+
 ## 2.4.18
 
 ### Added

bin/dx_ctl_dsource.pl

@@ -346,7 +346,7 @@
     if ( $type eq 'oracle' ) {
       my $db = new OracleVDB_obj($engine_obj,$debug);
 
-      if (defined($cdbcont)) {
+      if (defined($cdbcont) && defined($cdbuser)) {
         if ($db->discoverPDB($sourceinst,$sourceenv,$cdbcont,$cdbuser,$cdbpass)) {
           print "There was an error with PDB discovery \n";
           $ret = $ret + 1;
@@ -357,7 +357,7 @@
         $ret = $ret + 1;
         last;
       }
-      $jobno = $db->addSource($sourcename,$sourceinst,$sourceenv,$source_os_user,$dbuser,$password,$dsourcename,$group,$logsync);
+      $jobno = $db->addSource($sourcename,$sourceinst,$sourceenv,$source_os_user,$dbuser,$password,$dsourcename,$group,$logsync, $cdbcont);
     }
     elsif ($type eq 'sybase') {
       my $db = new SybaseVDB_obj($engine_obj,$debug);

lib/OracleVDB_obj.pm

@@ -1627,6 +1627,12 @@ sub setConfig {
 
     logger($self->{_debug}, "Entering OracleVDB_obj::setConfig",1);
 
+    logger($self->{_debug}, "name: " . Dumper $name, 2);
+    logger($self->{_debug}, "source_inst: " . Dumper $source_inst, 2);
+    logger($self->{_debug}, "source_env: " . Dumper $source_env, 2);
+    logger($self->{_debug}, "cdbcont: " . Dumper $cdbcont, 2);
+    
+    
     my $dlpxObject = $self->{_dlpxObject};
     my $debug = $self->{_debug};
 
@@ -1977,11 +1983,12 @@ sub addSource {
     my $dsource_name = shift;
     my $group = shift;
     my $logsync = shift;
+    my $cdbcont = shift;
 
 
     logger($self->{_debug}, "Entering OracleVDB_obj::addSource",1);
 
-    my $config = $self->setConfig($source, $source_inst, $source_env);
+    my $config = $self->setConfig($source, $source_inst, $source_env, $cdbcont);
 
     if (! defined($config)) {
         print "Source database $source not found\n";