Skip to content

Commit d65e74b

Browse files
author
Uddipaan Hazarika
committed
addressed code review observations and minor doc changes
1 parent 499f289 commit d65e74b

File tree

7 files changed

+53
-52
lines changed

7 files changed

+53
-52
lines changed

docs/resources/oracle_dsource.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ In Delphix terminology, a dSource is an internal, read-only database copy that t
44

55
A dSource is created and managed by the Delphix Continuous Data Engine and syncs with your chosen source database.
66

7-
The Oracle dSource resource allows Terraform to create and delete Oracle dSources. This specifically enables the `apply`, `import`, and `destroy` Terraform commands.
7+
The Oracle dSource resource allows Terraform to create and delete Oracle dSources via Terraform automation. This specifically enables the `apply`, `import`, and `destroy` Terraform commands.
88

99
Updating existing dSource resource parameters via the `apply` command is supported for the parameters listed below.
1010

@@ -82,10 +82,11 @@ The following arguments enable the user to control how the first snapshot should
8282
* `double_sync` - True if two SnapSyncs should be performed in immediate succession to reduce the number of logs required to provision the snapshot. This may significantly reduce the time necessary to provision from a snapshot.
8383
* `do_not_resume` - Indicates if a fresh SnapSync must be started regardless of whether it was possible to resume the current SnapSync. If true, we will not resume; instead, we will ignore previous progress and back up all datafiles even if they have already been completed from the last failed SnapSync. This does not force a full backup; if an incremental was in progress this will start a new incremental snapshot.
8484
* `skip_wait_for_snapshot_creation` - By default this resource will wait for a snapshot to be created post-dSource creation. This ensures a snapshot is available during the VDB provisioning. This behavior can be skipped by setting this parameter to `true`.
85-
* `wait_time` - This value controls how long the resource will wait for the initial snapshot to be successfully ingested by Delphix. By default, the value is 0, meaning it does not wait for the snapshot to be created. If a synchronous behavior, specifies a value that is slightly longer than the average ingestion time. This argument was introduced in Delphix provider v3.2.1.
85+
* `wait_time` - This value controls how long the resource will wait for the initial snapshot to be successfully ingested by Delphix. By default, the value is 0, meaning it does not wait for the snapshot to be created. When using this parameter, it is recommended to use a value that is slightly longer than the average ingestion time. This argument was introduced in Delphix provider v3.2.1.
8686

8787
This parameter can be ignored if 'skip_wait_for_snapshot_creation' is set to `true`.
8888

89+
Note: In DCT v2025.1, waiting for SnapSync to complete is default functionality. Therefore, these the arguments `skip_wait_for_snapshot_creation` and `wait_time` are ignored. In future versions of the provider, we will look at re-implementing the skip SnapSync behavior.
8990

9091
### Password and Password Vault Management
9192

internal/provider/resource_appdata_dsource.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -469,9 +469,9 @@ func resourceAppdataDsourceCreate(ctx context.Context, d *schema.ResourceData, m
469469
return diags
470470
}
471471

472-
d.SetId(*apiRes.DsourceId)
472+
d.SetId(apiRes.GetDsourceId())
473473

474-
job_res, job_err := PollJobStatus(*apiRes.Job.Id, ctx, client)
474+
job_res, job_err := PollJobStatus(apiRes.Job.GetId(), ctx, client)
475475
if job_err != "" {
476476
tflog.Error(ctx, DLPX+ERROR+"Job Polling failed but continuing with dSource creation. Error: "+job_err)
477477
}
@@ -481,10 +481,10 @@ func resourceAppdataDsourceCreate(ctx context.Context, d *schema.ResourceData, m
481481
rollback_on_failure := d.Get("rollback_on_failure").(bool)
482482

483483
if job_res == Failed || job_res == Canceled || job_res == Abandoned {
484-
tflog.Error(ctx, DLPX+ERROR+"Job "+job_res+" "+*apiRes.Job.Id+"!")
484+
tflog.Error(ctx, DLPX+ERROR+"Job "+job_res+" "+apiRes.Job.GetId()+"!")
485485
if rollback_on_failure {
486486
if job_res == Failed {
487-
res := isSnapSyncFailure(*apiRes.Job.Id, ctx, client)
487+
res := isSnapSyncFailure(apiRes.Job.GetId(), ctx, client)
488488
if res {
489489
deleteDiags := resourceDsourceDelete(ctx, d, meta)
490490
if deleteDiags.HasError() {
@@ -500,7 +500,7 @@ func resourceAppdataDsourceCreate(ctx context.Context, d *schema.ResourceData, m
500500
return readDiags
501501
}
502502
}
503-
return diag.Errorf("[NOT OK] Job %s %s with error %s", *apiRes.Job.Id, job_res, job_err)
503+
return diag.Errorf("[NOT OK] Job %s %s with error %s", apiRes.Job.GetId(), job_res, job_err)
504504
}
505505

506506
PollSnapshotStatus(d, ctx, client)
@@ -605,13 +605,13 @@ func resourceDsourceDelete(ctx context.Context, d *schema.ResourceData, meta int
605605
return diags
606606
}
607607

608-
job_status, job_err := PollJobStatus(*res.Id, ctx, client)
608+
job_status, job_err := PollJobStatus(res.GetId(), ctx, client)
609609
if job_err != "" {
610610
tflog.Warn(ctx, DLPX+WARN+"Job Polling failed but continuing with deletion. Error :"+job_err)
611611
}
612612
tflog.Info(ctx, DLPX+INFO+"Job result is "+job_status)
613613
if isJobTerminalFailure(job_status) {
614-
return diag.Errorf("[NOT OK] dSource-Delete %s. JobId: %s / Error: %s", job_status, *res.Id, job_err)
614+
return diag.Errorf("[NOT OK] dSource-Delete %s. JobId: %s / Error: %s", job_status, res.GetId(), job_err)
615615
}
616616

617617
_, diags := PollForObjectDeletion(ctx, func() (interface{}, *http.Response, error) {

internal/provider/resource_database_postgresql.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -157,9 +157,9 @@ func resourceDatabasePostgressqlCreate(ctx context.Context, d *schema.ResourceDa
157157
return diags
158158
}
159159

160-
d.SetId(*apiRes.SourceId)
160+
d.SetId(apiRes.GetSourceId())
161161

162-
job_res, job_err := PollJobStatus(*apiRes.Job.Id, ctx, client)
162+
job_res, job_err := PollJobStatus(apiRes.Job.GetId(), ctx, client)
163163
if job_err != "" {
164164
tflog.Error(ctx, DLPX+ERROR+"Job Polling failed but continuing with Source creation. Error: "+job_err)
165165
}
@@ -168,8 +168,8 @@ func resourceDatabasePostgressqlCreate(ctx context.Context, d *schema.ResourceDa
168168

169169
if job_res == Failed || job_res == Canceled || job_res == Abandoned {
170170
d.SetId("")
171-
tflog.Error(ctx, DLPX+ERROR+"Job "+job_res+" "+*apiRes.Job.Id)
172-
return diag.Errorf("[NOT OK] Job %s %s with error %s", *apiRes.Job.Id, job_res, job_err)
171+
tflog.Error(ctx, DLPX+ERROR+"Job "+job_res+" "+apiRes.Job.GetId())
172+
return diag.Errorf("[NOT OK] Job %s %s with error %s", apiRes.Job.GetId(), job_res, job_err)
173173
}
174174

175175
readDiags := resourceDatabasePostgressqlRead(ctx, d, meta)
@@ -300,13 +300,13 @@ func resourceDatabasePostgressqlUpdate(ctx context.Context, d *schema.ResourceDa
300300
return diags
301301
}
302302

303-
job_status, job_err := PollJobStatus(*res.Job.Id, ctx, client)
303+
job_status, job_err := PollJobStatus(res.Job.GetId(), ctx, client)
304304
if job_err != "" {
305305
tflog.Warn(ctx, DLPX+WARN+"Source Update Job Polling failed but continuing with update. Error :"+job_err)
306306
}
307307
tflog.Info(ctx, DLPX+INFO+"Job result is "+job_status)
308308
if isJobTerminalFailure(job_status) {
309-
return diag.Errorf("[NOT OK] Source-Update %s. JobId: %s / Error: %s", job_status, *res.Job.Id, job_err)
309+
return diag.Errorf("[NOT OK] Source-Update %s. JobId: %s / Error: %s", job_status, res.Job.GetId(), job_err)
310310
}
311311

312312
return diags
@@ -323,13 +323,13 @@ func resourceDatabasePostgressqlDelete(ctx context.Context, d *schema.ResourceDa
323323
return diags
324324
}
325325

326-
job_status, job_err := PollJobStatus(*res.Job.Id, ctx, client)
326+
job_status, job_err := PollJobStatus(res.Job.GetId(), ctx, client)
327327
if job_err != "" {
328328
tflog.Warn(ctx, DLPX+WARN+"Job Polling failed but continuing with deletion. Error :"+job_err)
329329
}
330330
tflog.Info(ctx, DLPX+INFO+" Job result is "+job_status)
331331
if isJobTerminalFailure(job_status) {
332-
return diag.Errorf("[NOT OK] Source-Delete %s. JobId: %s / Error: %s", job_status, *res.Job.Id, job_err)
332+
return diag.Errorf("[NOT OK] Source-Delete %s. JobId: %s / Error: %s", job_status, res.Job.GetId(), job_err)
333333
}
334334

335335
_, diags := PollForObjectDeletion(ctx, func() (interface{}, *http.Response, error) {

internal/provider/resource_environment.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -393,15 +393,15 @@ func resourceEnvironmentCreate(ctx context.Context, d *schema.ResourceData, meta
393393
}
394394

395395
d.SetId(apiRes.GetEnvironmentId())
396-
job_status, job_err := PollJobStatus(*apiRes.Job.Id, ctx, client)
396+
job_status, job_err := PollJobStatus(apiRes.Job.GetId(), ctx, client)
397397

398398
if job_err != "" {
399399
tflog.Error(ctx, DLPX+ERROR+"Job Polling failed but continuing with env creation. Error: "+job_err)
400400
}
401401

402402
if isJobTerminalFailure(job_status) {
403403
d.SetId("")
404-
return diag.Errorf("[NOT OK] Env-Create %s. JobId: %s / Error: %s", job_status, *apiRes.Job.Id, job_err)
404+
return diag.Errorf("[NOT OK] Env-Create %s. JobId: %s / Error: %s", job_status, apiRes.Job.GetId(), job_err)
405405
}
406406
// Get environment info and store state.
407407
readDiags := resourceEnvironmentRead(ctx, d, meta)
@@ -463,12 +463,12 @@ func resourceEnvironmentDelete(ctx context.Context, d *schema.ResourceData, meta
463463
return diags
464464
}
465465

466-
job_status, job_err := PollJobStatus(*apiRes.Job.Id, ctx, client)
466+
job_status, job_err := PollJobStatus(apiRes.Job.GetId(), ctx, client)
467467
if job_err != "" {
468468
tflog.Error(ctx, DLPX+ERROR+"Job Polling failed but continuing with env deletion. Error: "+job_err)
469469
}
470470
if isJobTerminalFailure(job_status) {
471-
return diag.Errorf("[NOT OK] Env-Delete %s. JobId: %s / Error: %s", job_status, *apiRes.Job.Id, job_err)
471+
return diag.Errorf("[NOT OK] Env-Delete %s. JobId: %s / Error: %s", job_status, apiRes.Job.GetId(), job_err)
472472
}
473473
_, diags := PollForObjectDeletion(ctx, func() (interface{}, *http.Response, error) {
474474
return client.EnvironmentsAPI.GetEnvironmentById(ctx, envId).Execute()

internal/provider/resource_oracle_dsource.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -786,9 +786,9 @@ func resourceOracleDsourceCreate(ctx context.Context, d *schema.ResourceData, me
786786
return diags
787787
}
788788

789-
d.SetId(*apiRes.DsourceId)
789+
d.SetId(apiRes.GetDsourceId())
790790

791-
job_res, job_err := PollJobStatus(*apiRes.Job.Id, ctx, client)
791+
job_res, job_err := PollJobStatus(apiRes.Job.GetId(), ctx, client)
792792
if job_err != "" {
793793
tflog.Error(ctx, DLPX+ERROR+"Job Polling failed but continuing with dSource creation. Error: "+job_err)
794794
}
@@ -798,10 +798,10 @@ func resourceOracleDsourceCreate(ctx context.Context, d *schema.ResourceData, me
798798
rollback_on_failure := d.Get("rollback_on_failure").(bool)
799799

800800
if job_res == Failed || job_res == Canceled || job_res == Abandoned {
801-
tflog.Error(ctx, DLPX+ERROR+"Job "+job_res+" "+*apiRes.Job.Id+"!")
801+
tflog.Error(ctx, DLPX+ERROR+"Job "+job_res+" "+apiRes.Job.GetId()+"!")
802802
if rollback_on_failure {
803803
if job_res == Failed {
804-
res := isSnapSyncFailure(*apiRes.Job.Id, ctx, client)
804+
res := isSnapSyncFailure(apiRes.Job.GetId(), ctx, client)
805805
if res {
806806
deleteDiags := resourceOracleDsourceDelete(ctx, d, meta)
807807
if deleteDiags.HasError() {
@@ -817,7 +817,7 @@ func resourceOracleDsourceCreate(ctx context.Context, d *schema.ResourceData, me
817817
return readDiags
818818
}
819819
}
820-
return diag.Errorf("[NOT OK] Job %s %s with error %s", *apiRes.Job.Id, job_res, job_err)
820+
return diag.Errorf("[NOT OK] Job %s %s with error %s", apiRes.Job.GetId(), job_res, job_err)
821821
}
822822

823823
PollSnapshotStatus(d, ctx, client)
@@ -1037,13 +1037,13 @@ func resourceOracleDsourceUpdate(ctx context.Context, d *schema.ResourceData, me
10371037
return diags
10381038
}
10391039

1040-
job_status, job_err := PollJobStatus(*res.Job.Id, ctx, client)
1040+
job_status, job_err := PollJobStatus(res.Job.GetId(), ctx, client)
10411041
if job_err != "" {
10421042
tflog.Warn(ctx, DLPX+WARN+"Dsource Update Job Polling failed but continuing with update. Error: "+job_err)
10431043
}
10441044
tflog.Info(ctx, DLPX+INFO+"Job result is "+job_status)
10451045
if isJobTerminalFailure(job_status) {
1046-
return diag.Errorf("[NOT OK] Dsource-Update %s. JobId: %s / Error: %s", job_status, *res.Job.Id, job_err)
1046+
return diag.Errorf("[NOT OK] Dsource-Update %s. JobId: %s / Error: %s", job_status, res.Job.GetId(), job_err)
10471047
}
10481048

10491049
if d.HasChanges(
@@ -1092,13 +1092,13 @@ func resourceOracleDsourceDelete(ctx context.Context, d *schema.ResourceData, me
10921092
return diags
10931093
}
10941094

1095-
job_status, job_err := PollJobStatus(*res.Id, ctx, client)
1095+
job_status, job_err := PollJobStatus(res.GetId(), ctx, client)
10961096
if job_err != "" {
10971097
tflog.Warn(ctx, DLPX+WARN+"Job Polling failed but continuing with deletion. Error :"+job_err)
10981098
}
10991099
tflog.Info(ctx, DLPX+INFO+"Job result is "+job_status)
11001100
if isJobTerminalFailure(job_status) {
1101-
return diag.Errorf("[NOT OK] dSource-Delete %s. JobId: %s / Error: %s", job_status, *res.Id, job_err)
1101+
return diag.Errorf("[NOT OK] dSource-Delete %s. JobId: %s / Error: %s", job_status, res.GetId(), job_err)
11021102
}
11031103

11041104
_, diags := PollForObjectDeletion(ctx, func() (interface{}, *http.Response, error) {

internal/provider/resource_vdb.go

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -996,16 +996,16 @@ func helper_provision_by_snapshot(ctx context.Context, d *schema.ResourceData, m
996996
return diags
997997
}
998998

999-
d.SetId(*apiRes.VdbId)
999+
d.SetId(apiRes.GetVdbId())
10001000

1001-
job_res, job_err := PollJobStatus(*apiRes.Job.Id, ctx, client)
1001+
job_res, job_err := PollJobStatus(apiRes.Job.GetId(), ctx, client)
10021002
if job_err != "" {
10031003
tflog.Error(ctx, DLPX+ERROR+"Job Polling failed but continuing with provisioning. Error: "+job_err)
10041004
}
10051005
tflog.Info(ctx, DLPX+INFO+"Job result is "+job_res)
10061006
if job_res == Failed || job_res == Canceled || job_res == Abandoned {
1007-
tflog.Error(ctx, DLPX+ERROR+"Job "+job_res+" "+*apiRes.Job.Id+"!")
1008-
return diag.Errorf("[NOT OK] Job %s %s with error %s", *apiRes.Job.Id, job_res, job_err)
1007+
tflog.Error(ctx, DLPX+ERROR+"Job "+job_res+" "+apiRes.Job.GetId()+"!")
1008+
return diag.Errorf("[NOT OK] Job %s %s with error %s", apiRes.Job.GetId(), job_res, job_err)
10091009
}
10101010

10111011
readDiags := resourceVdbRead(ctx, d, meta)
@@ -1244,16 +1244,16 @@ func helper_provision_by_timestamp(ctx context.Context, d *schema.ResourceData,
12441244
return diags
12451245
}
12461246

1247-
d.SetId(*apiRes.VdbId)
1247+
d.SetId(apiRes.GetVdbId())
12481248

1249-
job_res, job_err := PollJobStatus(*apiRes.Job.Id, ctx, client)
1249+
job_res, job_err := PollJobStatus(apiRes.Job.GetId(), ctx, client)
12501250
if job_err != "" {
12511251
tflog.Error(ctx, DLPX+ERROR+"Job Polling failed but continuing with provisioning. Error: "+job_err)
12521252
}
12531253
tflog.Info(ctx, DLPX+INFO+"Job result is "+job_res)
12541254
if job_res == "FAILED" {
1255-
tflog.Error(ctx, DLPX+ERROR+"Job "+*apiRes.Job.Id+" Failed!")
1256-
return diag.Errorf("[NOT OK] Job %s Failed with error %s", *apiRes.Job.Id, job_err)
1255+
tflog.Error(ctx, DLPX+ERROR+"Job "+apiRes.Job.GetId()+" Failed!")
1256+
return diag.Errorf("[NOT OK] Job %s Failed with error %s", apiRes.Job.GetId(), job_err)
12571257
}
12581258

12591259
readDiags := resourceVdbRead(ctx, d, meta)
@@ -1477,16 +1477,16 @@ func helper_provision_by_bookmark(ctx context.Context, d *schema.ResourceData, m
14771477
return diags
14781478
}
14791479

1480-
d.SetId(*apiRes.VdbId)
1480+
d.SetId(apiRes.GetVdbId())
14811481

1482-
job_res, job_err := PollJobStatus(*apiRes.Job.Id, ctx, client)
1482+
job_res, job_err := PollJobStatus(apiRes.Job.GetId(), ctx, client)
14831483
if job_err != "" {
14841484
tflog.Error(ctx, DLPX+ERROR+"Job Polling failed but continuing with provisioning. Error: "+job_err)
14851485
}
14861486
tflog.Info(ctx, DLPX+INFO+"Job result is "+job_res)
14871487
if job_res == Failed || job_res == Canceled || job_res == Abandoned {
1488-
tflog.Error(ctx, DLPX+ERROR+"Job "+job_res+*apiRes.Job.Id+"!")
1489-
return diag.Errorf("[NOT OK] Job %s %s with error %s", *apiRes.Job.Id, job_res, job_err)
1488+
tflog.Error(ctx, DLPX+ERROR+"Job "+job_res+apiRes.Job.GetId()+"!")
1489+
return diag.Errorf("[NOT OK] Job %s %s with error %s", apiRes.Job.GetId(), job_res, job_err)
14901490
}
14911491

14921492
readDiags := resourceVdbRead(ctx, d, meta)
@@ -1911,13 +1911,13 @@ func resourceVdbUpdate(ctx context.Context, d *schema.ResourceData, meta interfa
19111911
return diags
19121912
}
19131913

1914-
job_status, job_err := PollJobStatus(*res.Job.Id, ctx, client)
1914+
job_status, job_err := PollJobStatus(res.Job.GetId(), ctx, client)
19151915
if job_err != "" {
19161916
tflog.Warn(ctx, DLPX+WARN+"VDB Update Job Polling failed but continuing with update. Error: "+job_err)
19171917
}
19181918
tflog.Info(ctx, DLPX+INFO+"Job result is "+job_status)
19191919
if isJobTerminalFailure(job_status) {
1920-
return diag.Errorf("[NOT OK] VDB-Update %s. JobId: %s / Error: %s", job_status, *res.Job.Id, job_err)
1920+
return diag.Errorf("[NOT OK] VDB-Update %s. JobId: %s / Error: %s", job_status, res.Job.GetId(), job_err)
19211921
}
19221922

19231923
if d.HasChanges(
@@ -1970,13 +1970,13 @@ func resourceVdbDelete(ctx context.Context, d *schema.ResourceData, meta interfa
19701970
return diags
19711971
}
19721972

1973-
job_status, job_err := PollJobStatus(*res.Job.Id, ctx, client)
1973+
job_status, job_err := PollJobStatus(res.Job.GetId(), ctx, client)
19741974
if job_err != "" {
19751975
tflog.Warn(ctx, DLPX+WARN+"Job Polling failed but continuing with deletion. Error : "+job_err)
19761976
}
19771977
tflog.Info(ctx, DLPX+INFO+"Job result is "+job_status)
19781978
if isJobTerminalFailure(job_status) {
1979-
return diag.Errorf("[NOT OK] VDB-Delete %s. JobId: %s / Error: %s", job_status, *res.Job.Id, job_err)
1979+
return diag.Errorf("[NOT OK] VDB-Delete %s. JobId: %s / Error: %s", job_status, res.Job.GetId(), job_err)
19801980
}
19811981

19821982
_, diags := PollForObjectDeletion(ctx, func() (interface{}, *http.Response, error) {

internal/provider/utility.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -287,15 +287,15 @@ func disableVDB(ctx context.Context, client *dctapi.APIClient, vdbId string) dia
287287
if diags := apiErrorResponseHelper(ctx, apiRes, httpRes, err); diags != nil {
288288
return diags
289289
}
290-
job_res, job_err := PollJobStatus(*apiRes.Job.Id, ctx, client)
290+
job_res, job_err := PollJobStatus(apiRes.Job.GetId(), ctx, client)
291291
if job_err != "" {
292292
tflog.Warn(ctx, DLPX+WARN+"VDB disable Job Polling failed. Error: "+job_err)
293293
//return here
294294
}
295295
tflog.Info(ctx, DLPX+INFO+"Job result is "+job_res)
296296
if job_res == Failed || job_res == Canceled || job_res == Abandoned {
297-
tflog.Error(ctx, DLPX+ERROR+"Job "+job_res+" "+*apiRes.Job.Id+"!")
298-
return diag.Errorf("[NOT OK] Job %s %s with error %s", *apiRes.Job.Id, job_res, job_err)
297+
tflog.Error(ctx, DLPX+ERROR+"Job "+job_res+" "+apiRes.Job.GetId()+"!")
298+
return diag.Errorf("[NOT OK] Job %s %s with error %s", apiRes.Job.GetId(), job_res, job_err)
299299
}
300300
return nil
301301
}
@@ -307,14 +307,14 @@ func enableVDB(ctx context.Context, client *dctapi.APIClient, vdbId string) diag
307307
if diags := apiErrorResponseHelper(ctx, apiRes, httpRes, err); diags != nil {
308308
return diags
309309
}
310-
job_res, job_err := PollJobStatus(*apiRes.Job.Id, ctx, client)
310+
job_res, job_err := PollJobStatus(apiRes.Job.GetId(), ctx, client)
311311
if job_err != "" {
312312
tflog.Warn(ctx, DLPX+WARN+"VDB enable Job Polling failed. Error: "+job_err)
313313
}
314314
tflog.Info(ctx, DLPX+INFO+"Job result is "+job_res)
315315
if job_res == Failed || job_res == Canceled || job_res == Abandoned {
316-
tflog.Error(ctx, DLPX+ERROR+"Job "+job_res+" "+*apiRes.Job.Id+"!")
317-
return diag.Errorf("[NOT OK] Job %s %s with error %s", *apiRes.Job.Id, job_res, job_err)
316+
tflog.Error(ctx, DLPX+ERROR+"Job "+job_res+" "+apiRes.Job.GetId()+"!")
317+
return diag.Errorf("[NOT OK] Job %s %s with error %s", apiRes.Job.GetId(), job_res, job_err)
318318
}
319319
return nil
320320
}

0 commit comments

Comments
 (0)