fix for ESCL-4868 , defaulting wit_time to 0 to avoid drift

ankit-patil-hubs · ankit-patil-hubs · commit c359527714af · 2024-03-26T14:43:09.000+05:30
diff --git a/.goreleaser.yml b/.goreleaser.yml
@@ -1,7 +1,7 @@
 # Visit https://goreleaser.com for documentation on how to customize this
 # behavior.
 env:
-  - PROVIDER_VERSION=3.2.0
+  - PROVIDER_VERSION=3.2.1
 before:
   hooks:
     # this is just an example and not a requirement for provider building/publishing
diff --git a/GNUmakefile b/GNUmakefile
@@ -3,7 +3,7 @@ HOSTNAME=delphix.com
 NAMESPACE=dct
 NAME=delphix
 BINARY=terraform-provider-${NAME}
-VERSION=3.2.0
+VERSION=3.2.1
 OS_ARCH=darwin_amd64
 
 default: install
diff --git a/docs/resources/appdata_dsource.md b/docs/resources/appdata_dsource.md
@@ -183,4 +183,4 @@ resource "delphix_appdata_dsource" "dsource_name" {
 
 * `skip_wait_for_snapshot_creation` - (Optional) By default this resource will wait for a snapshot to be created post-dSource creation. This ensure a snapshot is available during the VDB provisioning. This behavior can be skipped by setting this parameter to `true`.
 
-* `wait_time` - (Optional) By default this resource waits 3 minutes for a snapshot to be created. Increase the integer value as needed for larger dSource snapshots. This parameter can be ignored if 'skip_wait_for_snapshot_creation' is set to `true`.
+* `wait_time` - (Optional) By default this resource waits 0 minutes for a snapshot to be created. Increase the integer value as needed for larger dSource snapshots. This parameter can be ignored if 'skip_wait_for_snapshot_creation' is set to `true`.
diff --git a/docs/resources/oracle_dsource.md b/docs/resources/oracle_dsource.md
@@ -197,4 +197,4 @@ resource "delphix_oracle_dsource" "test_oracle_dsource" {
 
 * `skip_wait_for_snapshot_creation` - (Optional) By default this resource will wait for a snapshot to be created post-dSource creation. This ensure a snapshot is available during the VDB provisioning. This behavior can be skipped by setting this parameter to `true`.
 
-* `wait_time` - (Optional) By default this resource waits 3 minutes for a snapshot to be created. Increase the integer value as needed for larger dSource snapshots. This parameter can be ignored if 'skip_wait_for_snapshot_creation' is set to `true`.
+* `wait_time` - (Optional) By default this resource waits 0 minutes for a snapshot to be created. Increase the integer value as needed for larger dSource snapshots. This parameter can be ignored if 'skip_wait_for_snapshot_creation' is set to `true`.
diff --git a/internal/provider/resource_appdata_dsource.go b/internal/provider/resource_appdata_dsource.go
@@ -329,7 +329,6 @@ func resourceAppdataDsource() *schema.Resource {
 			},
 			"wait_time": {
 				Type:     schema.TypeInt,
-				Default:  3,
 				Optional: true,
 			},
 			"skip_wait_for_snapshot_creation": {
@@ -558,6 +557,12 @@ func resourceDsourceUpdate(ctx context.Context, d *schema.ResourceData, meta int
 		d.Set(key, old)
 	}
 
+	//if d.HasChanges("wait_time", "skip_wait_for_snapshot_creation") {
+	//	d.Set("wait_time", 3)
+	//	d.Set("skip_wait_for_snapshot_creation", false)
+	//	return diag.Diagnostics{}
+	//}
+
 	return diag.Errorf("Action update not implemented for resource : dSource")
 }
 
diff --git a/internal/provider/resource_oracle_dsource.go b/internal/provider/resource_oracle_dsource.go
@@ -533,7 +533,6 @@ func resourceOracleDsource() *schema.Resource {
 			},
 			"wait_time": {
 				Type:     schema.TypeInt,
-				Default:  3,
 				Optional: true,
 			},
 			"skip_wait_for_snapshot_creation": {

Original file line number	Diff line number	Diff line change
`@@ -183,4 +183,4 @@ resource "delphix_appdata_dsource" "dsource_name" {`
`183`	`183`
`184`	`184`	* `skip_wait_for_snapshot_creation` - (Optional) By default this resource will wait for a snapshot to be created post-dSource creation. This ensure a snapshot is available during the VDB provisioning. This behavior can be skipped by setting this parameter to `true`.
`185`	`185`
`186`		-* `wait_time` - (Optional) By default this resource waits 3 minutes for a snapshot to be created. Increase the integer value as needed for larger dSource snapshots. This parameter can be ignored if 'skip_wait_for_snapshot_creation' is set to `true`.
	`186`	+* `wait_time` - (Optional) By default this resource waits 0 minutes for a snapshot to be created. Increase the integer value as needed for larger dSource snapshots. This parameter can be ignored if 'skip_wait_for_snapshot_creation' is set to `true`.
Original file line number	Diff line number	Diff line change
`@@ -197,4 +197,4 @@ resource "delphix_oracle_dsource" "test_oracle_dsource" {`
`197`	`197`
`198`	`198`	* `skip_wait_for_snapshot_creation` - (Optional) By default this resource will wait for a snapshot to be created post-dSource creation. This ensure a snapshot is available during the VDB provisioning. This behavior can be skipped by setting this parameter to `true`.
`199`	`199`
`200`		-* `wait_time` - (Optional) By default this resource waits 3 minutes for a snapshot to be created. Increase the integer value as needed for larger dSource snapshots. This parameter can be ignored if 'skip_wait_for_snapshot_creation' is set to `true`.
	`200`	+* `wait_time` - (Optional) By default this resource waits 0 minutes for a snapshot to be created. Increase the integer value as needed for larger dSource snapshots. This parameter can be ignored if 'skip_wait_for_snapshot_creation' is set to `true`.