Refactor: Move method to base class.

The private ParentForm method of THiliterPrefsFrame was moved into
the TPrefsBaseFrame base class as a protected method because it is
needed by other TPrefsBaseFrame sub-classes.

Author: delphidabbler

Src/FrHiliterPrefs.pas

@@ -131,8 +131,6 @@   THiliterPrefsFrame = class(TPrefsBaseFrame)
     ///  highlighter element.</summary>
     ///  <remarks>This RTF is used to display elememt in preview pane.</remarks>
     function GenerateRTF: TRTF;
-    ///  <summary>Returns reference to form that hosts the frame.</summary>
-    function ParentForm: TForm;
   public
     ///  <summary>Constructs frame instance and initialises controls.</summary>
     ///  <param name="AOwner">TComponent [in] Component that owns the frame.
@@ -523,20 +521,6 @@ procedure THiliterPrefsFrame.miNamedStylesClick(Sender: TObject);
   UpdatePopupMenu;
 end;
 
-function THiliterPrefsFrame.ParentForm: TForm;
-var
-  ParentCtrl: TWinControl;  // reference to parent controls
-begin
-  // Loop through parent controls until form found or top level parent reached
-  ParentCtrl := Self.Parent;
-  while Assigned(ParentCtrl) and not (ParentCtrl is TForm) do
-    ParentCtrl := ParentCtrl.Parent;
-  if ParentCtrl is TForm then
-    Result := ParentCtrl as TForm
-  else
-    Result := nil;
-end;
-
 procedure THiliterPrefsFrame.PopulateElementsList;
 var
   ElemId: THiliteElement; // loops thru all highlighter elements

Src/FrPrefsBase.pas

@@ -41,6 +41,8 @@   TPrefsBaseFrame = class(TFrame)
   strict protected
     class function IsFlagSupported(const Flag: UInt64): Boolean; inline;
     class function ExtractFrameFlag(const Flag: UInt64): UInt32; inline;
+    ///  <summary>Returns reference to form that hosts the frame.</summary>
+    function ParentForm: TForm;
   public
     procedure SavePrefs(const Prefs: IPreferences); virtual;
       {Saves information user entered in frame. By default the method simply
@@ -90,7 +92,8 @@ implementation
 
 uses
   // Delphi
-  SysUtils;
+  SysUtils,
+  Controls;
 
 
 {$R *.dfm}
@@ -127,6 +130,20 @@ class function TPrefsBaseFrame.MakeFrameFlag(const Flag: UInt32): UInt64;
   Int64Rec(Result).Lo := Flag;
 end;
 
+function TPrefsBaseFrame.ParentForm: TForm;
+var
+  ParentCtrl: TWinControl;  // reference to parent controls
+begin
+  // Loop through parent controls until form found or top level parent reached
+  ParentCtrl := Self.Parent;
+  while Assigned(ParentCtrl) and not (ParentCtrl is TForm) do
+    ParentCtrl := ParentCtrl.Parent;
+  if ParentCtrl is TForm then
+    Result := ParentCtrl as TForm
+  else
+    Result := nil;
+end;
+
 procedure TPrefsBaseFrame.SavePrefs(const Prefs: IPreferences);
   {Saves information user entered in frame. By default the method simply calls
   Deactivate. May be overridden to save any custom data that doesn't use Prefs