Untangle "evals scripts" test

Author: mislav

test/evaled.js

@@ -1,5 +1 @@
-window.evaledSrcScriptNum = window.evaledSrcScriptNum || 0
-window.evaledSrcScriptNum++
-
-if (window.evaledSrcScriptNum === 2)
-  window.evaledScriptLoaded()
+window.externalScriptLoaded()

test/unit/pjax.js

@@ -76,36 +76,35 @@ if ($.support.pjax) {
     })
   })
 
-  asyncTest("evals scripts", function() {
-    var frame = this.frame
+  asyncTest("evals scripts", 7, function() {
+    var externalLoadedCount = 0
+    this.frame.externalScriptLoaded = function() {
+      externalLoadedCount++
+    }
 
-    frame.evaledScriptLoaded = function() {
-      equal(frame.evaledSrcScriptNum, 2)
+    navigate(this.frame)
+    .pjax({ url: "scripts.html?name=one", container: "#main" }, function(frame) {
       deepEqual(frame.evaledInlineLog, ["one"])
-
-      frame.$.pjax({
-        url: "scripts.html?name=two",
-        container: "#main"
+      equal(externalLoadedCount, 0)
+      return new PoorMansPromise(function(resolve) {
+        setTimeout(resolve, 100)
+      }).then(function() {
+        equal(externalLoadedCount, 2, "expected scripts to have loaded")
       })
-
-      frame.$("#main").one("pjax:end", function() {
-        deepEqual(frame.evaledInlineLog, ["one", "two"])
-
-        goBack(frame, function() {
-          deepEqual(frame.evaledInlineLog, ["one", "two", "one"])
-
-          goForward(frame, function() {
-            deepEqual(frame.evaledInlineLog, ["one", "two", "one", "two"])
-            equal(frame.evaledSrcScriptNum, 2)
-            start()
-          })
-        })
+    })
+    .pjax({ url: "scripts.html?name=two", container: "#main" }, function(frame) {
+      deepEqual(frame.evaledInlineLog, ["one", "two"])
+    })
+    .back(-1, function(frame) {
+      deepEqual(frame.evaledInlineLog, ["one", "two", "one"])
+    })
+    .back(+1, function(frame) {
+      deepEqual(frame.evaledInlineLog, ["one", "two", "one", "two"])
+      return new PoorMansPromise(function(resolve) {
+        setTimeout(resolve, 100)
+      }).then(function() {
+        equal(externalLoadedCount, 2, "expected no extra scripts to load")
       })
-    }
-
-    frame.$.pjax({
-      url: "scripts.html?name=one",
-      container: "#main"
     })
   })
 

test/views/scripts.erb

@@ -1,6 +1,6 @@
 <p>Got some script tags here</p>
-<script type="text/javascript" src="/test/evaled.js"></script>
-<script src="/test/evaled.js"></script>
+<script type="text/javascript" src="/test/evaled.js?1"></script>
+<script src="/test/evaled.js?2"></script>
 <script type="text/javascript">
   window.evaledInlineLog = window.evaledInlineLog || []
   window.evaledInlineLog.push('<%= params[:name] %>')