Keep hash in temporarily changed URL while the page is loading

If you navigate with pjax to `/foo.html#bar`, the URL bar will change to
`/foo.html` while the page is loading, but only add `#bar` when it's
finished. There's some debate about whether we should be changing the
URL at all while loading, because browsers don't seem to do it until the
page starts sending data back. However, while we're still changing the
URL, it's worth ensuring that at least that URL is complete.

Author: mislav

jquery.pjax.js

@@ -225,7 +225,9 @@ function pjax(options) {
       settings.timeout = 0
     }
 
-    options.requestUrl = stripInternalParams(parseURL(settings.url).href)
+    var url = parseURL(settings.url)
+    url.hash = hash
+    options.requestUrl = stripInternalParams(url.href)
   }
 
   options.complete = function(xhr, textStatus) {
@@ -567,8 +569,8 @@ function cloneContents(container) {
 // Returns String.
 function stripParam(url, name) {
   return url
-    .replace(new RegExp('[?&]' + name + '=[^&]*'), '')
-    .replace(/[?&]$/, '')
+    .replace(new RegExp('[?&]' + name + '=[^&#]*'), '')
+    .replace(/[?&]($|#)/, '\1')
     .replace(/[?&]/, '?')
 }
 

test/unit/pjax_fallback.js

@@ -123,6 +123,8 @@ asyncTest("scrolls to anchor at top page"+s, function() {
 
   this.loaded = function(frame) {
     setTimeout(function() {
+      equal(frame.location.pathname, "/anchor.html")
+      equal(frame.location.hash, "#top")
       equal(frame.window.scrollY, 8)
       start()
     }, 100)
@@ -132,6 +134,14 @@ asyncTest("scrolls to anchor at top page"+s, function() {
     url: "/anchor.html#top",
     container: "#main"
   })
+
+  if (disabled) {
+    equal(frame.location.pathname, "/home.html")
+    equal(frame.location.hash, "")
+  } else {
+    equal(frame.location.pathname, "/anchor.html")
+    equal(frame.location.hash, "#top")
+  }
 })
 
 asyncTest("empty anchor doesn't scroll page"+s, function() {