Skip to content

Commit e446c5b

Browse files
authored
fix: NaN rows in dataframe output renderer (#156)
* fix: NaN rows in dataframe output renderer * fix: types and nan * fix: coderabbits comments
1 parent 2cf42fd commit e446c5b

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/webviews/extension-side/dataframe/dataframeController.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ interface DataFrameObject {
4747
dtype: string;
4848
name: string;
4949
}[];
50-
preview_row_count: number;
50+
preview_row_count?: number;
5151
row_count: number;
5252
rows: Record<string, unknown>[];
5353
type: string;

src/webviews/webview-side/dataframe-renderer/DataframeRenderer.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ interface DataframeRendererProps {
3838
name: string;
3939
stats: ColumnStats;
4040
}[];
41-
preview_row_count: number;
41+
preview_row_count?: number;
4242
row_count: number;
4343
rows: {
4444
_deepnote_index_column: number;
@@ -75,7 +75,7 @@ export const DataframeRenderer = memo(function DataframeRenderer({
7575
const selectId = useMemo(() => generateUuid(), []);
7676

7777
const filteredColumns = data.columns.filter((column) => !column.name.startsWith('_deepnote_'));
78-
const numberOfRows = Math.min(data.row_count, data.preview_row_count);
78+
const numberOfRows = Number.isFinite(data.preview_row_count) ? data.preview_row_count : data.row_count;
7979
const numberOfColumns = filteredColumns.length;
8080

8181
const totalPages = Math.ceil(data.row_count / pageSize);

0 commit comments

Comments
 (0)