Skip to content

Commit c80091e

Browse files
tkislansaltenasl
andauthored
chore: Rename jupyter command prefix to deepnote (#172)
* chore: Rename jupyter command prefix to deepnote Signed-off-by: Tomas Kislan <tomas@kislan.sk> * Rename more jupyter related named views, commands, etc Signed-off-by: Tomas Kislan <tomas@kislan.sk> * Fix translation ids Signed-off-by: Tomas Kislan <tomas@kislan.sk> * fix: Update configuration references from 'jupyter' to 'deepnote' Signed-off-by: Tomas Kislan <tomas@kislan.sk> * fix: Add forgotten file Signed-off-by: Tomas Kislan <tomas@kislan.sk> * Resolve nitpicks Signed-off-by: Tomas Kislan <tomas@kislan.sk> * Fix typo Signed-off-by: Tomas Kislan <tomas@kislan.sk> --------- Signed-off-by: Tomas Kislan <tomas@kislan.sk> Co-authored-by: Lukas Šaltėnas <lukas.saltenas@gmail.com>
1 parent 31be353 commit c80091e

File tree

71 files changed

+1272
-1318
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

71 files changed

+1272
-1318
lines changed

.github/instructions/ipywidgets.instructions.md

Lines changed: 222 additions & 223 deletions
Large diffs are not rendered by default.

api/README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,5 @@ See [here](https://code.visualstudio.com/api/references/vscode-api#extensions) f
2020
import { extensions } from 'vscode';
2121
import type { JupyterAPI } from '@vscode/jupyter';
2222

23-
const jupyterApi = extensions.getExtension<JupyterAPI>('ms-jupyter.jupyter')?.exports;
23+
const jupyterApi = extensions.getExtension<JupyterAPI>('Deepnote.vscode-deepnote')?.exports;
2424
```
25-

build/preDebugWebTest.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ async function go() {
1212
if (!url) {
1313
const info = await startJupyter(true);
1414
url = info.url;
15-
fs.writeFileSync(path.join(__dirname, '..', 'temp', 'jupyter.pid'), info.server.pid.toString());
15+
fs.writeFileSync(path.join(__dirname, '..', 'temp', 'deepnote.pid'), info.server.pid.toString());
1616
} else {
1717
console.log('Jupyter server URL provided in env args, no need to start one');
1818
}
1919
const settingsJson = fs.readFileSync(settingsFile).toString();
20-
const edits = jsonc.modify(settingsJson, ['jupyter.DEBUG_JUPYTER_SERVER_URI'], url, {});
20+
const edits = jsonc.modify(settingsJson, ['deepnote.DEBUG_JUPYTER_SERVER_URI'], url, {});
2121
const updatedSettingsJson = jsonc.applyEdits(settingsJson, edits);
2222
fs.writeFileSync(settingsFile, updatedSettingsJson);
2323
process.exit(0);

package.json

Lines changed: 581 additions & 627 deletions
Large diffs are not rendered by default.

package.nls.json

Lines changed: 171 additions & 171 deletions
Large diffs are not rendered by default.

src/commands.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,12 @@ export interface ICommandNameArgumentTypeMapping {
4343
['workbench.extensions.search']: [string];
4444
['editor.action.formatDocument']: [];
4545
['editor.action.rename']: [];
46-
['jupyter.selectJupyterInterpreter']: [];
46+
['deepnote.selectJupyterInterpreter']: [];
4747
['dataScience.ClearUserProviderJupyterServerCache']: [];
48-
['jupyterViewVariables.focus']: [];
49-
['jupyter.selectLocalJupyterServer']: [] | [undefined | string];
50-
['workbench.action.openSettings']: ['jupyter.kernels.excludePythonEnvironments'];
51-
['jupyter.getUsedAzMLServerHandles']: [];
48+
['deepnoteViewVariables.focus']: [];
49+
['deepnote.selectLocalJupyterServer']: [] | [undefined | string];
50+
['workbench.action.openSettings']: ['deepnote.kernels.excludePythonEnvironments'];
51+
['deepnote.getUsedAzMLServerHandles']: [];
5252
[DSCommands.RunCurrentCell]: [];
5353
[DSCommands.RunCurrentCellAdvance]: [];
5454
[DSCommands.CreateNewInteractive]: [];
@@ -76,7 +76,7 @@ export interface ICommandNameArgumentTypeMapping {
7676
['notebook.cell.collapseCellOutput']: [];
7777
['notebook.cell.expandCellOutput']: [];
7878
['vscode.openWith']: [Uri, string];
79-
['jupyter.filterKernels']: [never];
79+
['deepnote.filterKernels']: [never];
8080
['workbench.action.quickOpen']: [string];
8181
['workbench.extensions.installExtension']: [
8282
Uri | 'ms-toolsai.jupyter' | 'ms-python.python',
@@ -85,9 +85,9 @@ export interface ICommandNameArgumentTypeMapping {
8585
['workbench.action.files.openFolder']: [];
8686
['workbench.action.openWorkspace']: [];
8787
['extension.open']: [string];
88-
['setContext']: [string, ContextKeyValue] | ['jupyter.vscode.channel', Channel];
89-
['jupyter.reloadVSCode']: [string];
90-
['jupyter.runInDedicatedExtensionHost']: [string];
88+
['setContext']: [string, ContextKeyValue] | ['deepnote.vscode.channel', Channel];
89+
['deepnote.reloadVSCode']: [string];
90+
['deepnote.runInDedicatedExtensionHost']: [string];
9191
['revealLine']: [{ lineNumber: number; at: 'top' | 'center' | 'bottom' }];
9292
['python._loadLanguageServerExtension']: {}[];
9393
['python.SelectAndInsertDebugConfiguration']: [TextDocument, Position, CancellationToken];

src/extension.common.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ export async function postActivateLegacy(context: IExtensionContext, serviceCont
172172
sendTelemetryEvent(Telemetry.ExperimentLoad, { duration });
173173

174174
// "initialize" "services"
175-
commands.executeCommand('setContext', 'jupyter.vscode.channel', getVSCodeChannel()).then(noop, noop);
175+
commands.executeCommand('setContext', 'deepnote.vscode.channel', getVSCodeChannel()).then(noop, noop);
176176

177177
// "activate" everything else
178178
serviceContainer.get<IExtensionActivationManager>(IExtensionActivationManager).activate();

src/extension.node.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -219,12 +219,12 @@ async function activateLegacy(
219219
const isDevMode =
220220
!isTestExecution() &&
221221
(context.extensionMode === ExtensionMode.Development ||
222-
workspace.getConfiguration('jupyter').get<boolean>('development', false));
222+
workspace.getConfiguration('deepnote').get<boolean>('development', false));
223223
serviceManager.addSingletonInstance<boolean>(IsDevMode, isDevMode);
224224
if (isDevMode) {
225-
commands.executeCommand('setContext', 'jupyter.development', true).then(noop, noop);
225+
commands.executeCommand('setContext', 'deepnote.development', true).then(noop, noop);
226226
}
227-
commands.executeCommand('setContext', 'jupyter.webExtension', false).then(noop, noop);
227+
commands.executeCommand('setContext', 'deepnote.webExtension', false).then(noop, noop);
228228

229229
// Set the logger home dir (we can compute this in a node app)
230230
setHomeDirectory(homedir());

src/extension.web.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -174,13 +174,13 @@ async function activateLegacy(
174174
// register "services"
175175
const isDevMode =
176176
context.extensionMode === ExtensionMode.Development ||
177-
workspace.getConfiguration('jupyter').get<boolean>('development', false);
177+
workspace.getConfiguration('deepnote').get<boolean>('development', false);
178178

179179
serviceManager.addSingletonInstance<boolean>(IsDevMode, isDevMode);
180180
if (isDevMode) {
181-
commands.executeCommand('setContext', 'jupyter.development', true).then(noop, noop);
181+
commands.executeCommand('setContext', 'deepnote.development', true).then(noop, noop);
182182
}
183-
commands.executeCommand('setContext', 'jupyter.webExtension', true).then(noop, noop);
183+
commands.executeCommand('setContext', 'deepnote.webExtension', true).then(noop, noop);
184184

185185
// Register the rest of the types (platform is first because it's needed by others)
186186
registerPlatformTypes(serviceManager);

src/interactive-window/commands/commandRegistry.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -533,7 +533,7 @@ export class CommandRegistry implements IDisposable, IExtensionSyncActivationSer
533533
private async openVariableView(): Promise<void> {
534534
// For all contributed views vscode creates a command with the format [view ID].focus to focus that view
535535
// It's the given way to focus a single view so using that here, note that it needs to match the view ID
536-
return commands.executeCommand('jupyterViewVariables.focus');
536+
return commands.executeCommand('deepnoteViewVariables.focus');
537537
}
538538

539539
// Open the VS Code outline view

0 commit comments

Comments
 (0)