Only suggest FROM clause tables after SELECT

Only suggest tables and aliases that are in the FROM clause after SELECT keyword, instead of all tables

Author: the21st

packages/server/src/complete/candidates/createAliasCandidates.ts

@@ -7,7 +7,9 @@ export function createAliasCandidates(
   token: string
 ): CompletionItem[] {
   return fromNodes
-    .map((fromNode) => fromNode.as)
+    .map(
+      (fromNode) => fromNode.as ?? ('table' in fromNode ? fromNode.table : null)
+    )
     .filter((aliasName) => aliasName && aliasName.startsWith(token))
     .map((aliasName) => toCompletionItemForAlias(aliasName || ''))
 }

packages/server/src/complete/complete.ts

@@ -327,7 +327,6 @@ class Completer {
         // Could be an alias or an unscoped column
         this.addCandidatesForUnscopedColumns(fromNodes, schemaAndSubqueries)
         this.addCandidatesForAliases(fromNodes)
-        this.addCandidatesForTables(schemaAndSubqueries, true)
         this.addCandidatesForFunctions()
       }
     }