Skip to content

Commit a708d06

Browse files
hc2pchudyandrej
authored andcommitted
Be strict about defining docker context
* otherwise it gets confusing which file we ADD or COPY from where
1 parent 2dec0a7 commit a708d06

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

.circleci/config.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ jobs:
6060
--provenance=false \
6161
--sbom=false \
6262
--output type=registry,push=true \
63-
.
63+
./python/base
6464
6565
build-and-push-python:
6666
machine:
@@ -96,7 +96,7 @@ jobs:
9696
--provenance=false \
9797
--sbom=false \
9898
--output type=registry,push=true \
99-
.
99+
./python/python
100100
101101
build-and-push-python-datascience:
102102
machine:
@@ -166,7 +166,7 @@ jobs:
166166
--provenance=false \
167167
--sbom=false \
168168
--output type=registry,push=true \
169-
.
169+
./python/conda
170170
171171
build-and-push-ir:
172172
executor: docker/docker
@@ -238,7 +238,7 @@ jobs:
238238
--provenance=false \
239239
--sbom=false \
240240
--output type=registry,push=true \
241-
.
241+
./gpu
242242
243243
python-versions: &python-versions
244244
- "3.8.19"

gpu/Dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,17 @@ RUN apt-get update && apt-get -y dist-upgrade \
2323
gnupg2 \
2424
&& rm -rf /var/lib/apt/lists/*
2525

26-
# replace python version (optional) and
26+
# replace python version (optional) and
2727
# create the virtual environment in the home directory in the Dockerfile
2828
# for performance improvement.
2929
ARG PYTHON_VER
3030
ARG TF_VERSION
31-
ADD ./gpu/setup.python.sh /tmp/setup.python.sh
31+
ADD ./setup.python.sh /tmp/setup.python.sh
3232
RUN bash /tmp/setup.python.sh ${PYTHON_VER} ${TF_VERSION}; rm -v /tmp/setup.python.sh
3333

3434
# setup cuda for tensorflow
3535
ARG CUDA_IMAGE_TAG
36-
ADD ./gpu/setup.cuda.sh /tmp/setup.cuda.sh
36+
ADD ./setup.cuda.sh /tmp/setup.cuda.sh
3737
RUN bash /tmp/setup.cuda.sh ${CUDA_IMAGE_TAG}; rm -v /tmp/setup.cuda.sh
3838

3939
ENV DEEPNOTE_PYTHON_KERNEL_ONLY=true

0 commit comments

Comments
 (0)