Inspected all the script execution errors to confirm which ones are expected and to fix those that were not.

Signed-off-by: Dean Wampler <dean.wampler@ibm.com>

Author: deanwampler

check-scripts.sh

@@ -3,30 +3,48 @@
 default_dirs=( "src/script/scala" )
 out_root="target/script-tests"
 out_ext="out"
+timestamp=$(date +"%Y-%m-%d_%H-%M-%S")
 expected_errors_in=(
-  src/script/scala/progscala3/appdesign/Deprecated.scala
-  src/script/scala/progscala3/patternmatching/MatchExhaustive.scala
-  src/script/scala/progscala3/patternmatching/MatchSurprise.scala
+
   src/script/scala/progscala3/IndentationSyntax.scala
-  src/script/scala/progscala3/contexts/typeclass/TypeClassSubtypingProblems.scala
+  src/script/scala/progscala3/appdesign/Deprecated.scala
+  src/script/scala/progscala3/basicoop/MatchableOpaque.scala
+  src/script/scala/progscala3/collections/MultiMap.scala
+  src/script/scala/progscala3/contexts/ImplicitEvidence.scala
+  src/script/scala/progscala3/contexts/ImplicitNotFound.scala
+  src/script/scala/progscala3/contexts/MatchGivens.scala
   src/script/scala/progscala3/contexts/SeqUnzip.scala
-  src/script/scala/progscala3/meta/inline/Recursive.scala
-  src/script/scala/progscala3/meta/inline/Overrides.scala
+  src/script/scala/progscala3/dynamic/SelectableSQL.scala
   src/script/scala/progscala3/meta/compiletime/RequireConst.scala
   src/script/scala/progscala3/meta/compiletime/SummonAll.scala
-  src/script/scala/progscala3/rounding/TypeErasureProblem.scala
+  src/script/scala/progscala3/meta/inline/ConditionalMatch.scala
+  src/script/scala/progscala3/meta/inline/Overrides.scala
+  src/script/scala/progscala3/meta/inline/Recursive.scala
+  src/script/scala/progscala3/objectsystem/variance/MutableVariance.scala
+  src/script/scala/progscala3/patternmatching/Matchable.scala
+  src/script/scala/progscala3/patternmatching/MatchExhaustive.scala
+  src/script/scala/progscala3/patternmatching/MatchForFiltering.scala
+  src/script/scala/progscala3/patternmatching/MatchSurprise.scala
+  src/script/scala/progscala3/patternmatching/MatchTypesErasure.scala
+  src/script/scala/progscala3/patternmatching/UnapplySingleValue2.scala
   src/script/scala/progscala3/rounding/InfixMethod.scala
+  src/script/scala/progscala3/rounding/InfixType.scala
+  src/script/scala/progscala3/rounding/TypeErasureProblem.scala
   src/script/scala/progscala3/typelessdomore/Human.scala
-  src/script/scala/progscala3/typelessdomore/RepeatedParameters.scala
   src/script/scala/progscala3/typelessdomore/MethodBroadInference.scala
-  src/script/scala/progscala3/typelessdomore/MethodRecursiveReturn.scala
   src/script/scala/progscala3/typelessdomore/MethodNestedReturn.scala
-  src/script/scala/progscala3/basicoop/MatchableOpaque.scala
+  src/script/scala/progscala3/typelessdomore/MethodRecursiveReturn.scala
+  src/script/scala/progscala3/typelessdomore/RepeatedParameters.scala
+  src/script/scala/progscala3/typesystem/bounds/ViewToContextBounds.scala
+  src/script/scala/progscala3/typesystem/deptypes/DependentTypes.scala
+  src/script/scala/progscala3/typesystem/deptypes/DependentTypesBounds.scala
+  src/script/scala/progscala3/typesystem/deptypes/DependentTypesSimple.scala
+  src/script/scala/progscala3/typesystem/intersectionunion/Intersection.scala
+  src/script/scala/progscala3/typesystem/intersectionunion/Union.scala
+  src/script/scala/progscala3/typesystem/matchtypes/MatchTypes2.scala
   src/script/scala/progscala3/typesystem/typepaths/TypePath.scala
   src/script/scala/progscala3/typesystem/valuetypes/SingletonTypes.scala
-  src/script/scala/progscala3/patternmatching/MatchTypesErasure.scala
-  src/script/scala/progscala3/patternmatching/MatchForFiltering.scala
-  src/script/scala/progscala3/collections/MultiMap.scala
+  src/script/scala/progscala3/typesystem/valuetypes/TypeProjection.scala
 )
 
 error() {
@@ -46,18 +64,19 @@ are files with @main methods under src/main that can be interpreted as Scala 3
 argument.
 
 So, this bash script starts the REPL (using "sbt console") for each file and then
-uses :load to load the file. The output is written to
+uses :load to load the file. The output for that console sessions is written to
 $out_root/path/to/file.$out_ext.
 
+A list of files with errors or warnings is written to $out_root/errors-$timestamp.log.
+
 The following files are known to throw errors intentionally:
 $(for f in ${expected_errors_in[@]}; do echo "  $f"; done)
 
-Failures for these known files are ignored. In some of them, you'll see a comment
-on the same line, like "// ERROR" or "// COMPILATION ERROR", which are easier to
-spot when looking at error messages. In other cases, you have to look at the book
-discussion to see if the error is expected. Unfortunately, this means that any 
-unexpected errors in these files will be missed, unless you inspect the output
-when running them!
+Failures for these known files are ignored, but logged in $out_root/errors-$timestamp.log. 
+In most of them, you'll see a comment on the same line, like "// ERROR" or "// COMPILATION ERROR", 
+which are easier to spot when looking at error messages. In the rest of the cases, you have to
+look at the book discussion to see if the error is expected. Unfortunately, this means that any 
+unexpected errors in these files will be missed, unless you inspect the output carefully!
 
 For finding unexpected errors, the console output is searched for errors by looking
 for any of the following lines near the end (where N=2+):
@@ -67,7 +86,7 @@ N warnings found
 1 error found
 N errors found
 
-HOWEVER, to be really safe, all the outputs should still be inspected manually.
+** HOWEVER, to be really safe, all the outputs should still be inspected manually. **
 
 Usage: $0 [-h|--help] [-v|--verbose] [-c|--clean] [-n|--no-exec] [dir ...]
 Where:
@@ -128,44 +147,47 @@ then
   [[ -n "$out_root" ]] && rm -rf "$out_root"  # safety check!
 fi
 
+
+error_log="$out_root/errors-$timestamp.log"
+rm -f $error_log
+
+print_count() {
+  let count=$1; shift
+  file=$1; shift
+  out=$1; shift
+  message="$1"; shift
+  printf '%5d: %s %s %s\n' $count "$file" "$out" "$message" >> $error_log
+}
+
 count_problem() {
-  problem=$1
-  script=$2
-  out=$3
-  let count=$(grep -cE "^.+ $problem? found$" "$out" | sed -e "s/ $problem.*//")
-  case $count in
-    0)
-      # do nothing
-      ;;
-    1)
-      echo "ERROR: 1 ${problem} found in $script ($out)"
-      ;;
-    *)
-      echo "ERROR: $count ${problem}s found in $script ($out)"
-      ;;
-  esac
+  script=$1
+  out=$2
+  let count=$(grep -cE "^.+ (error|warning)s? found$" "$out")
+  [[ $count -gt 0 ]] && print_count $count $script $out 
   return $count
 }
 
 report() {
   let status=$1
   script=$2
   out=$3
+  for skip in ${expected_errors_in[@]}
+  do
+    if [[ "$skip" = "$script" ]]
+    then
+      print_count 0 "$script" "$out" "NOTE: because of known deliberate errors, unexpected errors might be missed!"
+      return 0
+    fi
+  done
   let error_count=0
   if [[ $status -ne 0 ]]
   then
     echo "ERROR: $script failed! ($out)"
     let error_count+=1
   fi
-  for skip in ${expected_errors_in[@]}
-  do
-    [[ "$skip" = "$script" ]] && return $error_count
-  done
-  count_problem 'warning' "$script" "$out"
-  let error_count+=$?
-  count_problem 'error'   "$script" "$out"
+  count_problem "$script" "$out"
   let error_count+=$?
-  $VERBOSE && cat "$out"
+  # $VERBOSE && cat "$out"
   return $error_count
 }
 
@@ -214,7 +236,8 @@ then
   rm -f "$problem_count"
   if [[ $total_problem_count -gt 0 ]]
   then
-    echo "ERROR: $total_problem_count issues found."
+    echo "ERROR: $total_problem_count issues found. See $error_log"
+    print_count $total_problem_count $error_log "" "issues found!"
     exit 1
   fi
 fi

src/script/scala/progscala3/IndentationSyntax.scala

@@ -52,7 +52,7 @@ end while
 // Match expression
 0 match
   case 0 => println("zero")
-  case _ => println("other value")
+  case _ => println("other value")  // ERROR: "Match case Unreachable Warning"
 end match
 
 // Partially-defined function

src/script/scala/progscala3/basicoop/DollarsPercentagesOpaque.scala

@@ -37,5 +37,5 @@ val gross = Dollars(10000.0)
 val taxes = Percentage(0.1)
 val salary1 = Salary(gross, taxes)
 val net1 = salary1.net
-val salary2 = Salary(taxes, gross)   // Won't compile!
+val salary2 = Salary(taxes, gross)   // ERROR Won't compile!
 // end::usage[]

src/script/scala/progscala3/basicoop/GoodBad.scala

@@ -2,12 +2,12 @@
 
 object OBad:
   def m(seq: Seq[Int]): String = seq.mkString("|")
-  def m(seq: Seq[String]): String = seq.mkString(",")
+  def m(seq: Seq[String]): String = seq.mkString(",")  // ERROR
 
 trait TGood:
   def member(suffix: String): String
   val member: String
 
 trait TBad:
   def member: String
-  val member: String
+  val member: String      // ERROR

src/script/scala/progscala3/basicoop/tagging/Tags.scala

@@ -14,5 +14,5 @@ val o: Ordering[Double] = implicitly
 val om: Ordering[Double @@ Meter] = o.tags
 om.compare(x, x)
 om.compare(x, y)  // Compilation Error!
-xs.min(om)
-xs.min(o)         // Compilation Error!
+xs.min(using om)
+xs.min(using o)   // Compilation Error!

src/script/scala/progscala3/basicoop/tagging/Tags2.scala

@@ -14,5 +14,5 @@ val o: Ordering[Double] = implicitly
 val om: Ordering[Double @@ Meter] = o.tags
 om.compare(x, x)
 om.compare(x, y)  // Compilation Error!
-xs.min(om)
-xs.min(o)         // Compilation Error!
+xs.min(using om)
+xs.min(using o)   // Compilation Error!

src/script/scala/progscala3/contexts/ExtensionMethodScoping.scala

@@ -5,7 +5,7 @@ val s = "Hello World!"
 trait T:
   extension (s: String) def LOUD: String = s.toUpperCase
 
-s.LOUD  // error; LOUD not in scope.
+s.LOUD  // ERROR; LOUD not in scope.
 
 object S2 extends T:
   def loud(s: String): String = s.LOUD
@@ -15,7 +15,7 @@ S2.loud(s)
 object S2:
   extension (s: String) def soft: String = s.toLowerCase
 
-s.soft
+s.soft  // ERROR; soft not in scope.
 
 import S2.soft
 s.soft

src/script/scala/progscala3/contexts/MatchGivens.scala

@@ -9,16 +9,16 @@ def useWitness(using Witness): String = summon[Witness].toString     // <2>
 // end::definitions[]
 
 // tag::usage[]
-useWitness                                                           // <1>
+useWitness       // ERROR                                            // <1>
 
 for given Witness <- Seq(IntWitness, StringWitness)                  // <2>
 do println(useWitness)
 
-useWitness                                                           // <3>
+useWitness       // ERROR                                            // <3>
 
 Seq(IntWitness -> "Int", StringWitness -> "String") foreach {        // <4>
   case (witness @ given Witness, y) => println(s"witness: $useWitness -> $y")
 }
 
-useWitness                                                           // <5>
+useWitness       // ERROR                                            // <5>
 // end::usage[]

src/script/scala/progscala3/contexts/UsingClauses.scala

@@ -3,13 +3,13 @@
 
 case class SortableSeq[A](seq: Seq[A]):
   def sortBy1a[B](transform: A => B)(using o: Ordering[B]): SortableSeq[A] =
-    SortableSeq(seq.sortBy(transform)(o))
+    SortableSeq(seq.sortBy(transform)(using o))
 
   def sortBy1b[B](transform: A => B)(using Ordering[B]): SortableSeq[A] =
-    SortableSeq(seq.sortBy(transform)(summon[Ordering[B]]))
+    SortableSeq(seq.sortBy(transform)(using summon[Ordering[B]]))
 
   def sortBy2[B : Ordering](transform: A => B): SortableSeq[A] =
-    SortableSeq(seq.sortBy(transform)(summon[Ordering[B]]))
+    SortableSeq(seq.sortBy(transform)(using summon[Ordering[B]]))
 // end::definitions[]
 
 // tag::defaultOrdering[]

src/script/scala/progscala3/meta/compiletime/SummonAll.scala

@@ -7,4 +7,4 @@ given c: C()
 given d: D()
 
 summonAll[C *: D *: EmptyTuple]
-summonAll[C *: D *: E *: EmptyTuple]                            // <1>
+summonAll[C *: D *: E *: EmptyTuple]  // ERROR                  // <1>