better title for QtWebKit dialogs

Author: ddmitov

CREDITS.md

@@ -13,7 +13,7 @@ Special thanks to the staff of the
 where much of the development effort took place!  
 
 Special thanks to Stack Overflow users peppe, Piotr Dobrogost and Fèlix Galindo Allué.  
-Their example code is no more used in Perl Executing Browser,  
+Their example code is no longer used in Perl Executing Browser,  
 but their expertise and good will to help others are not forgotten!
 
 Thanks to Jennifer Maher-Bontrager, author of the Camel icon.  
@@ -84,6 +84,7 @@ https://wiki.qt.io/Open_Web_Page_in_QWebView
 https://forum.qt.io/topic/18879/relative-path-on-qmake-pro-file  
 https://forum.qt.io/topic/551/get-filename-without-extension  
 https://forum.qt.io/topic/45982/solved-is-there-a-problem-with-the-following-non-blocking-sleep-function  
+https://forum.qt.io/topic/3314/qwebelement-set-and-get-attribute
 
 http://www.qtcentre.org/threads/25880-QWebView-prints-PDF-file-OK-with-QPrintDialog-only  
 http://www.qtcentre.org/threads/46016-Place-QMessageBox-on-middle-of-screen  

README.md

@@ -325,11 +325,12 @@ pebSettings.closeConfirmation =
 * **About Qt dialog:** ``about-qt.function``
 
 ## Specific Keyboard Shortcuts
-* <kbd>Ctrl</kbd> + <kbd>I</kbd> - start QWebInspector (QtWebKit builds only)
-* <kbd>Ctrl</kbd> + <kbd>P</kbd> - print (QtWebKit builds only)  
+All specific keyboard shortcuts are available only in the QtWebKit builds of PEB.
+* <kbd>Ctrl</kbd> + <kbd>I</kbd> - start QWebInspector
+* <kbd>Ctrl</kbd> + <kbd>P</kbd> - print  
   Printing is started after a native printer selection dialog is displayed.  
   If no printer is configured, no dialog is displayed and no action is taken.
-* <kbd>Ctrl</kbd> + <kbd>R</kbd> - get print preview (QtWebKit builds only)
+* <kbd>Ctrl</kbd> + <kbd>R</kbd> - get print preview
 
 ## What PEB Is Not
 * PEB is not a general purpose web browser and does not have all traditional features of general purpose web browsers.

resources/app/index.html

@@ -21,7 +21,7 @@
       pebSettings.noLabel = 'NO';
       pebSettings.closeConfirmation =
         'Text was entered in a form and it is going to be lost!\n' +
-        'Are you sure you want to close the window?';
+        'Are you sure you want to close the application?';
 
       // Settings objects for the Perl scripts:
       var interactive_one = {};

src/webkit-page.h

@@ -28,6 +28,7 @@
 #include <QRegularExpression>
 #include <QTimer>
 #include <QUrl>
+#include <QWebElement>
 #include <QWebFrame>
 #include <QWebPage>
 
@@ -51,20 +52,26 @@ public slots:
     {
         if (ok) {
             if (QPage::mainFrame()->url().scheme() == "file") {
-            // Inject all browser-specific Javascript:
-            QFileReader *resourceReader =
-                    new QFileReader(QString(":/peb.js"));
-            QString pebJavaScript = resourceReader->fileContents;
-
-            mainFrame()->evaluateJavaScript(pebJavaScript);
-
-            QVariant result =
-                    mainFrame()->
-                    evaluateJavaScript("peb.getPageSettings()");
-            qGetPageSettings(result);
-
-            // Send signal to the html-viewing class that a page is loaded:
-            emit pageLoadedSignal();
+                // Inject all browser-specific Javascript:
+                QFileReader *resourceReader =
+                        new QFileReader(QString(":/peb.js"));
+                QString pebJavaScript = resourceReader->fileContents;
+
+                mainFrame()->evaluateJavaScript(pebJavaScript);
+
+                // Start getting the page settings:
+                QVariant result = mainFrame()->
+                        evaluateJavaScript("peb.getPageSettings()");
+                qGetPageSettings(result);
+
+                // Get the title of the page for use in dialog boxes:
+                QWebElement titleDomElement =
+                        QPage::currentFrame()->documentElement()
+                        .findFirst("title");
+                title = titleDomElement.toInnerXml().toLatin1();
+
+                // Send signal to the html-viewing class that a page is loaded:
+                emit pageLoadedSignal();
             }
         }
     }
@@ -483,7 +490,7 @@ public slots:
 
         QMessageBox javaScriptAlertMessageBox (qApp->activeWindow());
         javaScriptAlertMessageBox.setWindowModality(Qt::WindowModal);
-        javaScriptAlertMessageBox.setWindowTitle("Alert");
+        javaScriptAlertMessageBox.setWindowTitle(title);
         javaScriptAlertMessageBox.setText(msg);
         javaScriptAlertMessageBox.setButtonText(QMessageBox::Ok, okLabel);
         javaScriptAlertMessageBox.setDefaultButton(QMessageBox::Ok);
@@ -499,10 +506,11 @@ public slots:
 
         QMessageBox javaScriptConfirmMessageBox (qApp->activeWindow());
         javaScriptConfirmMessageBox.setWindowModality(Qt::WindowModal);
-        javaScriptConfirmMessageBox.setWindowTitle("Confirm");
+        javaScriptConfirmMessageBox.setWindowTitle(title);
         javaScriptConfirmMessageBox.setText(msg);
         javaScriptConfirmMessageBox
                 .setStandardButtons(QMessageBox::Yes | QMessageBox::No);
+        javaScriptConfirmMessageBox.setDefaultButton(QMessageBox::No);
         javaScriptConfirmMessageBox.setButtonText(QMessageBox::Yes, yesLabel);
         javaScriptConfirmMessageBox.setButtonText(QMessageBox::No, noLabel);
         return QMessageBox::Yes == javaScriptConfirmMessageBox.exec();
@@ -522,7 +530,7 @@ public slots:
 
         QInputDialog dialog;
         dialog.setModal(true);
-        dialog.setWindowTitle("Prompt");
+        dialog.setWindowTitle(title);
         dialog.setLabelText(msg);
         dialog.setInputMode(QInputDialog::TextInput);
         dialog.setTextValue(defaultValue);
@@ -539,6 +547,8 @@ public slots:
     }
 
 private:
+    QString title;
+
     QString okLabel;
     QString cancelLabel;
     QString yesLabel;