better AppImage support

Author: ddmitov

CREDITS.md

@@ -217,6 +217,7 @@ https://stackoverflow.com/questions/4181703/how-to-concatenate-string-variables-
 https://stackoverflow.com/questions/638975/how-do-i-tell-if-a-regular-file-does-not-exist-in-bash  
 https://stackoverflow.com/questions/10319652/check-if-a-file-is-executable  
 https://stackoverflow.com/questions/10376206/what-is-the-preferred-bash-shebang  
+https://stackoverflow.com/questions/192249/how-do-i-parse-command-line-arguments-in-bash  
 
 https://unix.stackexchange.com/questions/312280/split-string-by-delimiter-and-get-n-th-element  
 https://unix.stackexchange.com/questions/12453/how-to-determine-linux-kernel-architecture  

doc/SETTINGS.md

@@ -108,7 +108,7 @@ Perl scripts running for a long time should have ``$|=1;`` among their first lin
 ## Interactive Perl Scripts
 Each PEB interactive Perl script must have its own event loop waiting constantly for new data on STDIN for a bidirectional connection with PEB. Many interactive scripts can be started simultaneously in one browser window. One script may be started in many instances, provided that it has a JavaScript settings object with a unique name. Interactive scripts must also have the ``scriptExitCommand`` object property. The ``scriptExitConfirmation`` object property is not mandatory, but highly recommended for a quick shutdown of PEB.  
 
-Please note that interactive Perl scripts are not supported by all Windows builds of PEB.  
+Please note that interactive Perl scripts are not supported on any Windows build of PEB.  
 
 Please also note that if a PEB instance crashes, it will leave its interactive scripts as zombie processes and they will start consuming large amounts of memory! Exhaustive stability testing has to be done when interactive scripts are selected for use with PEB! Even during normal operation interactive scripts use more memory than non-interactive scripts and their use should be carefully considered.
 

sdk/appimage-maker.sh

@@ -24,21 +24,29 @@ else
 fi
 
 cp ./sdk/peb.desktop ./peb.app/peb.desktop
-cp ./resources/app.png ./peb.app/peb.png
+cp ./sdk/camel.png ./peb.app/peb.png
 mkdir -p ./peb.app/usr/share
 cp ./sdk/metainfo ./peb.app/usr/share/metainfo
 
-cp -rf ./resources ./peb.app/resources
-
-relocatable_perl="$(pwd)/perl/bin/perl"
-compactor_script="$(pwd)/sdk/compactor.pl"
-
-if [ -e "$relocatable_perl" ]; then
-  printf "\\nGoing to compact the relocatable Perl for this copy of Perl Executing Browser.\\n"
-  "$relocatable_perl" "$compactor_script" "--AppImage"
-else
-  printf "\\nRelocatable Perl is not found for this copy of Perl Executing Browser.\\n"
-fi
+for i in "$@"
+  do
+  case $i in
+    --include-resources)
+      cp -rf ./resources ./peb.app/resources
+      cp ./resources/app.png ./peb.app/peb.png
+
+      relocatable_perl="$(pwd)/perl/bin/perl"
+      compactor_script="$(pwd)/sdk/compactor.pl"
+
+      if [ -e "$relocatable_perl" ]; then
+        printf "\\nGoing to compact the relocatable Perl for this copy of Perl Executing Browser.\\n"
+        "$relocatable_perl" "$compactor_script" "--AppImage"
+      else
+        printf "\\nRelocatable Perl is not found for this copy of Perl Executing Browser.\\n"
+      fi
+    ;;
+  esac
+done
 
 linuxdeployqt="linuxdeployqt-continuous-$(arch).AppImage"
 

sdk/camel.png

@@ -132,9 +132,9 @@ int main(int argc, char **argv)
     QString perlDirectory = browserDirectory + "/perl";
 
 #ifdef Q_OS_LINUX
-    // Embedded in an AppImage 'perl' directory
-    // takes precedence over external 'perl' directory:
-    if (QDir(appImageDirectory + "/perl").exists()) {
+    // External 'perl' directory, if any,
+    // takes precedence over embedded in an AppImage 'perl' directory:
+    if (appImageDirectory.length() > 0) {
         perlDirectory = appImageDirectory + "/perl";
     }
 #endif
@@ -180,9 +180,9 @@ int main(int argc, char **argv)
     QString resourcesDirectory = browserDirectory + "/resources";
 
 #ifdef Q_OS_LINUX
-    // Embedded in an AppImage 'resources' directory
-    // takes precedence over external 'resources' directory:
-    if (QDir(appImageDirectory + "/resources").exists()) {
+    // External 'resources' directory, if any,
+    // takes precedence over embedded in an AppImage 'resources' directory:
+    if (appImageDirectory.length() > 0) {
         resourcesDirectory = appImageDirectory + "/resources";
     }
 #endif