Merge branch 'develop' of https://github.com/dbsystel/DBNetworkStack into feature/remove-deprecated-code

Author: lightsprint09

Source/URLRequest+Init.swift

@@ -31,7 +31,7 @@ extension URLRequest {
     ///   - path: path to the resource.
     ///   - baseURL: the base url of the resource.
     ///   - HTTPMethod: the HTTP method for the request. Defaults to `.GET`
-    ///   - parameters: url parameters for the request. Defaults to `nil`
+    ///   - parameters: url parameters for the request. Defaults to empty dictionary
     ///   - body: body data payload. Defaults to `nil`
     ///   - allHTTPHeaderFields: HTTP request header fields. Defaults to `nil`
     ///
@@ -44,7 +44,7 @@ extension URLRequest {
         }
 
         let urlWithParameters: URL
-        if let parameters = parameters {
+        if let parameters = parameters, !parameters.isEmpty {
             urlWithParameters = url.appending(queryParameters: parameters)
         } else {
             urlWithParameters = url

Tests/DBNetworkStackTests/URLRequestConvertibleTest.swift

@@ -68,4 +68,19 @@ class URLRequestConvertibleTest: XCTestCase {
         XCTAssert(query?.contains(where: { $0.name == "query" && $0.value == "2" }) ?? false)
     }
 
+    func testNoTrailingQuestionmarkInRequestURL() {
+        //Given
+        let path = "http://bahn.de/train"
+
+        //When
+        let request = URLRequest(path: path, baseURL: .defaultMock, parameters: [:])
+
+        //Then
+        if let contains = request.url?.absoluteString.contains("?") {
+            XCTAssertFalse(contains)
+        } else {
+            XCTFail("request seem to have no url")
+        }
+    }
+
 }