Skip to content

Conversation

@jeroensak
Copy link

add requestAnimationFrame to optimize smooth animations. Also fallback for browsers without support.

add requestAnimationFrame to optimize smooth animations. Also fallback for browsers without support.
@dbramwell
Copy link
Owner

Hi,

Thanks for the pull request. I might be missing something, as I hadn't heard of requestAnimationFrame before now, but I'm not sure that this is how it's supposed to be used. From the documentation I think it's supposed to be used to actually change the style of an element, similar to this example. React-animate-on-scroll uses CSS animations, so it doesn't work in the same way. I'm very possibly missing something though. Could you explain how the 'requestAnimationFrame' function helps?

Also, the tests seem to have broken, these would need to be fixed before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants