Skip to content

Commit 9d497bd

Browse files
committed
cleanup: remove commented TODO in Go function and tidy up test code by removing unnecessary line
1 parent d28b3c6 commit 9d497bd

File tree

2 files changed

+0
-3
lines changed

2 files changed

+0
-3
lines changed

dbos/workflow.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1303,8 +1303,6 @@ func (c *dbosContext) Go(ctx DBOSContext, fn StepFunc, opts ...StepOption) (chan
13031303
}
13041304
}()
13051305

1306-
// TODO: do I need to close the channel here?
1307-
13081306
return result, nil
13091307
}
13101308

dbos/workflows_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -951,7 +951,6 @@ func TestGoRunningStepsInsideGoRoutines(t *testing.T) {
951951
handle, err := RunWorkflow(dbosCtx, goWorkflow, "test-input")
952952
require.NoError(t, err, "failed to run go workflow")
953953
_, err = handle.GetResult()
954-
955954
close(results)
956955
close(errors)
957956
require.NoError(t, err, "failed to get result from go workflow")

0 commit comments

Comments
 (0)