Skip to content

Commit 573a17b

Browse files
af-mdmaxdml
authored andcommitted
cleanup: remove commented TODO in Go function and tidy up test code by removing unnecessary line
1 parent 346bdc0 commit 573a17b

File tree

2 files changed

+0
-3
lines changed

2 files changed

+0
-3
lines changed

dbos/workflow.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1352,8 +1352,6 @@ func (c *dbosContext) Go(ctx DBOSContext, fn StepFunc, opts ...StepOption) (chan
13521352
}
13531353
}()
13541354

1355-
// TODO: do I need to close the channel here?
1356-
13571355
return result, nil
13581356
}
13591357

dbos/workflows_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -956,7 +956,6 @@ func TestGoRunningStepsInsideGoRoutines(t *testing.T) {
956956
handle, err := RunWorkflow(dbosCtx, goWorkflow, "test-input")
957957
require.NoError(t, err, "failed to run go workflow")
958958
_, err = handle.GetResult()
959-
960959
close(results)
961960
close(errors)
962961
require.NoError(t, err, "failed to get result from go workflow")

0 commit comments

Comments
 (0)