From 50ed89f88c44fbb7e4aafa980cb32a64e5bef1d6 Mon Sep 17 00:00:00 2001 From: timgrohmann Date: Tue, 2 Sep 2025 17:07:43 +0200 Subject: [PATCH 1/2] feat: !4893 Allow More Flexibility in DBTabs Children --- .../components/src/components/tabs/tabs.scss | 25 +++---------------- 1 file changed, 4 insertions(+), 21 deletions(-) diff --git a/packages/components/src/components/tabs/tabs.scss b/packages/components/src/components/tabs/tabs.scss index d5579d1c0209..c0e960246872 100644 --- a/packages/components/src/components/tabs/tabs.scss +++ b/packages/components/src/components/tabs/tabs.scss @@ -5,20 +5,6 @@ $max-tabs: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10]; -%angular-workaround { - db-tab-list, - dbtablist { - @each $index in $max-tabs { - &:has([id$="-tab-#{$index}"]:checked) { - ~ dbtabpanel > [id$="-tab-panel-#{$index}"], - ~ db-tab-panel > [id$="-tab-panel-#{$index}"] { - display: block; - } - } - } - } -} - %horizontal-pulse { .db-tab-item { @include db-puls.set-db-puls-horizontal; @@ -73,8 +59,6 @@ $max-tabs: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10]; $db-tabs-z-index-button-background: 21; $db-tabs-z-index-button: 22; - @extend %angular-workaround; - display: flex; inline-size: 100%; position: relative; @@ -86,12 +70,11 @@ $max-tabs: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10]; .db-tab-list { max-inline-size: 100%; z-index: $db-tabs-z-index-tab-list; + } - @each $index in $max-tabs { - &:has([id$="-tab-#{$index}"]:checked) - ~ [id$="-tab-panel-#{$index}"] { - display: block; - } + @each $index in $max-tabs { + &:has([id$="-tab-#{$index}"]:checked) [id$="-tab-panel-#{$index}"] { + display: block; } } From f26b8c11876a03f65bf6cd84bf0759e496e44cfc Mon Sep 17 00:00:00 2001 From: Maximilian Franzke <787658+mfranzke@users.noreply.github.com> Date: Sat, 6 Sep 2025 10:09:19 +0200 Subject: [PATCH 2/2] Refactor snapshot regeneration conditions in workflow let's try out https://github.com/db-ux-design-system/core-web/pull/4895 in this one. --- .github/workflows/default.yml | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/.github/workflows/default.yml b/.github/workflows/default.yml index 7f8dca4734b4..0ccd70d4a417 100644 --- a/.github/workflows/default.yml +++ b/.github/workflows/default.yml @@ -191,12 +191,9 @@ jobs: regenerate-snapshots: if: | - needs.test-showcase-angular.outputs.aria-snapshots-changed == 'true' || - needs.test-showcase-angular.outputs.visual-snapshots-changed == 'true' || - needs.test-showcase-react.outputs.aria-snapshots-changed == 'true' || - needs.test-showcase-react.outputs.visual-snapshots-changed == 'true' || - needs.test-showcase-vue.outputs.aria-snapshots-changed == 'true' || - needs.test-showcase-vue.outputs.visual-snapshots-changed == 'true' + needs.test-showcase-angular.result == 'failure' || + needs.test-showcase-react.result == 'failure' || + needs.test-showcase-vue.result == 'failure' uses: ./.github/workflows/02-e2e-regenerate.yml with: version: ${{ needs.get-playwright-version.outputs.version }} @@ -212,7 +209,11 @@ jobs: commit-regenerated-snapshots: uses: ./.github/workflows/02-e2e-regenerated-snapshots-commit.yml secrets: inherit - if: always() + if: | + needs.regenerate-snapshots-components.result == 'success' || + needs.regenerate-snapshots-foundations.result == 'success' || + needs.regenerate-snapshots-patternhub.result == 'success' || + needs.regenerate-snapshots.result == 'success' needs: [ regenerate-snapshots-components,