Skip to content

Commit cb83f96

Browse files
sarahbrnggithub-actions[bot]mfranzkenmergetleape
authored
refactor(notification): update grid layout for block link variant (#5257)
* refactor(notification): update grid layout for block link variant and fix typos in example names * auto update snapshots (#5260) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * auto update snapshots (#5278) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update packages/components/src/components/notification/notification.scss Co-authored-by: Nicolas Merget <104347736+nmerget@users.noreply.github.com> * Update packages/components/src/components/notification/notification.scss Co-authored-by: Nicolas Merget <104347736+nmerget@users.noreply.github.com> * Update packages/components/src/components/notification/notification.scss Co-authored-by: Nicolas Merget <104347736+nmerget@users.noreply.github.com> * Update packages/components/src/components/notification/notification.scss Co-authored-by: Nicolas Merget <104347736+nmerget@users.noreply.github.com> * auto update snapshots (#5284) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * feat: add grid layout support for inline link variant in notifications - Import notification-grid-layout-link-variant-inline module - Extend grid-layout-link-variant-inline in db-notification class - Improve notification layout handling for different link variants * refactor(notification): simplify grid layout selectors for overlay and link variants * Create kind-steaks-worry.md * Update .changeset/kind-steaks-worry.md Co-authored-by: Maximilian Franzke <787658+mfranzke@users.noreply.github.com> * docs: minor fixes in notification showcases (#5354) * docs: minor fixes in notification showcases - removed closeable button from all examples except the one for the closeable property/section - removed the timestamp from the example of the variant property/section - fixed the typo "Closable" to "Closeable" in all three examples sections at the end - added closeable property for all "Closeable" examples in all three examples sections at the end * auto update snapshots (#5355) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: screen-reader issue --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Nicolas Merget <nicolas.merget@deutschebahn.com> * fix: resolve notification styling and timestamp display issues - Fix duplicate img selector in notification.scss - Fix incorrect mixin name in overlay grid - Add missing showTimestamp property to showcase examples - Improve code organization and comments --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Maximilian Franzke <maximilian.franzke@deutschebahn.com> Co-authored-by: Nicolas Merget <104347736+nmerget@users.noreply.github.com> Co-authored-by: Maximilian Franzke <787658+mfranzke@users.noreply.github.com> Co-authored-by: Lea Perchermeier <6907841+leape@users.noreply.github.com> Co-authored-by: Nicolas Merget <nicolas.merget@deutschebahn.com>
1 parent e3c7ce7 commit cb83f96

File tree

23 files changed

+677
-367
lines changed

23 files changed

+677
-367
lines changed

‎.changeset/kind-steaks-worry.md‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
---
2+
"@db-ux/core-components": minor
3+
"@db-ux/ngx-core-components": minor
4+
"@db-ux/react-core-components": minor
5+
"@db-ux/v-core-components": minor
6+
"@db-ux/wc-core-components": minor
7+
---
8+
9+
refactor(notification): update and simplify grid layout for block link variant

‎__snapshots__/notification/patternhub/notification-overview-should-match-screenshot.png‎

-971 Bytes
Loading

‎__snapshots__/notification/showcase/chromium-highContrast/DBNotification-should-match-screenshot-1/DBNotification-should-match-screenshot.png‎

18.7 KB
Loading

‎__snapshots__/notification/showcase/chromium-highContrast/should-have-same-aria-snapshot/DBNotification-should-have-same-aria-snapshot.yaml‎

Lines changed: 26 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -4,54 +4,41 @@
44
- article:
55
- text: Headline
66
- paragraph: functional
7-
- button "Close"
87
- article:
98
- text: Headline
109
- paragraph: regular (Default)
11-
- button "Close"
1210
- article:
1311
- text: Headline
1412
- paragraph: expressive
15-
- button "Close"
1613
- link "Variant"
1714
- article:
1815
- text: Headline
1916
- paragraph: (Default) Docked
20-
- button "Close"
2117
- article:
2218
- text: Headline
2319
- paragraph: Standalone
24-
- button "Close"
2520
- article:
2621
- text: Headline
2722
- paragraph: Overlay
28-
- text: 10 min ago
29-
- button "Close"
3023
- link "Semantic"
3124
- article:
3225
- text: Headline
3326
- paragraph: (Default) Adaptive
34-
- button "Close"
3527
- article:
3628
- text: Headline
3729
- paragraph: Neutral
38-
- button "Close"
3930
- article:
4031
- text: Headline
4132
- paragraph: Critical
42-
- button "Close"
4333
- article:
4434
- text: Headline
4535
- paragraph: Informational
46-
- button "Close"
4736
- article:
4837
- text: Headline
4938
- paragraph: Successful
50-
- button "Close"
5139
- article:
5240
- text: Headline
5341
- paragraph: Warning
54-
- button "Close"
5542
- link "Closeable"
5643
- article:
5744
- paragraph: (Default) False
@@ -107,12 +94,14 @@
10794
- link "Textlink"
10895
- article:
10996
- text: Headline
110-
- paragraph: Text & Headline & Textlink Inline & Closable
97+
- paragraph: Text & Headline & Textlink Inline & Closeable
11198
- link "Textlink"
99+
- button "Close"
112100
- article:
113101
- text: Headline
114-
- paragraph: Text & Icon & Headline & Textlink Inline & Closable
102+
- paragraph: Text & Icon & Headline & Textlink Inline & Closeable
115103
- link "Textlink"
104+
- button "Close"
116105
- link "Examples - VariantStandalone":
117106
- article:
118107
- paragraph: Text
@@ -132,12 +121,14 @@
132121
- link "Textlink"
133122
- article:
134123
- text: Headline
135-
- paragraph: Text & Headline & Textlink Inline & Closable
124+
- paragraph: Text & Headline & Textlink Inline & Closeable
136125
- link "Textlink"
126+
- button "Close"
137127
- article:
138128
- text: Headline
139-
- paragraph: Text & Icon & Headline & Textlink Inline & Closable
129+
- paragraph: Text & Icon & Headline & Textlink Inline & Closeable
140130
- link "Textlink"
131+
- button "Close"
141132
- link "Examples - VariantOverlay":
142133
- article:
143134
- paragraph: Text
@@ -152,25 +143,37 @@
152143
- article:
153144
- paragraph: Text & Textlink Inline
154145
- link "Textlink"
146+
- article:
147+
- paragraph: Text & Textlink Block
148+
- link "Textlink"
149+
- article:
150+
- paragraph: Text & Textlink Block & Timed
151+
- text: 10 min ago
152+
- link "Textlink"
155153
- article:
156154
- text: Headline
157-
- paragraph: Text & Headline & Textlink Inline & Closable
155+
- paragraph: Text & Headline & Textlink Inline & Closeable
158156
- link "Textlink"
157+
- button "Close"
159158
- article:
160159
- text: Headline
161-
- paragraph: Text & Icon & Headline & Textlink Inline & Closable
160+
- paragraph: Text & Icon & Headline & Textlink Inline & Closeable
162161
- link "Textlink"
162+
- button "Close"
163163
- article:
164164
- paragraph: Text & Timed
165165
- text: 10 min ago
166166
- article:
167-
- paragraph: Text & Timed & Closable
167+
- paragraph: Text & Timed & Closeable
168168
- text: 10 min ago
169+
- button "Close"
169170
- article:
170171
- text: Headline
171-
- paragraph: Text & Headline & Timed & Closable
172+
- paragraph: Text & Headline & Timed & Closeable
172173
- text: 10 min ago
174+
- button "Close"
173175
- article:
174176
- text: Headline
175-
- paragraph: Text & Icon & Headline & Timed & Closable
176-
- text: 10 min ago
177+
- paragraph: Text & Icon & Headline & Timed & Closeable
178+
- text: 10 min ago
179+
- button "Close"

‎__snapshots__/notification/showcase/chromium/DBNotification-should-match-screenshot-1/DBNotification-should-match-screenshot.png‎

17.9 KB
Loading

‎__snapshots__/notification/showcase/chromium/should-have-same-aria-snapshot/DBNotification-should-have-same-aria-snapshot.yaml‎

Lines changed: 26 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -4,54 +4,41 @@
44
- article:
55
- text: Headline
66
- paragraph: functional
7-
- button "Close"
87
- article:
98
- text: Headline
109
- paragraph: regular (Default)
11-
- button "Close"
1210
- article:
1311
- text: Headline
1412
- paragraph: expressive
15-
- button "Close"
1613
- link "Variant"
1714
- article:
1815
- text: Headline
1916
- paragraph: (Default) Docked
20-
- button "Close"
2117
- article:
2218
- text: Headline
2319
- paragraph: Standalone
24-
- button "Close"
2520
- article:
2621
- text: Headline
2722
- paragraph: Overlay
28-
- text: 10 min ago
29-
- button "Close"
3023
- link "Semantic"
3124
- article:
3225
- text: Headline
3326
- paragraph: (Default) Adaptive
34-
- button "Close"
3527
- article:
3628
- text: Headline
3729
- paragraph: Neutral
38-
- button "Close"
3930
- article:
4031
- text: Headline
4132
- paragraph: Critical
42-
- button "Close"
4333
- article:
4434
- text: Headline
4535
- paragraph: Informational
46-
- button "Close"
4736
- article:
4837
- text: Headline
4938
- paragraph: Successful
50-
- button "Close"
5139
- article:
5240
- text: Headline
5341
- paragraph: Warning
54-
- button "Close"
5542
- link "Closeable"
5643
- article:
5744
- paragraph: (Default) False
@@ -107,12 +94,14 @@
10794
- link "Textlink"
10895
- article:
10996
- text: Headline
110-
- paragraph: Text & Headline & Textlink Inline & Closable
97+
- paragraph: Text & Headline & Textlink Inline & Closeable
11198
- link "Textlink"
99+
- button "Close"
112100
- article:
113101
- text: Headline
114-
- paragraph: Text & Icon & Headline & Textlink Inline & Closable
102+
- paragraph: Text & Icon & Headline & Textlink Inline & Closeable
115103
- link "Textlink"
104+
- button "Close"
116105
- link "Examples - VariantStandalone":
117106
- article:
118107
- paragraph: Text
@@ -132,12 +121,14 @@
132121
- link "Textlink"
133122
- article:
134123
- text: Headline
135-
- paragraph: Text & Headline & Textlink Inline & Closable
124+
- paragraph: Text & Headline & Textlink Inline & Closeable
136125
- link "Textlink"
126+
- button "Close"
137127
- article:
138128
- text: Headline
139-
- paragraph: Text & Icon & Headline & Textlink Inline & Closable
129+
- paragraph: Text & Icon & Headline & Textlink Inline & Closeable
140130
- link "Textlink"
131+
- button "Close"
141132
- link "Examples - VariantOverlay":
142133
- article:
143134
- paragraph: Text
@@ -152,25 +143,37 @@
152143
- article:
153144
- paragraph: Text & Textlink Inline
154145
- link "Textlink"
146+
- article:
147+
- paragraph: Text & Textlink Block
148+
- link "Textlink"
149+
- article:
150+
- paragraph: Text & Textlink Block & Timed
151+
- text: 10 min ago
152+
- link "Textlink"
155153
- article:
156154
- text: Headline
157-
- paragraph: Text & Headline & Textlink Inline & Closable
155+
- paragraph: Text & Headline & Textlink Inline & Closeable
158156
- link "Textlink"
157+
- button "Close"
159158
- article:
160159
- text: Headline
161-
- paragraph: Text & Icon & Headline & Textlink Inline & Closable
160+
- paragraph: Text & Icon & Headline & Textlink Inline & Closeable
162161
- link "Textlink"
162+
- button "Close"
163163
- article:
164164
- paragraph: Text & Timed
165165
- text: 10 min ago
166166
- article:
167-
- paragraph: Text & Timed & Closable
167+
- paragraph: Text & Timed & Closeable
168168
- text: 10 min ago
169+
- button "Close"
169170
- article:
170171
- text: Headline
171-
- paragraph: Text & Headline & Timed & Closable
172+
- paragraph: Text & Headline & Timed & Closeable
172173
- text: 10 min ago
174+
- button "Close"
173175
- article:
174176
- text: Headline
175-
- paragraph: Text & Icon & Headline & Timed & Closable
176-
- text: 10 min ago
177+
- paragraph: Text & Icon & Headline & Timed & Closeable
178+
- text: 10 min ago
179+
- button "Close"

‎__snapshots__/notification/showcase/firefox/DBNotification-should-match-screenshot-1/DBNotification-should-match-screenshot.png‎

24.1 KB
Loading

0 commit comments

Comments
 (0)