Skip to content

Commit 966d5ad

Browse files
Copilotmfranzkenmerget
authored
refactor(Angular): updated to version 20 and renamed a Custom Select component property (#4772)
* Initial plan * Initial exploration: analyze current Angular 19 setup before updating to Angular 20 Co-authored-by: mfranzke <787658+mfranzke@users.noreply.github.com> * Update Angular dependencies from 19.x to 20.1.x and documentation Co-authored-by: mfranzke <787658+mfranzke@users.noreply.github.com> * fix: issue with aria list label * feat: added changeset * Update sour-flies-build.md * Add migration guide for version 3.x.x to 4.0.0 Document migration steps from version 3.x.x to 4.0.0, including property renaming and CLI automation. * Add migration config from v3.0.0 to v4.0.0 * Add has-changes.txt with DBCustomSelect component * Add no-change.txt with DBCustomSelect component * refactor: regenerated package lock file * Apply suggestion from @mfranzke * Apply suggestion from @mfranzke * fix: ignore test files for jscpd through configuration --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mfranzke <787658+mfranzke@users.noreply.github.com> Co-authored-by: Nicolas Merget <nicolas.merget@deutschebahn.com> Co-authored-by: Nicolas Merget <104347736+nmerget@users.noreply.github.com> Co-authored-by: Maximilian Franzke <maximilian.franzke@deutschebahn.com>
1 parent 68feaab commit 966d5ad

File tree

14 files changed

+3031
-2978
lines changed

14 files changed

+3031
-2978
lines changed

.changeset/sour-flies-build.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
---
2+
"@db-ux/core-components": major
3+
"angular-showcase": major
4+
"react-showcase": major
5+
"vue-showcase": major
6+
"@db-ux/docs": major
7+
---
8+
9+
**BREAKING CHANGE**: refactor(Custom Select): renamed `ariaListLabel` property to `listLabel`

.config/.jscpd.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@
4747
"packages/foundations/assets/icons/functional/fonts/**",
4848
"packages/foundations/assets/icons/fonts/**",
4949
"packages/foundations/dev",
50+
"packages/migration/test/**/has-changes.txt",
51+
"packages/migration/test/**/no-change.txt",
5052
"showcases/**/results/**",
5153
"showcases/angular-showcase/.angular/cache",
5254
"showcases/angular-showcase/.angular/cache/**",

docs/migration/v1.x.x-to-v2.0.0.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Additionally, we now use the `bg-vibrant` and `on-bg-vibrant` colors for the emp
77

88
## Angular
99

10-
> **Note:** We upgrade the components to use [`signals`](https://angular.dev/guide/signals). This requires the latest version of Angular (18.0.0 or higher). If you are using an older version, please upgrade to the latest versions (18 or 19) of Angular.
10+
> **Note:** We upgrade the components to use [`signals`](https://angular.dev/guide/signals). This requires the latest version of Angular (18.0.0 or higher). If you are using an older version, please upgrade to the latest versions (18, 19, or 20) of Angular.
1111
1212
### Align angular events
1313

docs/migration/v3.x.x-to-v4.0.0.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# Migration (3.x.x) ➡ 4.0.0
2+
3+
## Custom Select: renamed `ariaListLabel` property to `listLabel`
4+
5+
Due to Angular 20's handling of properties starting with the phrase "aria," we needed to rename the `ariaListLabel` property to `listLabel`.
6+
7+
## Automate migration via CLI
8+
9+
We provide a CLI tool to auto migrate your source code. Use this command in your repository:
10+
11+
```shell
12+
npx @db-ux/core-migration --type=v300_v400 --src=./src
13+
```
14+
15+
Please check the changes made in your codebase afterwards, as this is mainly a simple search & replace and there might be unexpected changes of similar wordings to our properties for any other methods, or further code occurrences that don't even refer to properties.

0 commit comments

Comments
 (0)