Skip to content

Commit 1b98832

Browse files
mfranzkemfranzke
authored
refactor reverted quick hacks (#5303)
* Revert "Refactor deployment workflow by removing storybook downloads" This reverts commit 2eebb2f. * Revert "Disable storybook build jobs in workflow" This reverts commit 05c773f. * Revert "fix: release pipeline as quick hack" This reverts commit 6994a24.
1 parent 2eebb2f commit 1b98832

File tree

3 files changed

+95
-52
lines changed

3 files changed

+95
-52
lines changed

‎.github/workflows/03-deploy-gh-pages.yml‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,38 @@ jobs:
4747
name: db-ux-patternhub
4848
path: build-showcases/patternhub
4949

50+
- name: ⏬ Download composition-storybook
51+
uses: actions/download-artifact@v5
52+
with:
53+
name: db-ux-composition-storybook
54+
path: build-storybooks/composition-storybook
55+
56+
- name: ⏬ Download angular-storybook
57+
uses: actions/download-artifact@v5
58+
with:
59+
name: db-ux-angular-storybook
60+
path: build-storybooks/angular-storybook
61+
62+
- name: ⏬ Download react-storybook
63+
uses: actions/download-artifact@v5
64+
with:
65+
name: db-ux-react-storybook
66+
path: build-storybooks/react-storybook
67+
68+
- name: ⏬ Download vue-storybook
69+
uses: actions/download-artifact@v5
70+
with:
71+
name: db-ux-vue-storybook
72+
path: build-storybooks/vue-storybook
73+
5074
- name: 🦵🦿 I like to move it move it
5175
shell: bash
5276
run: |
5377
mv build-showcases/patternhub out
78+
mv build-storybooks/composition-storybook out/composition-storybook
79+
mv build-storybooks/angular-storybook out/angular-storybook
80+
mv build-storybooks/react-storybook out/react-storybook
81+
mv build-storybooks/vue-storybook out/vue-storybook
5482
5583
- name: 🔨 Build page
5684
env:

‎.github/workflows/default.yml‎

Lines changed: 35 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -78,34 +78,33 @@ jobs:
7878
needs: [build-packages, init]
7979
with:
8080
version: ${{ needs.init.outputs.playwrightVersion }}
81-
82-
#build-storybook-composition:
83-
# uses: ./.github/workflows/01-build-storybooks.yml
84-
# needs: [build-packages, init]
85-
# with:
86-
# storybook: composition-storybook
87-
# baseUrl: ${{ needs.init.outputs.baseUrl }}
88-
89-
#build-storybook-angular:
90-
# uses: ./.github/workflows/01-build-storybooks.yml
91-
# needs: [build-packages, init]
92-
# with:
93-
# storybook: angular-storybook
94-
# baseUrl: ${{ needs.init.outputs.baseUrl }}
95-
96-
#build-storybook-react:
97-
# uses: ./.github/workflows/01-build-storybooks.yml
98-
# needs: [build-packages, init]
99-
# with:
100-
# storybook: react-storybook
101-
# baseUrl: ${{ needs.init.outputs.baseUrl }}
102-
103-
#build-storybook-vue:
104-
# uses: ./.github/workflows/01-build-storybooks.yml
105-
# needs: [build-packages, init]
106-
# with:
107-
# storybook: vue-storybook
108-
# baseUrl: ${{ needs.init.outputs.baseUrl }}
81+
build-storybook-composition:
82+
uses: ./.github/workflows/01-build-storybooks.yml
83+
needs: [build-packages, init]
84+
with:
85+
storybook: composition-storybook
86+
baseUrl: ${{ needs.init.outputs.baseUrl }}
87+
88+
build-storybook-angular:
89+
uses: ./.github/workflows/01-build-storybooks.yml
90+
needs: [build-packages, init]
91+
with:
92+
storybook: angular-storybook
93+
baseUrl: ${{ needs.init.outputs.baseUrl }}
94+
95+
build-storybook-react:
96+
uses: ./.github/workflows/01-build-storybooks.yml
97+
needs: [build-packages, init]
98+
with:
99+
storybook: react-storybook
100+
baseUrl: ${{ needs.init.outputs.baseUrl }}
101+
102+
build-storybook-vue:
103+
uses: ./.github/workflows/01-build-storybooks.yml
104+
needs: [build-packages, init]
105+
with:
106+
storybook: vue-storybook
107+
baseUrl: ${{ needs.init.outputs.baseUrl }}
109108

110109
build-showcase-stencil:
111110
uses: ./.github/workflows/01-build-showcases.yml
@@ -335,6 +334,10 @@ jobs:
335334
steps:
336335
- name: 🎉 Checks done
337336
run: |
337+
resultBuildStorybookComposition="${{ needs.build-storybook-composition.result }}"
338+
resultBuildStorybookAngular="${{ needs.build-storybook-angular.result }}"
339+
resultBuildStorybookReact="${{ needs.build-storybook-react.result }}"
340+
resultBuildStorybookVue="${{ needs.build-storybook-vue.result }}"
338341
resultBuildShowcaseStencil="${{ needs.build-showcase-stencil.result }}"
339342
resultBuildShowcaseAngular="${{ needs.build-showcase-angular.result }}"
340343
resultBuildShowcaseAngularSSR="${{ needs.build-showcase-angular-ssr.result }}"
@@ -381,6 +384,10 @@ jobs:
381384
fi
382385
needs:
383386
[
387+
build-storybook-composition,
388+
build-storybook-angular,
389+
build-storybook-react,
390+
build-storybook-vue,
384391
build-showcase-stencil,
385392
build-showcase-angular,
386393
build-showcase-angular-ssr,

‎.github/workflows/release.yml‎

Lines changed: 32 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -47,33 +47,33 @@ jobs:
4747
with:
4848
version: ${{ needs.init.outputs.playwrightVersion }}
4949

50-
# build-storybook-composition:
51-
# uses: ./.github/workflows/01-build-storybooks.yml
52-
# needs: [build-packages, init]
53-
# with:
54-
# storybook: storybook
55-
# baseUrl: ${{ needs.init.outputs.baseUrl }}
50+
build-storybook-composition:
51+
uses: ./.github/workflows/01-build-storybooks.yml
52+
needs: [build-packages, init]
53+
with:
54+
storybook: storybook
55+
baseUrl: ${{ needs.init.outputs.baseUrl }}
5656

57-
# build-storybook-angular:
58-
# uses: ./.github/workflows/01-build-storybooks.yml
59-
# needs: [build-packages, init]
60-
# with:
61-
# storybook: angular-storybook
62-
# baseUrl: ${{ needs.init.outputs.baseUrl }}
57+
build-storybook-angular:
58+
uses: ./.github/workflows/01-build-storybooks.yml
59+
needs: [build-packages, init]
60+
with:
61+
storybook: angular-storybook
62+
baseUrl: ${{ needs.init.outputs.baseUrl }}
6363

64-
# build-storybook-react:
65-
# uses: ./.github/workflows/01-build-storybooks.yml
66-
# needs: [build-packages, init]
67-
# with:
68-
# storybook: react-storybook
69-
# baseUrl: ${{ needs.init.outputs.baseUrl }}
64+
build-storybook-react:
65+
uses: ./.github/workflows/01-build-storybooks.yml
66+
needs: [build-packages, init]
67+
with:
68+
storybook: react-storybook
69+
baseUrl: ${{ needs.init.outputs.baseUrl }}
7070

71-
# build-storybook-vue:
72-
# uses: ./.github/workflows/01-build-storybooks.yml
73-
# needs: [build-packages, init]
74-
# with:
75-
# storybook: vue-storybook
76-
# baseUrl: ${{ needs.init.outputs.baseUrl }}
71+
build-storybook-vue:
72+
uses: ./.github/workflows/01-build-storybooks.yml
73+
needs: [build-packages, init]
74+
with:
75+
storybook: vue-storybook
76+
baseUrl: ${{ needs.init.outputs.baseUrl }}
7777

7878
build-showcase-stencil:
7979
uses: ./.github/workflows/01-build-showcases.yml
@@ -178,6 +178,10 @@ jobs:
178178
steps:
179179
- name: 🎉 Checks done
180180
run: |
181+
resultBuildStorybookComposition="${{ needs.build-storybook-composition.result }}"
182+
resultBuildStorybookAngular="${{ needs.build-storybook-angular.result }}"
183+
resultBuildStorybookReact="${{ needs.build-storybook-react.result }}"
184+
resultBuildStorybookVue="${{ needs.build-storybook-vue.result }}"
181185
resultBuildShowcaseStencil="${{ needs.build-showcase-stencil.result }}"
182186
resultBuildShowcaseAngular="${{ needs.build-showcase-angular.result }}"
183187
resultBuildShowcaseAngularSSR="${{ needs.build-showcase-angular-ssr.result }}"
@@ -224,6 +228,10 @@ jobs:
224228
fi
225229
needs:
226230
[
231+
build-storybook-composition,
232+
build-storybook-angular,
233+
build-storybook-react,
234+
build-storybook-vue,
227235
build-showcase-stencil,
228236
build-showcase-angular,
229237
build-showcase-angular-ssr,

0 commit comments

Comments
 (0)