Skip to content

Commit 5a48e1f

Browse files
authored
fix: svg icon issues with fill (#267)
* refactor: simplified icon filled declarations * refactor: simplified the logos fill styles as well * docs: adapted instructions to README * chore: added another necessary replaced color
1 parent 6e2bd5a commit 5a48e1f

File tree

1,191 files changed

+1197
-1193
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

1,191 files changed

+1197
-1193
lines changed

assets/icons/README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@ We're getting these icons by the [DB Design System colleagues](https://dbsw.shar
44

55
- Minifications with [`ImageOptim`](https://imageoptim.com/mac)
66
- Adding some contents within the SVGs (these assets might get exported correctly in the future)
7-
- CSS variables (replace `fill="#282D37"` by `fill="#282D37" style="fill: currentColor;fill: var(--db-icon-color, currentColor)"`)
7+
- CSS variables
8+
- replace `fill="#282D37"` by `fill="var(--db-icon-color, currentColor)"`
9+
- replace `fill="#55b9e6"` by `fill="var(--db-icon-color, #55b9e6)"`
10+
- replace `fill="#EC0016"` by `fill="var(--db-icon-pulse-color, #EC0016)"`
11+
- replace `fill="#78be14"` by `fill="var(--db-icon-pulse-color, #78be14)"`
812
- `id`-Attribute (generic `icon` id within all SVG files)
913
- Afterwards the JSON files within the `source/_patterns/icons` path might need to get updated
Lines changed: 1 addition & 1 deletion
Loading
Lines changed: 1 addition & 1 deletion
Loading
Lines changed: 1 addition & 1 deletion
Loading
Lines changed: 1 addition & 1 deletion
Loading
Lines changed: 1 addition & 1 deletion
Loading
Lines changed: 1 addition & 1 deletion
Loading
Lines changed: 1 addition & 1 deletion
Loading
Lines changed: 1 addition & 1 deletion
Loading
Lines changed: 1 addition & 1 deletion
Loading

0 commit comments

Comments
 (0)