fix: e2e test to get the list of urls to check from sitemap to avoid infinite looping through tests (#362)

Author: davidhu2000

cypress/e2e/links-and-images.cy.ts

@@ -1,7 +1,25 @@
 describe("links-and-images", () => {
   it("should return 200 for all links and images", () => {
-    const testedPages = new Set<string>();
-    const pagesToTest = ["/"];
+    const pagesToTest: string[] = [];
+
+    // First get all URLs from sitemap
+    cy.request("https://www.davidhu.io/sitemap-0.xml").then((response) => {
+      const parser = new DOMParser();
+      const xmlDoc = parser.parseFromString(response.body, "text/xml");
+      const urls = xmlDoc.getElementsByTagName("url");
+
+      for (let i = 0; i < urls.length; i++) {
+        const loc = urls[i].getElementsByTagName("loc")[0];
+        if (loc) {
+          const url = loc.textContent;
+          if (url) {
+            pagesToTest.push(url);
+          }
+        }
+      }
+
+      visitUrlsOnPage();
+    });
 
     function visitUrlsOnPage() {
       const url = pagesToTest.pop();
@@ -10,12 +28,6 @@ describe("links-and-images", () => {
         return;
       }
 
-      if (testedPages.has(url)) {
-        visitUrlsOnPage();
-        return;
-      }
-
-      testedPages.add(url);
       cy.visit(url);
       cy.log(">>>> Checking images for " + url);
 
@@ -35,42 +47,33 @@ describe("links-and-images", () => {
           cy.get("a")
             .should(Cypress._.noop)
             .each((link) => {
-              const url = (link.prop("href") as string) || "";
+              const urlString = (link.prop("href") as string) || "";
 
-              // these two links do not allow bot visits
-              if (url.includes("angel.co") || url.includes("linkedin.com")) {
+              const url = new URL(urlString);
+
+              // do not allow bot visits
+              if (url.host === "www.linkedin.com") {
                 return;
               }
 
-              if (url.includes("mailto:")) {
+              if (url.protocol === "mailto:") {
                 return;
               }
 
               // don't download any files
               if (
-                url.endsWith(".msi") ||
-                url.endsWith(".dmg") ||
-                url.endsWith(".AppImage") ||
-                url.endsWith(".deb")
+                url.href.endsWith(".msi") ||
+                url.href.endsWith(".dmg") ||
+                url.href.endsWith(".AppImage") ||
+                url.href.endsWith(".deb")
               ) {
                 return;
               }
 
-              cy.request(url);
-
-              if (url.includes(".xml")) {
-                return;
-              }
-
-              cy.log('>>>> Adding "' + url + '" to pages to test');
-              if (url.includes("davidhu.io/") && !testedPages.has(url)) {
-                pagesToTest.push(url);
-              }
+              cy.request(url.href);
             });
         })
         .then(visitUrlsOnPage);
     }
-
-    visitUrlsOnPage();
   });
 });

src/data/socialLinks.ts

@@ -14,9 +14,4 @@ export const socialLinks = [
     url: "https://twitter.com/notdavidhu",
     icon: "mdi:twitter",
   },
-  {
-    label: "AngelList",
-    url: "https://angel.co/davidhu2000",
-    icon: "fa-brands:angellist",
-  },
 ];