Added defaulting on helpers

Author: davellanedam

app/controllers/auth/helpers/blockIsExpired.js

@@ -4,7 +4,7 @@ const LOGIN_ATTEMPTS = 5
  * Checks that login attempts are greater than specified in constant and also that blockexpires is less than now
  * @param {Object} user - user object
  */
-const blockIsExpired = (user) =>
-  user.loginAttempts > LOGIN_ATTEMPTS && user.blockExpires <= new Date()
+const blockIsExpired = ({ loginAttempts = 0, blockExpires = '' }) =>
+  loginAttempts > LOGIN_ATTEMPTS && blockExpires <= new Date()
 
 module.exports = { blockIsExpired }

app/controllers/auth/helpers/blockUser.js

@@ -7,7 +7,7 @@ const { buildErrObject } = require('../../../middleware/utils')
  * Blocks a user by setting blockExpires to the specified date based on constant HOURS_TO_BLOCK
  * @param {Object} user - user object
  */
-const blockUser = (user) => {
+const blockUser = (user = {}) => {
   return new Promise((resolve, reject) => {
     user.blockExpires = addHours(new Date(), HOURS_TO_BLOCK)
     user.save((err, result) => {

app/controllers/auth/helpers/checkLoginAttemptsAndBlockExpires.js

@@ -5,7 +5,7 @@ const { buildErrObject } = require('../../../middleware/utils')
  *
  * @param {Object} user - user object.
  */
-const checkLoginAttemptsAndBlockExpires = (user) => {
+const checkLoginAttemptsAndBlockExpires = (user = {}) => {
   return new Promise((resolve, reject) => {
     // Let user try to login again after blockexpires, resets user loginAttempts
     if (blockIsExpired(user)) {

app/controllers/auth/helpers/checkPermissions.js

@@ -6,11 +6,11 @@ const { itemNotFound, buildErrObject } = require('../../../middleware/utils')
  * @param {Object} data - data object
  * @param {*} next - next callback
  */
-const checkPermissions = (data, next) => {
+const checkPermissions = ({ id = '', roles = [] }, next) => {
   return new Promise((resolve, reject) => {
-    User.findById(data.id, (err, result) => {
+    User.findById(id, (err, result) => {
       itemNotFound(err, result, 'NOT_FOUND')
-      if (data.roles.indexOf(result.role) > -1) {
+      if (roles.indexOf(result.role) > -1) {
         return resolve(next())
       }
       return reject(buildErrObject(401, 'UNAUTHORIZED'))

app/controllers/auth/helpers/findForgotPassword.js

@@ -5,7 +5,7 @@ const { itemNotFound } = require('../../../middleware/utils')
  * Checks if a forgot password verification exists
  * @param {string} id - verification id
  */
-const findForgotPassword = (id) => {
+const findForgotPassword = (id = '') => {
   return new Promise((resolve) => {
     ForgotPassword.findOne(
       {

app/controllers/auth/helpers/findUser.js

@@ -5,7 +5,7 @@ const { itemNotFound } = require('../../../middleware/utils')
  * Finds user by email
  * @param {string} email - user´s email
  */
-const findUser = (email) => {
+const findUser = (email = '') => {
   return new Promise((resolve) => {
     User.findOne(
       {

app/controllers/auth/helpers/findUserById.js

@@ -5,7 +5,7 @@ const { itemNotFound } = require('../../../middleware/utils')
  * Finds user by ID
  * @param {string} id - user´s id
  */
-const findUserById = (userId) => {
+const findUserById = (userId = '') => {
   return new Promise((resolve) => {
     User.findById(userId, (err, item) => {
       itemNotFound(err, item, 'USER_DOES_NOT_EXIST')

app/controllers/auth/helpers/findUserToResetPassword.js

@@ -5,7 +5,7 @@ const { itemNotFound } = require('../../../middleware/utils')
  * Finds user by email to reset password
  * @param {string} email - user email
  */
-const findUserToResetPassword = (email) => {
+const findUserToResetPassword = (email = '') => {
   return new Promise((resolve) => {
     User.findOne(
       {

app/controllers/auth/helpers/forgotPasswordResponse.js

@@ -2,15 +2,15 @@
  * Builds an object with created forgot password object, if env is development or testing exposes the verification
  * @param {Object} item - created forgot password object
  */
-const forgotPasswordResponse = (item) => {
+const forgotPasswordResponse = ({ email = '', verification = '' }) => {
   let data = {
     msg: 'RESET_EMAIL_SENT',
-    email: item.email
+    email
   }
   if (process.env.NODE_ENV !== 'production') {
     data = {
       ...data,
-      verification: item.verification
+      verification
     }
   }
   return data

app/controllers/auth/helpers/generateToken.js

@@ -5,7 +5,7 @@ const { encrypt } = require('../../../middleware/auth')
  * Generates a token
  * @param {Object} user - user object
  */
-const generateToken = (user) => {
+const generateToken = (user = '') => {
   // Gets expiration time
   const expiration =
     Math.floor(Date.now() / 1000) + 60 * process.env.JWT_EXPIRATION_IN_MINUTES