Fix check password

Author: davellanedam

app/controllers/profile/changePassword.js

@@ -1,11 +1,11 @@
-const { isIDGood, handleError } = require('../../middleware/utils')
-const { matchedData } = require('express-validator')
-const auth = require('../../middleware/auth')
 const {
-  findUser,
-  passwordsDoNotMatch,
-  changePasswordInDB
-} = require('./helpers')
+  isIDGood,
+  handleError,
+  buildErrObject
+} = require('../../middleware/utils')
+const { matchedData } = require('express-validator')
+const { checkPassword } = require('../../middleware/auth')
+const { findUser, changePasswordInDB } = require('./helpers')
 
 /**
  * Change password function called by route
@@ -17,9 +17,9 @@ const changePassword = async (req, res) => {
     const id = await isIDGood(req.user._id)
     const user = await findUser(id)
     req = matchedData(req)
-    const isPasswordMatch = await auth.checkPassword(req.oldPassword, user)
+    const isPasswordMatch = await checkPassword(req.oldPassword, user)
     if (!isPasswordMatch) {
-      handleError(res, await passwordsDoNotMatch())
+      return handleError(res, buildErrObject(409, 'WRONG_PASSWORD'))
     } else {
       // all ok, proceed to change password
       res.status(200).json(await changePasswordInDB(id, req))

app/middleware/auth/checkPassword.js

@@ -10,7 +10,7 @@ const checkPassword = (password, user) => {
   return new Promise((resolve, reject) => {
     user.comparePassword(password, (err, isMatch) => {
       if (err) {
-        reject(buildErrObject(422, err.message))
+        return reject(buildErrObject(422, err.message))
       }
       if (!isMatch) {
         resolve(false)